Attachment 349602 Details for Bug 189448 – WIP

[patch] WIP

bug-189448-20180912171219.patch (text/plain), 3.49 KB, created by Myles C. Maxfield on 2018-09-12 17:12:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2018-09-12 17:12:20 PDT

Size: 3.49 KB

patch

obsolete

>Subversion Revision: 235943
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2237346682a217619f49a06f75bad8db5df8ef3e..b0ed545ed012229d759c05cea0ed5188a79ab6a9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        Synthetic bold additional advances need to be applied after shaping
>+        https://bugs.webkit.org/show_bug.cgi?id=189448
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: fast/text/simple-synthetic-bold.html
>+
>+        * platform/graphics/WidthIterator.cpp:
>+        (WebCore::WidthIterator::advanceInternal):
>+        * platform/graphics/cocoa/FontCocoa.mm:
>+        (WebCore::Font::platformWidthForGlyph const):
>+
> 2018-09-12  Ali Juma  <ajuma@chromium.org>
> 
>         [IntersectionObserver] Implement rootMargin expansion
>diff --git a/Source/WebCore/platform/graphics/WidthIterator.cpp b/Source/WebCore/platform/graphics/WidthIterator.cpp
>index 9bde879703f6a4df114996a2a8cc77e1c717fc59..90b0566d4142c78608f5049e23892e0d1a669138 100644
>--- a/Source/WebCore/platform/graphics/WidthIterator.cpp
>+++ b/Source/WebCore/platform/graphics/WidthIterator.cpp
>@@ -333,7 +333,7 @@ inline unsigned WidthIterator::advanceInternal(TextIterator& textIterator, Glyph
>         widthSinceLastRounding += width;
> 
>         if (glyphBuffer)
>-            glyphBuffer->add(glyph, font, (rtl ? oldWidth + lastRoundingWidth : width), currentCharacter);
>+            glyphBuffer->add(glyph, font, (rtl ? oldWidth + lastRoundingWidth : width) + font->syntheticBoldOffset(), currentCharacter);
> 
>         lastRoundingWidth = width - oldWidth;
> 
>diff --git a/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm b/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm
>index f379106a0d219636f2bb7dc941d10b2134e11cb0..d1dc2b1b24590272a7650171c1690df167c0c34e 100644
>--- a/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm
>+++ b/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm
>@@ -594,7 +594,7 @@ float Font::platformWidthForGlyph(Glyph glyph) const
>         else
>             CTFontGetUnsummedAdvancesForGlyphsAndStyle(m_platformData.ctFont(), orientation, style, &glyph, &advance, 1);
>     }
>-    return advance.width + m_syntheticBoldOffset;
>+    return advance.width;
> }
> 
> bool Font::platformSupportsCodePoint(UChar32 character) const
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 43a8c59f0b8ca1f1c0e2db8073f50545b6f25e5f..c54e2a67e81dbc35107a2c03e69be656d03a5093 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        Synthetic bold additional advances need to be applied after shaping
>+        https://bugs.webkit.org/show_bug.cgi?id=189448
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/text/simple-synthetic-bold.html: Added.
>+
> 2018-09-12  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: fix test case failures in js-isLikelyStackTrace.html
>diff --git a/LayoutTests/fast/text/simple-synthetic-bold.html b/LayoutTests/fast/text/simple-synthetic-bold.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..0cadc75c7f0e251d29bbc3c5efad95d2a9f1db5c
>--- /dev/null
>+++ b/LayoutTests/fast/text/simple-synthetic-bold.html
>@@ -0,0 +1,11 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<meta charset="utf-8">
>+</head>
>+<body>
>+<div style="font: bold 16px 'Osaka';"><span id="target" style="background: red;">ããããããããããããããããã</span></div>
>+<script>
>+</script>
>+</body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 189448: 349240 | 349246 | 349248 | 349249 | 349251 | 349600 | 349602 | 349630 | 349634 | 349635 | 349645 | 349646 | 349649 | 349657 | 349665 | 349681 | 349692 | 349694 | 349703 | 349705 | 349710 | 349731 | 349732 | 349734 | 349737 | 349739 | 435524 | 435525 | 435528 | 436111 | 436125 | 436127 | 436132 | 436134 | 436141 | 436150 | 436152 | 436216 | 436607