Attachment 349601 Details for Bug 189527 – Patch

[patch] Patch

bug-189527-20180912171148.patch (text/plain), 5.17 KB, created by Jer Noble on 2018-09-12 17:11:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-09-12 17:11:49 PDT

Size: 5.17 KB

patch

obsolete

>Subversion Revision: 235955
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 5d0f9efbbe181884e876ea9951d82449ba0f1b34..2f61201a43789742b52631b5e9f5d23df6ab43d6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-09-11  Jer Noble  <jer.noble@apple.com>
>+
>+        Turn SourceBufferChangeTypeEnabled on by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189527
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/Settings.yaml:
>+
> 2018-08-29  Jer Noble  <jer.noble@apple.com>
> 
>         Enable USE_MEDIAREMOTE on iOS
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 479c407b7be73774be42e8ecf30a1c857f124c16..e80d97e1a044eb0afdff634d8cb57710303d265b 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-11  Jer Noble  <jer.noble@apple.com>
>+
>+        Turn SourceBufferChangeTypeEnabled on by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189527
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
>+
> 2018-08-22  Jer Noble  <jer.noble@apple.com>
> 
>         Refactoring: eliminate raw pointer usage in Fullscreen code
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index a58e9f0e001f0943bb847df6c39cbe8d56285fec..2bb18141096afbd24ad7e30d101106d14b03fe81 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-11  Jer Noble  <jer.noble@apple.com>
>+
>+        Turn SourceBufferChangeTypeEnabled on by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189527
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebView/WebPreferences.mm:
>+        (+[WebPreferences initialize]):
>+
> 2018-08-22  Jer Noble  <jer.noble@apple.com>
> 
>         Refactoring: eliminate raw pointer usage in Fullscreen code
>diff --git a/Source/WebCore/page/Settings.yaml b/Source/WebCore/page/Settings.yaml
>index 4743e647e0818949e67aefe5ddb7af34b7832240..77df06332110f9658e06243fde2f7b67af27156c 100644
>--- a/Source/WebCore/page/Settings.yaml
>+++ b/Source/WebCore/page/Settings.yaml
>@@ -431,7 +431,7 @@ mediaSourceEnabled:
>   conditional: MEDIA_SOURCE
> 
> sourceBufferChangeTypeEnabled:
>-  initial: false
>+  initial: true
>   conditional: MEDIA_SOURCE
> 
> # FIXME: Rename to allowMultiElementImplicitFormSubmission once we upstream the iOS changes to WebView.mm.
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 9db338e02090e9e169cf33e8643986628775af2a..3f83115a718195d3637f056ed6a0fdb1b47560e7 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1125,6 +1125,11 @@ IsSecureContextAttributeEnabled:
>   defaultValue: true
>   webcoreBinding: RuntimeEnabledFeatures
> 
>+SourceBufferChangeTypeEnabled:
>+  type: bool
>+  defaultValue: true
>+  condition: ENABLE(MEDIA_SOURCE)
>+
> # For experimental features:
> # The type should be boolean.
> # You must provide a humanReadableName and humanReadableDescription for all experimental features. They
>@@ -1270,14 +1275,6 @@ ProcessSwapOnCrossSiteNavigationEnabled:
>   category: internal
>   webcoreBinding: none
> 
>-SourceBufferChangeTypeEnabled:
>-  type: bool
>-  defaultValue: false
>-  humanReadableName: "Media Source Codec Switching Support"
>-  humanReadableDescription: "Media Source Codec Switching through changeType()"
>-  category: internal
>-  condition: ENABLE(MEDIA_SOURCE)
>-
> ResourceLoadStatisticsDebugMode:
>   type: bool
>   defaultValue: false
>diff --git a/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h b/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>index 9a86f39ecc806a48a40b7752536bd4f2cdeeacad..31606a0b005a42bf08cb5437c2a86078fa377abf 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>+++ b/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>@@ -380,7 +380,7 @@ WK_EXPORT bool WKPreferencesUseLegacyTextAlignPositionedElementBehavior(WKPrefer
> WK_EXPORT void WKPreferencesSetMediaSourceEnabled(WKPreferencesRef preferencesRef, bool enabled);
> WK_EXPORT bool WKPreferencesGetMediaSourceEnabled(WKPreferencesRef preferencesRef);
> 
>-// Defaults to false;
>+// Defaults to true;
> WK_EXPORT void WKPreferencesSetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef, bool enabled);
> WK_EXPORT bool WKPreferencesGetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef);
> 
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>index 2d1a9d73e8d70fb5204897584dec3907a78877e3..2221732e5fea61670f9c7f21dd9b9bfe24ecf626 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>@@ -605,7 +605,7 @@ + (void)initialize
>         [NSNumber numberWithBool:NO], WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey,
> #if ENABLE(MEDIA_SOURCE)
>         [NSNumber numberWithBool:YES], WebKitMediaSourceEnabledPreferenceKey,
>-        @NO, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
>+        @YES, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
> #endif
> #if ENABLE(SERVICE_CONTROLS)
>         [NSNumber numberWithBool:NO], WebKitImageControlsEnabledPreferenceKey,

Actions: View | Formatted Diff | Diff

Attachments on bug 189527: 349478 | 349601