Attachment 349597 Details for Bug 189569 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

scroll-off-1.patch (text/plain), 2.60 KB, created by Joseph Pecoraro on 2018-09-12 17:01:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2018-09-12 17:01:32 PDT

Size: 2.60 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 9c34e79a609..8b6887e55cb 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-09-12  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Opening inspector with a selected element might immediately scroll that element off screen in the DOM Tree outline
>+        https://bugs.webkit.org/show_bug.cgi?id=189569
>+        <rdar://problem/44397098>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/ElementsTabContentView.js:
>+        (WI.ElementsTabContentView):
>+        (WI.ElementsTabContentView.prototype._elementsTabDetailsSidebarCollapsedStateDidChange):
>+        Re-select the selected DOM node in the DOM Tree when the details sidebar
>+        opens/closes in the Elements tab.
>+
> 2018-09-11  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: fix test case failures in js-isLikelyStackTrace.html
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js
>index 1e2d6c1ffab..17fbd1a4d90 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js
>@@ -40,6 +40,8 @@ WI.ElementsTabContentView = class ElementsTabContentView extends WI.ContentBrows
> 
>         WI.frameResourceManager.addEventListener(WI.FrameResourceManager.Event.MainFrameDidChange, this._mainFrameDidChange, this);
>         WI.Frame.addEventListener(WI.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
>+
>+        WI.detailsSidebar.addEventListener(WI.Sidebar.Event.CollapsedStateDidChange, this._elementsTabDetailsSidebarCollapsedStateDidChange, this);
>     }
> 
>     static tabInfo()
>@@ -129,6 +131,24 @@ WI.ElementsTabContentView = class ElementsTabContentView extends WI.ContentBrows
> 
>         this._showDOMTreeContentView();
>     }
>+
>+    _elementsTabDetailsSidebarCollapsedStateDidChange(event)
>+    {
>+        if (!this.visible)
>+            return;
>+
>+        let domTreeContentView = this.contentBrowser.currentContentView;
>+        console.assert(domTreeContentView instanceof WI.DOMTreeContentView);
>+        if (!(domTreeContentView instanceof WI.DOMTreeContentView))
>+            return;
>+
>+        let domTreeOutline = domTreeContentView.domTreeOutline;
>+        let selectedDOMNode = domTreeOutline.selectedDOMNode();
>+        if (!selectedDOMNode)
>+            return;
>+
>+        domTreeOutline.selectDOMNode(selectedDOMNode);
>+    }
> };
> 
> WI.ElementsTabContentView.Type = "elements";

Flags:

joepeck: review-
joepeck: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189569: 349597 | 349625 | 349677 | 349691