Attachment 349573 Details for Bug 189555 – PATCH

[patch] PATCH

189555.diff (text/plain), 2.07 KB, created by Basuke Suzuki on 2018-09-12 13:11:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-09-12 13:11:01 PDT

Size: 2.07 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 593804b6fda..55707933ea8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-09-12  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Curl] Implement correct total received bytes.
>+        https://bugs.webkit.org/show_bug.cgi?id=189555
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Curl port only reported total network received bytes before decoding.
>+
>+        No new test. InspectorTest is only available for WebKitTestRunner.
>+
>+        * platform/network/curl/CurlRequest.cpp:
>+        (WebCore::CurlRequest::didReceiveData):
>+        (WebCore::CurlRequest::updateNetworkLoadMetrics):
>+        * platform/network/curl/CurlRequest.h:
>+
> 2018-09-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         [WTF] Add Markable<T, Traits>
>diff --git a/Source/WebCore/platform/network/curl/CurlRequest.cpp b/Source/WebCore/platform/network/curl/CurlRequest.cpp
>index 1403dc70a23..5d061ca1c38 100644
>--- a/Source/WebCore/platform/network/curl/CurlRequest.cpp
>+++ b/Source/WebCore/platform/network/curl/CurlRequest.cpp
>@@ -336,6 +336,7 @@ size_t CurlRequest::didReceiveData(Ref<SharedBuffer>&& buffer)
>     }
> 
>     auto receiveBytes = buffer->size();
>+    m_totalReceivedSize += receiveBytes;
> 
>     writeDataToDownloadFileIfEnabled(buffer);
> 
>@@ -641,6 +642,7 @@ void CurlRequest::updateNetworkLoadMetrics()
>         m_networkLoadMetrics = *metrics;
> 
>     m_networkLoadMetrics.requestHeaders = m_request.httpHeaderFields();
>+    m_networkLoadMetrics.responseBodyDecodedSize = m_totalReceivedSize;
> }
> 
> void CurlRequest::enableDownloadToFile()
>diff --git a/Source/WebCore/platform/network/curl/CurlRequest.h b/Source/WebCore/platform/network/curl/CurlRequest.h
>index 6f78f4fa799..d611b113c03 100644
>--- a/Source/WebCore/platform/network/curl/CurlRequest.h
>+++ b/Source/WebCore/platform/network/curl/CurlRequest.h
>@@ -197,6 +197,7 @@ private:
> 
>     CertificateInfo m_certificateInfo;
>     NetworkLoadMetrics m_networkLoadMetrics;
>+    size_t m_totalReceivedSize { 0 };
> };
> 
> } // namespace WebCore

Actions: View | Formatted Diff | Diff

Attachments on bug 189555: 349573