WebKit Bugzilla
Attachment 349539 Details for
Bug 189542
: [Win][Clang] error: non-constant-expression cannot be narrowed from type 'int' to 'SHORT'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-189542-20180912200748.patch (text/plain), 2.86 KB, created by
Fujii Hironori
on 2018-09-12 04:07:49 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Fujii Hironori
Created:
2018-09-12 04:07:49 PDT
Size:
2.86 KB
patch
obsolete
>Subversion Revision: 235932 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index e309fd34de6e62e0663c383c1156f26837901b03..8d39fac298400df86f18cecc23ddec30c2ea5622 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2018-09-12 Fujii Hironori <Hironori.Fujii@sony.com> >+ >+ [Win][Clang] error: non-constant-expression cannot be narrowed from type 'int' to 'SHORT' >+ https://bugs.webkit.org/show_bug.cgi?id=189542 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ No new tests (No behavior change). >+ >+ * platform/graphics/win/IntPointWin.cpp: >+ (WebCore::IntPoint::operator POINTS const): Narrowed m_x and m_y by using static_cast. >+ > 2018-09-11 Zan Dobersek <zdobersek@igalia.com> > > Unreviewed WPE build fix. >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 951c54eb5ab69f4d4807414ca91f8aa51253e699..0cd01765b9ed09c8460980f532d3892426ea148b 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,13 @@ >+2018-09-12 Fujii Hironori <Hironori.Fujii@sony.com> >+ >+ [Win][Clang] error: non-constant-expression cannot be narrowed from type 'int' to 'SHORT' >+ https://bugs.webkit.org/show_bug.cgi?id=189542 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UIProcess/win/WebInspectorProxyWin.cpp: >+ (WebKit::WebInspectorProxy::platformCreateFrontendPage): Narrowed initialWindowWidth and initialWindowHeight by using static_cast. >+ > 2018-09-11 Olivia Barnett <obarnett@apple.com> > > Implement the Web Share API for mac >diff --git a/Source/WebCore/platform/graphics/win/IntPointWin.cpp b/Source/WebCore/platform/graphics/win/IntPointWin.cpp >index f76749e8d370faa149023791bf16c321e5234cbf..419ccf9056307ba9406fbe97e320ab68b96b2040 100644 >--- a/Source/WebCore/platform/graphics/win/IntPointWin.cpp >+++ b/Source/WebCore/platform/graphics/win/IntPointWin.cpp >@@ -53,7 +53,7 @@ IntPoint::IntPoint(const POINTS& p) > > IntPoint::operator POINTS() const > { >- POINTS p = {m_x, m_y}; >+ POINTS p = { static_cast<SHORT>(m_x), static_cast<SHORT>(m_y) }; > return p; > } > >diff --git a/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp b/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp >index 758133d92dbd9de55aa7b821866da6d0c0035b3a..ee8627e2c35d54f78d9ae488a28ab2eded4c12f8 100644 >--- a/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp >+++ b/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp >@@ -231,7 +231,7 @@ WebPageProxy* WebInspectorProxy::platformCreateFrontendPage() > nullptr, // didRemoveNavigationGestureSnapshot > }; > >- RECT r = { 0, 0, initialWindowWidth, initialWindowHeight }; >+ RECT r = { 0, 0, static_cast<LONG>(initialWindowWidth), static_cast<LONG>(initialWindowHeight) }; > auto page = inspectedPage(); > m_inspectedViewWindow = page->viewWidget(); > m_inspectedViewParentWindow = ::GetParent(m_inspectedViewWindow);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189542
: 349539