Attachment 349531 Details for Bug 189540 – patch

[patch] patch

bug-189540-20180912101235.patch (text/plain), 2.94 KB, created by Pablo Saavedra on 2018-09-12 01:12:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Pablo Saavedra

Created: 2018-09-12 01:12:36 PDT

Size: 2.94 KB

patch

obsolete

>Subversion Revision: 235932
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index e309fd34de6e62e0663c383c1156f26837901b03..a504201e45255d93350c39c31be3e1815b44c8d4 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-09-12  Pablo Saavedra  <psaavedra@igalia.com>
>+
>+        Linking against libWPEWebKit-0.1.so is not posible when WPE is build with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF
>+        https://bugs.webkit.org/show_bug.cgi?id=189540
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Related issues:
>+
>+        * This issue is related with changes in https://bugs.webkit.org/show_bug.cgi?id=183080
>+        * This issue is introduced in https://bugs.webkit.org/show_bug.cgi?id=186547
>+
>+        No new tests, no changes in the functionality.
>+
>+        * platform/GStreamer.cmake:
>+        * platform/SourcesGLib.txt:
>+        * platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp:
>+        (WebCore::LibWebRTCProvider::webRTCAvailable):
>+
> 2018-09-11  Zan Dobersek  <zdobersek@igalia.com>
> 
>         Unreviewed WPE build fix.
>diff --git a/Source/WebCore/platform/GStreamer.cmake b/Source/WebCore/platform/GStreamer.cmake
>index ff0599f036434b0a0da720a2e034c4fb269cca20..d9a1fdb30c420f0981bfeef4dcdf4c96afdda25d 100644
>--- a/Source/WebCore/platform/GStreamer.cmake
>+++ b/Source/WebCore/platform/GStreamer.cmake
>@@ -36,7 +36,6 @@ if (ENABLE_VIDEO OR ENABLE_WEB_AUDIO)
>         platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp
>         platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp
>         platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp
>-        platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp
> 
>         platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp
>         platform/mediastream/gstreamer/GStreamerAudioCapturer.cpp
>diff --git a/Source/WebCore/platform/SourcesGLib.txt b/Source/WebCore/platform/SourcesGLib.txt
>index 3a18ad4cdc14f348a188c48975bd1d58084340d0..848019133b3be2915da44908fcad13bc6bd6520c 100644
>--- a/Source/WebCore/platform/SourcesGLib.txt
>+++ b/Source/WebCore/platform/SourcesGLib.txt
>@@ -35,3 +35,5 @@ platform/glib/SharedBufferGlib.cpp
> platform/glib/UserAgentGLib.cpp
> 
> platform/network/glib/NetworkStateNotifierGLib.cpp
>+
>+platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp
>diff --git a/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp b/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp
>index db81d147b1294fafa1384b6128541a5a51fdb245..42514af04dafc603003453a5e7f397ab68e532b4 100644
>--- a/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp
>+++ b/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp
>@@ -41,7 +41,11 @@ UniqueRef<LibWebRTCProvider> LibWebRTCProvider::create()
> 
> bool LibWebRTCProvider::webRTCAvailable()
> {
>+#if USE(LIBWEBRTC) && USE(GSTREAMER)
>     return true;
>+#else
>+    return false;
>+#endif
> }
> 
> #if USE(LIBWEBRTC) && USE(GSTREAMER)

Actions: View | Formatted Diff | Diff

Attachments on bug 189540: 349531 | 349532