Attachment 349500 Details for Bug 189535 – WIP

[patch] WIP

bug-189535-20180911185446.patch (text/plain), 1.37 KB, created by Thomas Denney on 2018-09-11 18:54:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Denney

Created: 2018-09-11 18:54:46 PDT

Size: 1.37 KB

patch

obsolete

>Subversion Revision: 235925
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index c684a5e7235e2a7675672b68550d048b7598f32f..26b58953c2203c2ccbe95e6b5850a19c6c4d2620 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-11  Thomas Denney  <tdenney@apple.com>
>+
>+        [WHLSL] The standard library should be fully tested
>+        https://bugs.webkit.org/show_bug.cgi?id=189535
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebGPUShadingLanguageRI/Test.js: Deleted the initial type check of the
>+        standard library; this now happens lazily.
>+
> 2018-09-07  Dean Jackson  <dino@apple.com>
> 
>         Add and expose Internal features from WebKit
>diff --git a/Tools/WebGPUShadingLanguageRI/Test.js b/Tools/WebGPUShadingLanguageRI/Test.js
>index 2bcea7d7da3cb382f1aabe2167ef3a7891392333..2b39a929588ae672114dffc7c3a51f0a5f6fb2ed 100644
>--- a/Tools/WebGPUShadingLanguageRI/Test.js
>+++ b/Tools/WebGPUShadingLanguageRI/Test.js
>@@ -7946,13 +7946,6 @@ function* doTest(testFilter)
>         throw new Error("Test setup is incomplete.");
>     let before = preciseTime();
> 
>-    print("Compiling standard library...");
>-    const compileBefore = preciseTime();
>-    yield;
>-    prepare();
>-    const compileAfter = preciseTime();
>-    print(`    OK, took ${Math.round((compileAfter - compileBefore) * 1000)} ms`);
>-
>     let names = [];
>     for (let s in tests)
>         names.push(s);

Actions: View | Formatted Diff | Diff

Attachments on bug 189535: 349500