Attachment 349492 Details for Bug 189382 – Patch

[patch] Patch

bug-189382-20180911164600.patch (text/plain), 1.99 KB, created by Wenson Hsieh on 2018-09-11 16:46:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-09-11 16:46:01 PDT

Size: 1.99 KB

patch

obsolete

>Subversion Revision: 235921
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index c684a5e7235e2a7675672b68550d048b7598f32f..2bc1e924b5f42a636cfb122614ef5190fc1c1977 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
>+        https://bugs.webkit.org/show_bug.cgi?id=189382
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix the test by specifying colors in RGB colorspace.
>+
>+        * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
>+        (TestWebKitAPI::TEST):
>+
> 2018-09-07  Dean Jackson  <dino@apple.com>
> 
>         Add and expose Internal features from WebKit
>diff --git a/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm b/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm
>index 150184e0582432f1be64a790c653ff6a4dde8c05..2787758126a34d73e3d265d1a3dd38566b7b0044 100644
>--- a/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm
>+++ b/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm
>@@ -270,7 +270,7 @@ TEST(FontManagerTests, ChangeFontColorWithColorPanel)
>     };
> 
>     // 1. Select "foo" and turn it red; verify that the font element is used for fully opaque colors.
>-    colorPanel.color = NSColor.redColor;
>+    colorPanel.color = [NSColor colorWithRed:1 green:0 blue:0 alpha:1];
>     [webView selectWord:nil];
>     [webView changeColor:colorPanel];
>     checkFontColorAtStartAndEndWithInputEvents("rgb(255, 0, 0)");
>@@ -296,7 +296,7 @@ TEST(FontManagerTests, ChangeFontColorWithColorPanel)
>     EXPECT_FALSE([[webView objectByEvaluatingJavaScript:@"!!bar.querySelector('font')"] boolValue]);
> 
>     // 4a. Now collapse the selection to the end and set the typing style color to green.
>-    colorPanel.color = NSColor.greenColor;
>+    colorPanel.color = [NSColor colorWithRed:0 green:1 blue:0 alpha:1];
>     [webView collapseToEnd];
>     [webView changeColor:colorPanel];
>     EXPECT_WK_STREQ("formatFontColor", [webView stringByEvaluatingJavaScript:@"lastInputEvent.inputType"]);

Actions: View | Formatted Diff | Diff

Attachments on bug 189382: 349376 | 349379 | 349380 | 349381 | 349382 | 349384 | 349397 | 349401 | 349492