Attachment 349478 Details for Bug 189527 – Patch

[patch] Patch

bug-189527-20180911154603.patch (text/plain), 5.24 KB, created by Jer Noble on 2018-09-11 15:46:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-09-11 15:46:04 PDT

Size: 5.24 KB

patch

obsolete

>Subversion Revision: 235897
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f29517f54255d634658ee2bc7a302ed615b85916..bad7432ed59f139e03eacfa86b9ea7303ac35ab3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-09-11  Jer Noble  <jer.noble@apple.com>
>+
>+        Turn SourceBufferChangeTypeEnabled on by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189527
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/Settings.yaml:
>+
> 2018-09-07  Jer Noble  <jer.noble@apple.com>
> 
>         [MediaCapabilities] Implement MediaEngineConfigurationFactory registration
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index e5fce94d0841dba1fa57bdf4cb096432159327e3..67bc3854cf290afab3bc6a2b1accf7eacd281271 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-11  Jer Noble  <jer.noble@apple.com>
>+
>+        Turn SourceBufferChangeTypeEnabled on by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189527
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
>+
> 2018-08-22  Jer Noble  <jer.noble@apple.com>
> 
>         Refactoring: eliminate raw pointer usage in Fullscreen code
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index c6400460ac1c46c0c7de0e8ff911ee2547ce89d8..ae8f9d093b943edcbc6f9713f5c53b8ea055910a 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-11  Jer Noble  <jer.noble@apple.com>
>+
>+        Turn SourceBufferChangeTypeEnabled on by default
>+        https://bugs.webkit.org/show_bug.cgi?id=189527
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebView/WebPreferences.mm:
>+        (+[WebPreferences initialize]):
>+
> 2018-08-22  Jer Noble  <jer.noble@apple.com>
> 
>         Refactoring: eliminate raw pointer usage in Fullscreen code
>diff --git a/Source/WebCore/page/Settings.yaml b/Source/WebCore/page/Settings.yaml
>index 4743e647e0818949e67aefe5ddb7af34b7832240..77df06332110f9658e06243fde2f7b67af27156c 100644
>--- a/Source/WebCore/page/Settings.yaml
>+++ b/Source/WebCore/page/Settings.yaml
>@@ -431,7 +431,7 @@ mediaSourceEnabled:
>   conditional: MEDIA_SOURCE
> 
> sourceBufferChangeTypeEnabled:
>-  initial: false
>+  initial: true
>   conditional: MEDIA_SOURCE
> 
> # FIXME: Rename to allowMultiElementImplicitFormSubmission once we upstream the iOS changes to WebView.mm.
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 4bee637908e8404f77f15a2c24228f8c370fcaaf..54c811d7f1a15d13f110225edce90be9738029e9 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1125,6 +1125,11 @@ IsSecureContextAttributeEnabled:
>   defaultValue: true
>   webcoreBinding: RuntimeEnabledFeatures
> 
>+SourceBufferChangeTypeEnabled:
>+  type: bool
>+  defaultValue: true
>+  condition: ENABLE(MEDIA_SOURCE)
>+
> # For experimental features:
> # The type should be boolean.
> # You must provide a humanReadableName and humanReadableName for all experimental features. They
>@@ -1333,14 +1338,6 @@ ProcessSwapOnCrossSiteNavigationEnabled:
>   category: experimental
>   webcoreBinding: none
> 
>-SourceBufferChangeTypeEnabled:
>-  type: bool
>-  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>-  humanReadableName: "Media Source Codec Switching Support"
>-  humanReadableDescription: "Enable Media Source Codec Switching through changeType()"
>-  category: experimental
>-  condition: ENABLE(MEDIA_SOURCE)
>-
> WebAPIStatisticsEnabled:
>   type: bool
>   defaultValue: false
>diff --git a/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h b/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>index a90ad3c12fc0e20d663d5033887bb34ba88b10a1..39ba5701ad18c36bcbfae1ba1869da4c643726ba 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>+++ b/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>@@ -377,7 +377,7 @@ WK_EXPORT bool WKPreferencesUseLegacyTextAlignPositionedElementBehavior(WKPrefer
> WK_EXPORT void WKPreferencesSetMediaSourceEnabled(WKPreferencesRef preferencesRef, bool enabled);
> WK_EXPORT bool WKPreferencesGetMediaSourceEnabled(WKPreferencesRef preferencesRef);
> 
>-// Defaults to false;
>+// Defaults to true;
> WK_EXPORT void WKPreferencesSetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef, bool enabled);
> WK_EXPORT bool WKPreferencesGetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef);
> 
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>index 2d1a9d73e8d70fb5204897584dec3907a78877e3..2221732e5fea61670f9c7f21dd9b9bfe24ecf626 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>@@ -605,7 +605,7 @@ + (void)initialize
>         [NSNumber numberWithBool:NO], WebKitUseLegacyTextAlignPositionedElementBehaviorPreferenceKey,
> #if ENABLE(MEDIA_SOURCE)
>         [NSNumber numberWithBool:YES], WebKitMediaSourceEnabledPreferenceKey,
>-        @NO, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
>+        @YES, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
> #endif
> #if ENABLE(SERVICE_CONTROLS)
>         [NSNumber numberWithBool:NO], WebKitImageControlsEnabledPreferenceKey,

Actions: View | Formatted Diff | Diff

Attachments on bug 189527: 349478 | 349601