Attachment 349448 Details for Bug 189512 – Patch

[patch] Patch

bug-189512-20180911140100.patch (text/plain), 9.59 KB, created by youenn fablet on 2018-09-11 14:01:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-09-11 14:01:01 PDT

Size: 9.59 KB

patch

obsolete

>Subversion Revision: 235912
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 9db5bbc80a920f5d0f443b2ead09857c2bb3f4e8..b51bbbbcce1c99d25953af13e4f6d55b6bb4b7e5 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-09-11  Youenn Fablet  <youenn@apple.com>
>+
>+        Remove MediaDevices NoInterfaceObject
>+        https://bugs.webkit.org/show_bug.cgi?id=189512
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Covered by rebased WPT tests.
>+
>+        * Modules/mediastream/MediaDevices.idl:
>+
> 2018-09-11  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         Shrink size of ResourseResponseBase
>diff --git a/Source/WebCore/Modules/mediastream/MediaDevices.idl b/Source/WebCore/Modules/mediastream/MediaDevices.idl
>index 08a2fda7e64be938ed1daad5a5f5fb8f074fd76a..61c7fd97d25b908e97cde45df23b4f6e14396a78 100644
>--- a/Source/WebCore/Modules/mediastream/MediaDevices.idl
>+++ b/Source/WebCore/Modules/mediastream/MediaDevices.idl
>@@ -31,8 +31,7 @@
> // FIXME 169871: should be subclass of EventTarget
> [
>     ActiveDOMObject,
>-    Conditional=MEDIA_STREAM,
>-    NoInterfaceObject,
>+    Conditional=MEDIA_STREAM
> ] interface MediaDevices : EventTarget {
>     attribute EventHandler ondevicechange;
>     Promise<sequence<MediaDeviceInfo>> enumerateDevices();
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 4cd9c80198807dbec0ea9913d4469ebbe9d2151f..3dba41057c64e35735e06e23abb4a1ce2f9991cc 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-11  Youenn Fablet  <youenn@apple.com>
>+
>+        Remove MediaDevices NoInterfaceObject
>+        https://bugs.webkit.org/show_bug.cgi?id=189512
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt:
>+        * web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt:
>+
> 2018-09-11  Chris Dumez  <cdumez@apple.com>
> 
>         Unreviewed, rebaseline imported/w3c/web-platform-tests/css/cssom/interfaces.html after r235889.
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt
>index 3f6224c68044289678e1caa085660d54ee923b00..0a7cac6557e7a959dc1a8d411d14266322629a7f 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt
>@@ -61,17 +61,17 @@ PASS OverconstrainedErrorEvent interface: existence and properties of interface
> PASS OverconstrainedErrorEvent interface: existence and properties of interface prototype object's "constructor" property 
> PASS OverconstrainedErrorEvent interface: existence and properties of interface prototype object's @@unscopables property 
> PASS OverconstrainedErrorEvent interface: attribute error 
>-FAIL MediaDevices interface: existence and properties of interface object assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface object length assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface object name assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: attribute ondevicechange assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: operation enumerateDevices() assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: operation getSupportedConstraints() assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: operation getUserMedia(MediaStreamConstraints) assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices must be primary interface of navigator.mediaDevices assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: existence and properties of interface object 
>+PASS MediaDevices interface object length 
>+PASS MediaDevices interface object name 
>+PASS MediaDevices interface: existence and properties of interface prototype object 
>+PASS MediaDevices interface: existence and properties of interface prototype object's "constructor" property 
>+PASS MediaDevices interface: existence and properties of interface prototype object's @@unscopables property 
>+PASS MediaDevices interface: attribute ondevicechange 
>+PASS MediaDevices interface: operation enumerateDevices() 
>+PASS MediaDevices interface: operation getSupportedConstraints() 
>+PASS MediaDevices interface: operation getUserMedia(MediaStreamConstraints) 
>+PASS MediaDevices must be primary interface of navigator.mediaDevices 
> PASS Stringification of navigator.mediaDevices 
> PASS MediaDevices interface: navigator.mediaDevices must inherit property "ondevicechange" with the proper type 
> PASS MediaDevices interface: navigator.mediaDevices must inherit property "enumerateDevices()" with the proper type 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt
>index 4c29673da6942980cb677cd9515d4b98a2a80ec7..94e4db530bd087a0532efcf585e00ef97909c297 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt
>@@ -61,16 +61,16 @@ PASS OverconstrainedErrorEvent interface: existence and properties of interface
> PASS OverconstrainedErrorEvent interface: existence and properties of interface prototype object's "constructor" property 
> PASS OverconstrainedErrorEvent interface: existence and properties of interface prototype object's @@unscopables property 
> PASS OverconstrainedErrorEvent interface: attribute error 
>-FAIL MediaDevices interface: existence and properties of interface object assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface object length assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface object name assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: attribute ondevicechange assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: operation enumerateDevices() assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: operation getSupportedConstraints() assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: operation getUserMedia(MediaStreamConstraints) assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: existence and properties of interface object 
>+PASS MediaDevices interface object length 
>+PASS MediaDevices interface object name 
>+PASS MediaDevices interface: existence and properties of interface prototype object 
>+PASS MediaDevices interface: existence and properties of interface prototype object's "constructor" property 
>+PASS MediaDevices interface: existence and properties of interface prototype object's @@unscopables property 
>+PASS MediaDevices interface: attribute ondevicechange 
>+PASS MediaDevices interface: operation enumerateDevices() 
>+PASS MediaDevices interface: operation getSupportedConstraints() 
>+PASS MediaDevices interface: operation getUserMedia(MediaStreamConstraints) 
> PASS MediaDeviceInfo interface: existence and properties of interface object 
> PASS MediaDeviceInfo interface object length 
> PASS MediaDeviceInfo interface object name

Actions: View | Formatted Diff | Diff

Attachments on bug 189512: 349419 | 349448 | 349951