Attachment 349419 Details for Bug 189512 – Patch

[patch] Patch

bug-189512-20180911114047.patch (text/plain), 10.41 KB, created by youenn fablet on 2018-09-11 11:40:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-09-11 11:40:48 PDT

Size: 10.41 KB

patch

obsolete

>Subversion Revision: 235861
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2c1c42ff0dded9962279e0d8a5c5c51936220794..eb94ff7df7ea9f7346eb11262155bfdd709faaa2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-09-11  Youenn Fablet  <youenn@apple.com>
>+
>+        Remove MediaDevices NoInterfaceObject
>+        https://bugs.webkit.org/show_bug.cgi?id=189512
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Covered by rebased WPT tests.
>+
>+        * Modules/mediastream/MediaDevices.idl:
>+
> 2018-09-10  Don Olmstead  <don.olmstead@sony.com>
> 
>         CBOR coders should only be compiled if WebAuthN is enabled
>diff --git a/Source/WebCore/Modules/mediastream/MediaDevices.idl b/Source/WebCore/Modules/mediastream/MediaDevices.idl
>index 08a2fda7e64be938ed1daad5a5f5fb8f074fd76a..61c7fd97d25b908e97cde45df23b4f6e14396a78 100644
>--- a/Source/WebCore/Modules/mediastream/MediaDevices.idl
>+++ b/Source/WebCore/Modules/mediastream/MediaDevices.idl
>@@ -31,8 +31,7 @@
> // FIXME 169871: should be subclass of EventTarget
> [
>     ActiveDOMObject,
>-    Conditional=MEDIA_STREAM,
>-    NoInterfaceObject,
>+    Conditional=MEDIA_STREAM
> ] interface MediaDevices : EventTarget {
>     attribute EventHandler ondevicechange;
>     Promise<sequence<MediaDeviceInfo>> enumerateDevices();
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index fe5c4bc3f2b75c77ca0825a8b53b35003d95867c..6438ee67fa6ad6625e1a574b0088fde872e47f78 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-11  Youenn Fablet  <youenn@apple.com>
>+
>+        Remove MediaDevices NoInterfaceObject
>+        https://bugs.webkit.org/show_bug.cgi?id=189512
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt:
>+        * web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt:
>+
> 2018-09-10  Rob Buis  <rbuis@igalia.com>
> 
>         XMLHttpRequest: overrideMimeType should not update the response's "Content-Type" header
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt
>index 17006761c55c34a58726a15fced21ced32719cd6..863a0c007f6a97fdc5ad101b70d43bdb91dfb063 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt
>@@ -103,21 +103,21 @@ PASS OverconstrainedErrorEvent interface: existence and properties of interface
> PASS OverconstrainedErrorEvent interface: existence and properties of interface prototype object's @@unscopables property 
> PASS OverconstrainedErrorEvent interface: attribute error 
> PASS Unscopable handled correctly for error property on OverconstrainedErrorEvent 
>-FAIL MediaDevices interface: existence and properties of interface object assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface object length assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface object name assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: attribute ondevicechange assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: existence and properties of interface object 
>+PASS MediaDevices interface object length 
>+PASS MediaDevices interface object name 
>+PASS MediaDevices interface: existence and properties of interface prototype object 
>+PASS MediaDevices interface: existence and properties of interface prototype object's "constructor" property 
>+PASS MediaDevices interface: existence and properties of interface prototype object's @@unscopables property 
>+PASS MediaDevices interface: attribute ondevicechange 
> PASS Unscopable handled correctly for ondevicechange property on MediaDevices 
>-FAIL MediaDevices interface: operation enumerateDevices() assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: operation enumerateDevices() 
> PASS Unscopable handled correctly for enumerateDevices() on MediaDevices 
>-FAIL MediaDevices interface: operation getSupportedConstraints() assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: operation getSupportedConstraints() 
> PASS Unscopable handled correctly for getSupportedConstraints() on MediaDevices 
>-FAIL MediaDevices interface: operation getUserMedia(MediaStreamConstraints) assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: operation getUserMedia(MediaStreamConstraints) 
> PASS Unscopable handled correctly for getUserMedia(MediaStreamConstraints) on MediaDevices 
>-FAIL MediaDevices must be primary interface of navigator.mediaDevices assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices must be primary interface of navigator.mediaDevices 
> PASS Stringification of navigator.mediaDevices 
> PASS MediaDevices interface: navigator.mediaDevices must inherit property "ondevicechange" with the proper type 
> PASS MediaDevices interface: navigator.mediaDevices must inherit property "enumerateDevices()" with the proper type 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt
>index 9c7dbe457ad39e1c7ed69ecfb526deceb840d419..3ba667c6cf663ff93a3b319676cf51de2192c1de 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt
>@@ -108,19 +108,23 @@ PASS OverconstrainedErrorEvent interface: existence and properties of interface
> PASS OverconstrainedErrorEvent interface: existence and properties of interface prototype object's @@unscopables property 
> PASS OverconstrainedErrorEvent interface: attribute error 
> PASS Unscopable handled correctly for error property on OverconstrainedErrorEvent 
>-FAIL MediaDevices interface: existence and properties of interface object assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface object length assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface object name assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>-FAIL MediaDevices interface: attribute ondevicechange assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+FAIL MediaDevices interface: existence and properties of interface object undefined is not an object (evaluating 'this.array
>+                     .members[this.base]
>+                     .has_extended_attribute')
>+PASS MediaDevices interface object length 
>+PASS MediaDevices interface object name 
>+FAIL MediaDevices interface: existence and properties of interface prototype object undefined is not an object (evaluating 'this.array
>+                         .members[inherit_interface]
>+                         .has_extended_attribute')
>+PASS MediaDevices interface: existence and properties of interface prototype object's "constructor" property 
>+PASS MediaDevices interface: existence and properties of interface prototype object's @@unscopables property 
>+PASS MediaDevices interface: attribute ondevicechange 
> PASS Unscopable handled correctly for ondevicechange property on MediaDevices 
>-FAIL MediaDevices interface: operation enumerateDevices() assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: operation enumerateDevices() 
> PASS Unscopable handled correctly for enumerateDevices() on MediaDevices 
>-FAIL MediaDevices interface: operation getSupportedConstraints() assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: operation getSupportedConstraints() 
> PASS Unscopable handled correctly for getSupportedConstraints() on MediaDevices 
>-FAIL MediaDevices interface: operation getUserMedia(MediaStreamConstraints) assert_own_property: self does not have own property "MediaDevices" expected property "MediaDevices" missing
>+PASS MediaDevices interface: operation getUserMedia(MediaStreamConstraints) 
> PASS Unscopable handled correctly for getUserMedia(MediaStreamConstraints) on MediaDevices 
> PASS MediaDeviceInfo interface: existence and properties of interface object 
> PASS MediaDeviceInfo interface object length

Actions: View | Formatted Diff | Diff

Attachments on bug 189512: 349419 | 349448 | 349951