Attachment 349418 Details for Bug 189511 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

typo-fix-1.patch (text/plain), 2.29 KB, created by Joseph Pecoraro on 2018-09-11 11:29:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2018-09-11 11:29:33 PDT

Size: 2.29 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b2f23f63b9d..ecd127d280b 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-11  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Fix typo "vritualized"
>+        https://bugs.webkit.org/show_bug.cgi?id=189511
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline):
>+        (WI.TreeOutline.prototype.registerScrollVirtualizer):
>+        (WI.TreeOutline.prototype.updateVirtualizedElements):
>+
> 2018-09-10  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Address some ESLint warnings
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index 4a1bfeb7ad4..eb63ab028ea 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -55,7 +55,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>         this._customIndent = false;
>         this._selectable = selectable;
> 
>-        this._vritualizedCurrentMiddleItem = NaN;
>+        this._virtualizedCurrentMiddleItem = NaN;
>         this._virtualizedScrollContainer = null;
>         this._virtualizedTreeItemHeight = NaN;
>         this._virtualizedTopSpacer = null;
>@@ -662,7 +662,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>         this._virtualizedScrollContainer.addEventListener("scroll", (event) => {
>             let {numberVisible, extraRows, firstItem} = this._calculateVirtualizedValues();
> 
>-            if (Math.abs(firstItem + (numberVisible / 2) - this._vritualizedCurrentMiddleItem) >= extraRows)
>+            if (Math.abs(firstItem + (numberVisible / 2) - this._virtualizedCurrentMiddleItem) >= extraRows)
>                 this.updateVirtualizedElements();
>         });
>     }
>@@ -735,7 +735,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>         if (shouldScroll)
>             this._virtualizedScrollContainer.scrollTop = (firstItem + extraRows) * this._virtualizedTreeItemHeight;
> 
>-        this._vritualizedCurrentMiddleItem = firstItem + (numberVisible / 2);
>+        this._virtualizedCurrentMiddleItem = firstItem + (numberVisible / 2);
>     }
> 
>     // Protected

Actions: View | Formatted Diff | Diff

Attachments on bug 189511: 349418