Attachment 349412 Details for Bug 189506 – patch

[patch] patch

bug-189506-20180911195929.patch (text/plain), 1.82 KB, created by Pablo Saavedra on 2018-09-11 10:59:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Pablo Saavedra

Created: 2018-09-11 10:59:31 PDT

Size: 1.82 KB

patch

obsolete

>Subversion Revision: 235897
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ef4d3e4b0d8b22081123ed8784715c1bf4f74b9f..0ee416bc4cdf0705f874ed07d03f269068a35c36 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-09-11  Pablo Saavedra  <psaavedra@igalia.com>
>+
>+        Add missing #if ENABLE(VIDEO) WebProcess/FullScreen/WebFullScreenManager.cpp
>+        https://bugs.webkit.org/show_bug.cgi?id=189506
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        m_pipStandbyElement is only defined in
>+        WebKit/WebProcess/FullScreen/WebFullScreenManager.h
>+        only when ENABLE(VIDEO) (see
>+        https://bugs.webkit.org/show_bug.cgi?id=181338)
>+
>+        * WebProcess/FullScreen/WebFullScreenManager.cpp:
>+        (WebKit::WebFullScreenManager::setPIPStandbyElement):
>+
> 2018-09-11  Woodrow Wang  <woodrow_wang@apple.com>
> 
>         Add Web API Statistics Collection
>diff --git a/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp b/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
>index 133a6c20d1acc31da43a83a25214c8667a8ee322..4cadc053dc1abd5d4e31ff0adb8895e20e0c5ef6 100644
>--- a/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
>+++ b/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
>@@ -99,6 +99,7 @@ void WebFullScreenManager::videoControlsManagerDidChange()
> 
> void WebFullScreenManager::setPIPStandbyElement(WebCore::HTMLVideoElement* pipStandbyElement)
> {
>+#if ENABLE(VIDEO)
>     if (pipStandbyElement == m_pipStandbyElement)
>         return;
> 
>@@ -109,6 +110,7 @@ void WebFullScreenManager::setPIPStandbyElement(WebCore::HTMLVideoElement* pipSt
> 
>     if (m_pipStandbyElement)
>         m_pipStandbyElement->setVideoFullscreenStandby(true);
>+#endif
> }
> 
> void WebFullScreenManager::didReceiveMessage(IPC::Connection& connection, IPC::Decoder& decoder)

Actions: View | Formatted Diff | Diff

Attachments on bug 189506: 349412