Attachment 349377 Details for Bug 189492 – Patch

[patch] Patch

bug-189492-20180911140915.patch (text/plain), 2.17 KB, created by Fujii Hironori on 2018-09-10 22:09:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-10 22:09:16 PDT

Size: 2.17 KB

patch

obsolete

>Subversion Revision: 235880
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index bab3dac97469911601769e07e0c8ee359b627ca8..c175200f92413171afa310afc8fde4debc10ea2f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang][DumpRenderTree] Add a constructor of AccessibilityUIElement for 0 or nullptr
>+        https://bugs.webkit.org/show_bug.cgi?id=189492
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        0 and nullptr can't be converted implicitly to AccessibilityUIElement.
>+
>+        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
>+        (AccessibilityUIElement::AccessibilityUIElement): Added a constructor AccessibilityUIElement(nullptr_t).
>+        * DumpRenderTree/AccessibilityUIElement.h: Added the declaration.
>+
> 2018-09-10  Thomas Denney  <tdenney@apple.com>
> 
>         [WHLSL] Inlining should be optional
>diff --git a/Tools/DumpRenderTree/AccessibilityUIElement.h b/Tools/DumpRenderTree/AccessibilityUIElement.h
>index 634ce8a8e411a0989f6820406f12f9659031bbef..7bc7d5af9de300d4df13f579f351bc513089a5c3 100644
>--- a/Tools/DumpRenderTree/AccessibilityUIElement.h
>+++ b/Tools/DumpRenderTree/AccessibilityUIElement.h
>@@ -65,6 +65,9 @@ class AccessibilityUIElement {
> public:
>     AccessibilityUIElement(PlatformUIElement);
>     AccessibilityUIElement(const AccessibilityUIElement&);
>+#if PLATFORM(WIN)
>+    AccessibilityUIElement(nullptr_t);
>+#endif
>     ~AccessibilityUIElement();
> 
>     PlatformUIElement platformUIElement() const { return m_element; }
>diff --git a/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp b/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
>index 4da2269244246e31547f3ebe2a71b58582357004..dd08edba60fa07116ea245357383a1d745a7f724 100644
>--- a/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
>+++ b/Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
>@@ -53,6 +53,11 @@ AccessibilityUIElement::AccessibilityUIElement(PlatformUIElement element)
> {
> }
> 
>+AccessibilityUIElement::AccessibilityUIElement(nullptr_t)
>+    : m_element(nullptr)
>+{
>+}
>+
> AccessibilityUIElement::AccessibilityUIElement(const AccessibilityUIElement& other)
>     : m_element(other.m_element)
> {

Actions: View | Formatted Diff | Diff

Attachments on bug 189492: 349377 | 349509 | 349513