Attachment 349370 Details for Bug 189490 – Patch

[patch] Patch

bug-189490-20180911105707.patch (text/plain), 7.15 KB, created by Fujii Hironori on 2018-09-10 18:57:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-10 18:57:09 PDT

Size: 7.15 KB

patch

obsolete

>Subversion Revision: 235877
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index cc605918098d1e4147496792f106cad87316e204..d044ec399dfaef2f464da1584481154a1e0e990c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        Remove unused needsDestruction class variables from HashTraits
>+        https://bugs.webkit.org/show_bug.cgi?id=189490
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        needsDestruction has been obsoleted in Bug 121983.
>+
>+        No new tests (No behavior change).
>+
>+        * css/makeprop.pl: Removed needsDestruction.
>+        * platform/graphics/FloatSizeHash.h: Ditto.
>+        * platform/graphics/IntPointHash.h: Ditto.
>+        * platform/graphics/IntRectHash.h: Ditto.
>+        * platform/graphics/IntSizeHash.h: Ditto.
>+        * platform/graphics/WidthCache.h: Ditto.
>+
> 2018-09-10  Megan Gardner  <megan_gardner@apple.com>
> 
>         Correctly interpret from angle for conic gradients
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index cea5ca9837137de9eeff2855956836378c369022..8a05180dfb789fccb339c1cd54df632375f55c0e 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        Remove unused needsDestruction class variables from HashTraits
>+        https://bugs.webkit.org/show_bug.cgi?id=189490
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * History/BinaryPropertyList.cpp: Removed needsDestruction.
>+
> 2018-09-07  Frederic Wang  <fwang@igalia.com>
> 
>         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
>diff --git a/Source/WebCore/css/makeprop.pl b/Source/WebCore/css/makeprop.pl
>index 3e36b1987453db2981809119356223b7403934f9..ae125fea67453c7279cb4b36765f3a94ecdd2ddc 100755
>--- a/Source/WebCore/css/makeprop.pl
>+++ b/Source/WebCore/css/makeprop.pl
>@@ -470,7 +470,6 @@ namespace WTF {
> template<> struct DefaultHash<WebCore::CSSPropertyID> { typedef IntHash<unsigned> Hash; };
> template<> struct HashTraits<WebCore::CSSPropertyID> : GenericHashTraits<WebCore::CSSPropertyID> {
>     static const bool emptyValueIsZero = true;
>-    static const bool needsDestruction = false;
>     static void constructDeletedValue(WebCore::CSSPropertyID& slot) { slot = static_cast<WebCore::CSSPropertyID>(WebCore::lastCSSProperty + 1); }
>     static bool isDeletedValue(WebCore::CSSPropertyID value) { return value == (WebCore::lastCSSProperty + 1); }
> };
>diff --git a/Source/WebCore/platform/graphics/FloatSizeHash.h b/Source/WebCore/platform/graphics/FloatSizeHash.h
>index 47c8482e2fed0c8cc59ed5f506bac56a0397f87e..f532d31236b4cd8d3ed96db57335bbc70cda4183 100644
>--- a/Source/WebCore/platform/graphics/FloatSizeHash.h
>+++ b/Source/WebCore/platform/graphics/FloatSizeHash.h
>@@ -43,7 +43,6 @@ template<> struct DefaultHash<WebCore::FloatSize> {
> 
> template<> struct HashTraits<WebCore::FloatSize> : GenericHashTraits<WebCore::FloatSize> {
>     static const bool emptyValueIsZero = true;
>-    static const bool needsDestruction = false;
>     static void constructDeletedValue(WebCore::FloatSize& slot) { new (NotNull, &slot) WebCore::FloatSize(-1, -1); }
>     static bool isDeletedValue(const WebCore::FloatSize& value) { return value.width() == -1 && value.height() == -1; }
> };
>diff --git a/Source/WebCore/platform/graphics/IntPointHash.h b/Source/WebCore/platform/graphics/IntPointHash.h
>index 9c6621e0247611c4103be2e18ff9bec8e99037f6..a7ae3ad9bbaeb0321fcd34a686b9627559dc00eb 100644
>--- a/Source/WebCore/platform/graphics/IntPointHash.h
>+++ b/Source/WebCore/platform/graphics/IntPointHash.h
>@@ -33,7 +33,6 @@ struct IntPointHash {
>     static const bool safeToCompareToEmptyOrDeleted = true;
> };
> template<> struct HashTraits<WebCore::IntPoint> : GenericHashTraits<WebCore::IntPoint> {
>-    static const bool needsDestruction = false;
>     static WebCore::IntPoint emptyValue() { return WebCore::IntPoint(0, std::numeric_limits<int>::min()); }
>     
>     static void constructDeletedValue(WebCore::IntPoint& slot) { slot = WebCore::IntPoint(std::numeric_limits<int>::min(), 0); }
>diff --git a/Source/WebCore/platform/graphics/IntRectHash.h b/Source/WebCore/platform/graphics/IntRectHash.h
>index cfc43f8bc192e822c9cfd442a7c0438f8a4a1d1b..9d90da72a7b96085b1266dc99110036dd49ea84e 100644
>--- a/Source/WebCore/platform/graphics/IntRectHash.h
>+++ b/Source/WebCore/platform/graphics/IntRectHash.h
>@@ -48,7 +48,6 @@ template<> struct DefaultHash<WebCore::IntRect> { typedef IntHash<WebCore::IntRe
> 
> template<> struct HashTraits<WebCore::IntRect> : GenericHashTraits<WebCore::IntRect> {
>     static const bool emptyValueIsZero = true;
>-    static const bool needsDestruction = false;
>     static void constructDeletedValue(WebCore::IntRect& slot) { new (NotNull, &slot) WebCore::IntRect(-1, -1, -1, -1); }
>     static bool isDeletedValue(const WebCore::IntRect& value) { return value.x() == -1 && value.y() == -1 && value.width() == -1 && value.height() == -1; }
> };
>diff --git a/Source/WebCore/platform/graphics/IntSizeHash.h b/Source/WebCore/platform/graphics/IntSizeHash.h
>index 944baabbdf55c54d5f17b9035b5327103fcaeb6e..79f4e8abf6ea19b447ad095e46bb19aed50f72e4 100644
>--- a/Source/WebCore/platform/graphics/IntSizeHash.h
>+++ b/Source/WebCore/platform/graphics/IntSizeHash.h
>@@ -34,7 +34,6 @@ namespace WTF {
>     
>     template<> struct HashTraits<WebCore::IntSize> : GenericHashTraits<WebCore::IntSize> {
>         static const bool emptyValueIsZero = true;
>-        static const bool needsDestruction = false;
>         static void constructDeletedValue(WebCore::IntSize& slot) { new (NotNull, &slot) WebCore::IntSize(-1, -1); }
>         static bool isDeletedValue(const WebCore::IntSize& value) { return value.width() == -1 && value.height() == -1; }
>     };
>diff --git a/Source/WebCore/platform/graphics/WidthCache.h b/Source/WebCore/platform/graphics/WidthCache.h
>index 98f9403e61b4acbc2d981079ebc732dec1f4df9f..e8d72e096b942ea51ea005a2fa2a61f10760d72e 100644
>--- a/Source/WebCore/platform/graphics/WidthCache.h
>+++ b/Source/WebCore/platform/graphics/WidthCache.h
>@@ -106,7 +106,6 @@ private:
>     struct SmallStringKeyHashTraits : WTF::SimpleClassHashTraits<SmallStringKey> {
>         static const bool hasIsEmptyValueFunction = true;
>         static bool isEmptyValue(const SmallStringKey& key) { return key.isHashTableEmptyValue(); }
>-        static const bool needsDestruction = false;
>         static const int minimumTableSize = 16;
>     };
> 
>diff --git a/Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp b/Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp
>index 6d474a26c522ae717d9bb7a208d236ab38e57989..dc77f8f84d0343901b9aeea5550fd378d8032896 100644
>--- a/Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp
>+++ b/Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp
>@@ -76,7 +76,6 @@ inline bool operator==(const IntegerArray& a, const IntegerArray& b)
> }
> 
> struct IntegerArrayHashTraits : WTF::GenericHashTraits<IntegerArray> {
>-    static const bool needsDestruction = false;
>     static void constructDeletedValue(IntegerArray& slot) { slot.markDeleted(); }
>     static bool isDeletedValue(const IntegerArray& array) { return array.isDeletedValue(); }
> };

Actions: View | Formatted Diff | Diff

Attachments on bug 189490: 349370