Attachment 349366 Details for Bug 189178 – Follow up changes for High Sierra

[patch] Follow up changes for High Sierra

Follow up changes for High Sierra.patch (text/plain), 3.56 KB, created by James Savage on 2018-09-10 18:00:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: James Savage

Created: 2018-09-10 18:00:55 PDT

Size: 3.56 KB

patch

obsolete

>From 8f504a9556115f993c160c4af71df12bf3e6c279 Mon Sep 17 00:00:00 2001
>From: James Savage <james.savage@apple.com>
>Date: Mon, 10 Sep 2018 17:58:33 -0700
>Subject: Follow up changes for High Sierra
>
>---
> LayoutTests/ChangeLog                           | 11 +++++++++++
> .../apple-system-control-colors-expected.txt    |  2 +-
> Source/WebCore/ChangeLog                        | 17 +++++++++++++++++
> Source/WebCore/rendering/RenderThemeMac.mm      |  2 ++
> 4 files changed, 31 insertions(+), 1 deletion(-)
>
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 09edb95156b..6adec17dd82 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-09-10  James Savage  <james.savage@apple.com>
>+
>+        Follow up to:
>+        Expose -apple-system-container-border color to internal web views.
>+        https://bugs.webkit.org/show_bug.cgi?id=189178.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt:
>+        Reset test expectations to go along with fix.
>+
> 2018-09-10  Truitt Savell  <tsavell@apple.com>
> 
>         Rebaseline test after https://trac.webkit.org/changeset/235866/webkit.
>diff --git a/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt b/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt
>index 0c8bd9e327c..8d65ee0f69e 100644
>--- a/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt
>+++ b/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt
>@@ -19,5 +19,5 @@
> -apple-system-quaternary-label : rgba(0, 0, 0, 0.0980392)
> -apple-system-grid : rgb(204, 204, 204)
> -apple-system-separator : rgb(204, 204, 204)
>--apple-system-container-border : rgba(0, 0, 0, 0)
>+-apple-system-container-border : rgb(197, 197, 197)
> current-color with inherited -apple-system-label : rgba(0, 0, 0, 0.85098)
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 737b51e495f..fafa01a8818 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-09-10  James Savage  <james.savage@apple.com>
>+
>+        Follow up to:
>+        Expose -apple-system-container-border color to internal web views.
>+        https://bugs.webkit.org/show_bug.cgi?id=189178.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * rendering/RenderThemeMac.mm:
>+        (WebCore::RenderThemeMac::systemColor const): Add a separate #if block for
>+        Mojave. When I used CSSValueAppleSystemFindHighlightBackground as a template
>+        for this change, I had to write out the condition in the first change, but
>+        mistakenly thought I could reuse the block here. Turns out the versions were
>+        different, and I could not.
>+
> 2018-09-10  Youenn Fablet  <youenn@apple.com>
> 
>         ontrack events should be fired even if an existing transceiver exists
>diff --git a/Source/WebCore/rendering/RenderThemeMac.mm b/Source/WebCore/rendering/RenderThemeMac.mm
>index 4fea87d85a8..91cd6de7b85 100644
>--- a/Source/WebCore/rendering/RenderThemeMac.mm
>+++ b/Source/WebCore/rendering/RenderThemeMac.mm
>@@ -867,7 +867,9 @@ Color RenderThemeMac::systemColor(CSSValueID cssValueID, OptionSet<StyleColor::O
> #if __MAC_OS_X_VERSION_MIN_REQUIRED < 101300
>         case CSSValueAppleSystemFindHighlightBackground:
>             return platformActiveTextSearchHighlightColor(options);
>+#endif
> 
>+#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101400
>         case CSSValueAppleSystemContainerBorder:
>             return 0xFFC5C5C5;
> #endif
>-- 
>2.17.1 (Apple Git-112)
>

Flags:

timothy: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189178: 348575 | 348578 | 348585 | 348587 | 349003 | 349007 | 349008 | 349054 | 349222 | 349228 | 349232 | 349366 | 349470