Attachment 349323 Details for Bug 189480 – Remove useless argument

[patch] Remove useless argument

bug-189480-20180910132940.patch (text/plain), 2.60 KB, created by mitz on 2018-09-10 13:29:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2018-09-10 13:29:41 PDT

Size: 2.60 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 235856)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-09-10  Dan Bernstein  <mitz@apple.com>
>+
>+        [macOS] Editor::readSelectionFromPasteboardâs MailBlockquoteHandling argument is effectively unused
>+        https://bugs.webkit.org/show_bug.cgi?id=189480
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests, because this doesnât change behavior.
>+
>+        * editing/Editor.h: Removed the MailBlockquoteHandling argument from
>+          readSelectionFromPasteboard.
>+        * editing/mac/EditorMac.mm:
>+        (WebCore::Editor::readSelectionFromPasteboard): Donât pass mailBlockquoteHandling to
>+          pasteWithPasteboard. It was always set to RespectBlockquote, which is the latterâs
>+          default.
>+
> 2018-09-10  Andy Estes  <aestes@apple.com>
> 
>         [Payment Request] Use JSValueInWrappedObject for PaymentResponse's details attribute
>Index: Source/WebCore/editing/Editor.h
>===================================================================
>--- Source/WebCore/editing/Editor.h	(revision 235764)
>+++ Source/WebCore/editing/Editor.h	(working copy)
>@@ -471,7 +471,7 @@ public:
> #if !PLATFORM(IOS)
>     bool canCopyExcludingStandaloneImages();
>     void takeFindStringFromSelection();
>-    WEBCORE_EXPORT void readSelectionFromPasteboard(const String& pasteboardName, MailBlockquoteHandling = MailBlockquoteHandling::RespectBlockquote);
>+    WEBCORE_EXPORT void readSelectionFromPasteboard(const String& pasteboardName);
>     WEBCORE_EXPORT void replaceNodeFromPasteboard(Node*, const String& pasteboardName);
>     WEBCORE_EXPORT RefPtr<SharedBuffer> dataSelectionForPasteboard(const String& pasteboardName);
> #endif // !PLATFORM(IOS)
>Index: Source/WebCore/editing/mac/EditorMac.mm
>===================================================================
>--- Source/WebCore/editing/mac/EditorMac.mm	(revision 235764)
>+++ Source/WebCore/editing/mac/EditorMac.mm	(working copy)
>@@ -118,11 +118,11 @@ void Editor::takeFindStringFromSelection
> #pragma clang diagnostic pop
> }
> 
>-void Editor::readSelectionFromPasteboard(const String& pasteboardName, MailBlockquoteHandling mailBlockquoteHandling)
>+void Editor::readSelectionFromPasteboard(const String& pasteboardName)
> {
>     Pasteboard pasteboard(pasteboardName);
>     if (m_frame.selection().selection().isContentRichlyEditable())
>-        pasteWithPasteboard(&pasteboard, true, mailBlockquoteHandling);
>+        pasteWithPasteboard(&pasteboard, true);
>     else
>         pasteAsPlainTextWithPasteboard(pasteboard);
> }

Flags:

andersca: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 189480: 349323