Attachment 349311 Details for Bug 182230 – Patch (follow-up fix)

[patch] Patch (follow-up fix)

182230.patch (text/plain), 2.39 KB, created by Frédéric Wang (:fredw) on 2018-09-10 08:59:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Wang (:fredw)

Created: 2018-09-10 08:59:31 PDT

Size: 2.39 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 608c3d645bf..da5cb480a52 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-10  Frederic Wang  <fwang@igalia.com>
>+
>+        [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
>+        https://bugs.webkit.org/show_bug.cgi?id=182230
>+
>+        Follow-up patch replacing document.body with document.scrollingElement in
>+        fast-scroll-iframe-latched-mainframe.html. This fixes flaky behavior.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html: Replace document.body
>+        with document.scrollingElement since this document is in standard mode.
>+
> 2018-09-10  Per Arne Vollan  <pvollan@apple.com>
> 
>         [Windows] Layout Test webanimations/accelerated-transition-interrupted-on-composited-element.html is failing
>diff --git a/LayoutTests/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html b/LayoutTests/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html
>index 7378f7cb712..5680599ff92 100644
>--- a/LayoutTests/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html
>+++ b/LayoutTests/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html
>@@ -19,15 +19,15 @@ function onLoad()
> 
> function onPageScroll()
> {
>-    if (document.body.scrollTop >= 70)
>+    if (document.scrollingElement.scrollTop >= 70)
>         checkForScroll();
> }
> 
> function checkForScroll()
> {
>     // The IFrame should not have scrolled at all.
>-    var pageScrollPositionAfter = document.body.scrollTop;
>-    var iFrameScrollPositionAfter = window.frames['target'].document.body.scrollTop;
>+    var pageScrollPositionAfter = document.scrollingElement.scrollTop;
>+    var iFrameScrollPositionAfter = window.frames['target'].document.scrollingElement.scrollTop;
> 
>     if (iFrameScrollPositionBefore != iFrameScrollPositionAfter)
>         testFailed("IFrame consumed wheel events.");
>@@ -44,8 +44,8 @@ function checkForScroll()
> 
> function scrollTest()
> {
>-    pageScrollPositionBefore = document.body.scrollTop;
>-    iFrameScrollPositionBefore = window.frames['target'].document.body.scrollTop;
>+    pageScrollPositionBefore = document.scrollingElement.scrollTop;
>+    iFrameScrollPositionBefore = window.frames['target'].document.scrollingElement.scrollTop;
> 
>     iframeTarget = document.getElementById('target');
>

Flags:

tonikitoo: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 182230: 332512 | 332513 | 332516 | 332519 | 332520 | 332529 | 332645 | 332650 | 332653 | 332857 | 332864 | 332874 | 340079 | 344695 | 348498 | 348619 | 348621 | 348623 | 348625 | 348627 | 348634 | 348769 | 348772 | 349118 | 349170 | 349174 | 349311