Attachment 349269 Details for Bug 188724 – Patch

[patch] Patch

bug-188724-20180908180600.patch (text/plain), 1.73 KB, created by Simon Fraser (smfr) on 2018-09-08 18:06:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2018-09-08 18:06:01 PDT

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 235830
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 782e417f1d57f6382ac8c4f35cd1b8622812fd56..3ce40a691b5af0702818fe30bc626f44d8cbffec 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-08  Simon Fraser  <simon.fraser@apple.com>
>+
>+        accessibility/notification-listeners.html abandons a document
>+        https://bugs.webkit.org/show_bug.cgi?id=188724
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        AccessibilityControllerMac leaked m_globalNotificationHandler, which leaks a JSValueProtect'd function,
>+        which leaks a Document. Fix by using adoptNS().
>+
>+        * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
>+        (WTR::AccessibilityController::addNotificationListener):
>+
> 2018-09-08  Simon Fraser  <simon.fraser@apple.com>
> 
>         Make it possible to track unbalanced ref()/deref()
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm b/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm
>index 310fa4871542e7f8bdb911736385498a19e04e77..a38c76818fcbf12cf15cde859cc76f746f87cadf 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm
>+++ b/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm
>@@ -51,7 +51,8 @@ bool AccessibilityController::addNotificationListener(JSValueRef functionCallbac
> 
>     if (m_globalNotificationHandler)
>         return false;
>-    m_globalNotificationHandler = [[AccessibilityNotificationHandler alloc] init];
>+
>+    m_globalNotificationHandler = adoptNS([[AccessibilityNotificationHandler alloc] init]);
>     [m_globalNotificationHandler.get() setCallback:functionCallback];
>     [m_globalNotificationHandler.get() startObserving];
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188724: 349267 | 349269