Attachment 349253 Details for Bug 189449 – Removed the check

[patch] Removed the check

bug-189449-20180908015605.patch (text/plain), 2.03 KB, created by Ryosuke Niwa on 2018-09-08 01:56:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-09-08 01:56:06 PDT

Size: 2.03 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 235827)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-09-08  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        Remove isOrphan check in ShadowRoot::setInnerHTML
>+        https://bugs.webkit.org/show_bug.cgi?id=189449
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Removed isOrphan() check in ShadowRoot::setInnerHTML needed for webkit.org/b/88834.
>+
>+        The only reason this check was kept in the code was because the fix for V8 couldn't be landed
>+        due to a perf regression but V8 binding isn't even a thing in WebKit anymore.
>+
>+        * dom/ShadowRoot.cpp:
>+        (WebCore::ShadowRoot::setInnerHTML):
>+        * dom/ShadowRoot.h:
>+
> 2018-09-07  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [Win][Clang] exceptionShouldTerminateProgram of StructuredExceptionHandlerSuppressor.cpp should take DWORD
>Index: Source/WebCore/dom/ShadowRoot.cpp
>===================================================================
>--- Source/WebCore/dom/ShadowRoot.cpp	(revision 235643)
>+++ Source/WebCore/dom/ShadowRoot.cpp	(working copy)
>@@ -131,8 +131,6 @@ String ShadowRoot::innerHTML() const
> 
> ExceptionOr<void> ShadowRoot::setInnerHTML(const String& markup)
> {
>-    if (isOrphan())
>-        return Exception { InvalidAccessError };
>     auto fragment = createFragmentForInnerOuterHTML(*host(), markup, AllowScriptingContent);
>     if (fragment.hasException())
>         return fragment.releaseException();
>Index: Source/WebCore/dom/ShadowRoot.h
>===================================================================
>--- Source/WebCore/dom/ShadowRoot.h	(revision 235643)
>+++ Source/WebCore/dom/ShadowRoot.h	(working copy)
>@@ -91,9 +91,6 @@ protected:
> 
>     ShadowRoot(Document&, std::unique_ptr<SlotAssignment>&&);
> 
>-    // FIXME: This shouldn't happen. https://bugs.webkit.org/show_bug.cgi?id=88834
>-    bool isOrphan() const { return !m_host; }
>-
> private:
>     bool childTypeAllowed(NodeType) const override;
>

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 189449: 349253