Attachment 349168 Details for Bug 189423 – Patch

[patch] Patch

bug-189423.diff (text/plain), 2.53 KB, created by Don Olmstead on 2018-09-07 11:37:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Don Olmstead

Created: 2018-09-07 11:37:21 PDT

Size: 2.53 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8ebfd969209..e954a2c8c3b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-07  Don Olmstead  <don.olmstead@sony.com>
>+
>+        [AX] Fix compile error in AXObjectCache constructor when !HAVE(ACCESSIBILITY)
>+        https://bugs.webkit.org/show_bug.cgi?id=189423
>+        <rdar://problem/44231775>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests. Compilation fix.
>+
>+        * accessibility/AXObjectCache.h:
>+        (WebCore::AXObjectCache::AXObjectCache):
>+
> 2018-09-06  Ali Juma  <ajuma@chromium.org>
> 
>         IntersectionObserver leaks documents
>diff --git a/Source/WebCore/accessibility/AXObjectCache.h b/Source/WebCore/accessibility/AXObjectCache.h
>index 1754759208f..3e4c6146d9b 100644
>--- a/Source/WebCore/accessibility/AXObjectCache.h
>+++ b/Source/WebCore/accessibility/AXObjectCache.h
>@@ -480,7 +480,7 @@ inline AccessibilityObjectInclusion AXComputedObjectAttributeCache::getIgnored(A
> inline AccessibilityReplacedText::AccessibilityReplacedText(const VisibleSelection&) { }
> inline void AccessibilityReplacedText::postTextStateChangeNotification(AXObjectCache*, AXTextEditType, const String&, const VisibleSelection&) { }
> inline void AXComputedObjectAttributeCache::setIgnored(AXID, AccessibilityObjectInclusion) { }
>-inline AXObjectCache::AXObjectCache(Document& document) : m_document(document), m_notificationPostTimer(*this, &AXObjectCache::notificationPostTimerFired), m_passwordNotificationPostTimer(*this, &AXObjectCache::passwordNotificationPostTimerFired), m_liveRegionChangedPostTimer(*this, &AXObjectCache::liveRegionChangedNotificationPostTimerFired), m_focusModalNodeTimer(*this, &AXObjectCache::focusModalNodeTimerFired, m_performCacheUpdateTimer(*this, &AXObjectCache::performCacheUpdateTimerFired)) { }
>+inline AXObjectCache::AXObjectCache(Document& document) : m_document(document), m_notificationPostTimer(*this, &AXObjectCache::notificationPostTimerFired), m_passwordNotificationPostTimer(*this, &AXObjectCache::passwordNotificationPostTimerFired), m_liveRegionChangedPostTimer(*this, &AXObjectCache::liveRegionChangedNotificationPostTimerFired), m_focusModalNodeTimer(*this, &AXObjectCache::focusModalNodeTimerFired), m_performCacheUpdateTimer(*this, &AXObjectCache::performCacheUpdateTimerFired) { }
> inline AXObjectCache::~AXObjectCache() { }
> inline AccessibilityObject* AXObjectCache::focusedUIElementForPage(const Page*) { return nullptr; }
> inline AccessibilityObject* AXObjectCache::get(RenderObject*) { return nullptr; }

Actions: View | Formatted Diff | Diff

Attachments on bug 189423: 349168