Attachment 349163 Details for Bug 189349 – Patch

[patch] Patch

bug-189349-20180907200459.patch (text/plain), 6.05 KB, created by Philippe Normand on 2018-09-07 11:05:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Normand

Created: 2018-09-07 11:05:00 PDT

Size: 6.05 KB

patch

obsolete

>Subversion Revision: 235780
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 68c6ab7b8e58805e4223fe6c4e009ddb9532807e..d33451495be4c60eaef679ab74ec2713e0f9e25f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-09-07  Philippe Normand  <pnormand@igalia.com>
>+
>+        [GTK] Several media related tests timing out around the same revision
>+        https://bugs.webkit.org/show_bug.cgi?id=189349
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The timeouts were happening because the `ended` event was no
>+        longer properly emitted. The change in playbackPosition also
>+        ensures `timeupdate` event remains emitted in a... timely manner.
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamer::playbackPosition const):
>+        Reduce the position cache threshold to 200ms, which is a value
>+        slightly lower than the 250ms defined in HTMLMediaElement.
>+        (WebCore::MediaPlayerPrivateGStreamer::didEnd): Reset the cached
>+        position value to ensure the following query will most likely
>+        return the same value as reported by the duration query.
>+
> 2018-09-06  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         ShadowRoot should have its own node flag
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index a36d1a4956743892fe6651e4f080cdea2c8dcc73..c26bba393bf786709e5c2a65665e7f3bba96357b 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -345,7 +345,7 @@ MediaTime MediaPlayerPrivateGStreamer::playbackPosition() const
>         return m_seekTime;
> 
>     double now = WTF::WallTime::now().secondsSinceEpoch().milliseconds();
>-    if (m_lastQuery > -1 && ((now - m_lastQuery) < 300) && m_cachedPosition.isValid())
>+    if (m_lastQuery > -1 && ((now - m_lastQuery) < 200) && m_cachedPosition.isValid())
>         return m_cachedPosition;
> 
>     m_lastQuery = now;
>@@ -2149,6 +2149,7 @@ void MediaPlayerPrivateGStreamer::didEnd()
>     // Synchronize position and duration values to not confuse the
>     // HTMLMediaElement. In some cases like reverse playback the
>     // position is not always reported as 0 for instance.
>+    m_cachedPosition = MediaTime::invalidTime();
>     MediaTime now = currentMediaTime();
>     if (now > MediaTime { } && now <= durationMediaTime())
>         m_player->durationChanged();
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index f5a27fd3cfbd5fc5573de8920579ce7e7066617d..76924aff2ccb709af0af64e4673d5bc36f175ce8 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-09-07  Philippe Normand  <pnormand@igalia.com>
>+
>+        [GTK] Several media related tests timing out around the same revision
>+        https://bugs.webkit.org/show_bug.cgi?id=189349
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/gtk/TestExpectations: Unflag Timeout from now-unaffected tests.
>+
> 2018-09-06  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Add support for min/max-height percentage values.
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 40287982e06d2dd005cbe6b0c3175f7d0e21a854..4b5201496cca9cb737139004ae2649cd63e77a09 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -1527,14 +1527,13 @@ webkit.org/b/132185 editing/pasteboard/gtk/middle-button-paste.html [ Failure Pa
> # Some media fragment tests are flaky
> webkit.org/b/132248 media/media-fragments/TC0001.html [ Timeout Pass ]
> webkit.org/b/132248 media/media-fragments/TC0002.html [ Crash Pass ]
>-webkit.org/b/132248 media/media-fragments/TC0004.html [ Timeout Crash Pass ]
>+webkit.org/b/132248 media/media-fragments/TC0004.html [ Crash Pass ]
> webkit.org/b/132248 media/media-fragments/TC0005.html [ Failure Crash Pass ]
> webkit.org/b/132248 media/media-fragments/TC0006.html [ Failure Pass ]
> webkit.org/b/132248 media/media-fragments/TC0009.html [ Failure Pass ]
> webkit.org/b/132248 media/media-fragments/TC0011.html [ Failure Pass ]
> webkit.org/b/132248 media/media-fragments/TC0014.html [ Failure Pass ]
> webkit.org/b/132248 media/media-fragments/TC0015.html [ Failure Crash Pass ]
>-webkit.org/b/132248 media/media-fragments/TC0017.html [ Timeout Pass ]
> webkit.org/b/134574 media/media-fragments/TC0024.html [ Failure Timeout Pass ]
> webkit.org/b/132248 media/media-fragments/TC0035.html [ Failure Pass ]
> webkit.org/b/132248 media/media-fragments/TC0036.html [ Failure Pass ]
>@@ -1984,7 +1983,7 @@ webkit.org/b/186673 editing/spelling/spellcheck-async-mutation.html [ Failure Pa
> 
> webkit.org/b/186678 fast/mediastream/change-tracks-media-stream-being-played.html [ Crash Pass ]
> 
>-webkit.org/b/186679 media/video-currentTime-delay.html [ Timeout Crash Pass ]
>+webkit.org/b/186679 media/video-currentTime-delay.html [ Crash Pass ]
> 
> webkit.org/b/186750 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https.html [ Pass Failure ]
> webkit.org/b/186750 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html [ Pass Failure ]
>@@ -2044,16 +2043,6 @@ webkit.org/b/189338 imported/w3c/web-platform-tests/visual-viewport/viewport-res
> 
> webkit.org/b/189339 compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html [ ImageOnlyFailure Pass ]
> 
>-webkit.org/b/189340 webaudio/silence-after-playback.html [ Failure Timeout Pass ]
>-
>-webkit.org/b/189341 http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html [ Timeout Pass ]
>-
>-webkit.org/b/189342 media/media-fullscreen-return-to-inline.html [ Timeout Pass ]
>-
>-webkit.org/b/189346 media/media-ended.html [ Timeout Pass ]
>-
>-webkit.org/b/189348 media/video-currentTime-set.html [ Timeout Pass ]
>-
> #////////////////////////////////////////////////////////////////////////////////////////
> # End of Flaky tests
> #////////////////////////////////////////////////////////////////////////////////////////

Flags:

cgarcia: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 189349: 349163