Attachment 349135 Details for Bug 189402 – Patch

[patch] Patch

bug-189402-20180907192943.patch (text/plain), 1.76 KB, created by Fujii Hironori on 2018-09-07 03:29:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-07 03:29:44 PDT

Size: 1.76 KB

patch

obsolete

>Subversion Revision: 235780
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 68c6ab7b8e58805e4223fe6c4e009ddb9532807e..0a48bbe8d87445dc1b188dd4107bcbf8ef78d886 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-09-07  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win][Clang] exceptionShouldTerminateProgram of StructuredExceptionHandlerSuppressor.cpp should take DWORD
>+        https://bugs.webkit.org/show_bug.cgi?id=189402
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Clang reports compilation errors like following:
>+
>+        > StructuredExceptionHandlerSuppressor.cpp(38,10):  error: case value evaluates to 2147483650, which cannot be narrowed to type 'int' [-Wc++11-narrowing]
>+        >     case EXCEPTION_DATATYPE_MISALIGNMENT:
>+        >          ^
>+
>+        No new tests (no behavioral change).
>+
>+        * platform/win/StructuredExceptionHandlerSuppressor.cpp:
>+        (exceptionShouldTerminateProgram): Changed the type of argument from int to DWORD.
>+
> 2018-09-06  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         ShadowRoot should have its own node flag
>diff --git a/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp b/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp
>index 66947fd59599615162a418a80f7ce2f8198916f6..b12871aef5ace540fbaffee3c8b2e65ac40f87a5 100644
>--- a/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp
>+++ b/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp
>@@ -31,7 +31,7 @@
> extern "C" int __stdcall exceptionHandlerThunk(); // Defined in makesafeseh.asm
> #endif
> 
>-static bool exceptionShouldTerminateProgram(int code)
>+static bool exceptionShouldTerminateProgram(DWORD code)
> {
>     switch (code) {
> #ifndef NDEBUG

Actions: View | Formatted Diff | Diff

Attachments on bug 189402: 349135