Attachment 349109 Details for Bug 189394 – Patch

[patch] Patch

bug-189394-20180906211350.patch (text/plain), 5.14 KB, created by Wenson Hsieh on 2018-09-06 21:13:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-09-06 21:13:51 PDT

Size: 5.14 KB

patch

obsolete

>Subversion Revision: 235775
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c34c8f522bbb6bb75391533b8e667cb0f8f55836..ba677e2e1f2b47f62f83bc77c93444b055d723f2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Clean up FontAttributeChanges.cpp after r235748
>+        https://bugs.webkit.org/show_bug.cgi?id=189394
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Sources.txt: Move FontAttributeChanges.cpp into unified sources.
>+        * WebCore.xcodeproj/project.pbxproj:
>+        * editing/FontAttributeChanges.cpp: Replace `#import`s with `#include`s.
>+
> 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Refactor WebCore::EditAction to be an 8-bit enum class
>diff --git a/Source/WebCore/Sources.txt b/Source/WebCore/Sources.txt
>index 12b536bba64a64e1a0dc3adbc66d85bb5d5e7236..7cf364fa90c8aee3361af81f2395016e22171acb 100644
>--- a/Source/WebCore/Sources.txt
>+++ b/Source/WebCore/Sources.txt
>@@ -873,6 +873,7 @@ editing/Editing.cpp
> editing/EditingStyle.cpp
> editing/Editor.cpp
> editing/EditorCommand.cpp
>+editing/FontAttributeChanges.cpp
> editing/FormatBlockCommand.cpp
> editing/FrameSelection.cpp
> editing/HTMLInterchange.cpp
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index 4a8ac36dffdb0f3b2e8b894f13fe42c26e47255c..3dfe3c5a55c1ad01b99992fc31b0f8f981eb1d49 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -4823,7 +4823,6 @@
> 		F3ABFE0C130E9DA000E7F7D1 /* InstrumentingAgents.h in Headers */ = {isa = PBXBuildFile; fileRef = F3ABFE0B130E9DA000E7F7D1 /* InstrumentingAgents.h */; };
> 		F3D461491161D53200CA0D09 /* JSErrorHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = F3D461471161D53200CA0D09 /* JSErrorHandler.h */; };
> 		F433E9031DBBDBA200EF0D14 /* StaticPasteboard.h in Headers */ = {isa = PBXBuildFile; fileRef = F433E9021DBBDBA200EF0D14 /* StaticPasteboard.h */; settings = {ATTRIBUTES = (Private, ); }; };
>-		F442850C2140412500CCDA22 /* FontAttributeChanges.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F442850B2140412500CCDA22 /* FontAttributeChanges.cpp */; };
> 		F44A5F591FED38F2007F5944 /* LegacyNSPasteboardTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = F44A5F571FED3830007F5944 /* LegacyNSPasteboardTypes.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		F44EBBD91DB5D21400277334 /* StaticRange.h in Headers */ = {isa = PBXBuildFile; fileRef = F44EBBD81DB5D21400277334 /* StaticRange.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		F45C231E1995B73B00A6E2E3 /* AxisScrollSnapOffsets.h in Headers */ = {isa = PBXBuildFile; fileRef = F45C231C1995B73B00A6E2E3 /* AxisScrollSnapOffsets.h */; settings = {ATTRIBUTES = (Private, ); }; };
>@@ -28781,7 +28780,6 @@
> 				D6489D26166FFCF1007C031B /* JSHTMLTemplateElement.h in Headers */,
> 				A80E7E9D0A1A83E3007FB8C5 /* JSHTMLTextAreaElement.h in Headers */,
> 				83E359A21BB1031D002CEB98 /* JSHTMLTimeElement.h in Headers */,
>-				E42050172141901B0066EF3B /* ProcessWarming.h in Headers */,
> 				A80E7B0C0A19D606007FB8C5 /* JSHTMLTitleElement.h in Headers */,
> 				070756D414239A4F00414161 /* JSHTMLTrackElement.h in Headers */,
> 				1A85B2110A1B258700D8C87C /* JSHTMLUListElement.h in Headers */,
>@@ -29789,6 +29787,7 @@
> 				B71FE6DF11091CB300DAEF77 /* PrintContext.h in Headers */,
> 				51F645D51FECDBCE00B54DED /* Process.h in Headers */,
> 				A8EA7EBC0A1945D000A8EF5F /* ProcessingInstruction.h in Headers */,
>+				E42050172141901B0066EF3B /* ProcessWarming.h in Headers */,
> 				E44613EC0CD681B500FADA75 /* ProgressEvent.h in Headers */,
> 				A715E653134BBBEC00D8E713 /* ProgressShadowElement.h in Headers */,
> 				1A2A68240B5BEDE70002A480 /* ProgressTracker.h in Headers */,
>@@ -31490,7 +31489,6 @@
> 				5C4304B0191AC908000E2BC0 /* EXTShaderTextureLOD.cpp in Sources */,
> 				727AFED41A2EA6AE000442E8 /* EXTsRGB.cpp in Sources */,
> 				7728694E14F8882500F484DC /* EXTTextureFilterAnisotropic.cpp in Sources */,
>-				F442850C2140412500CCDA22 /* FontAttributeChanges.cpp in Sources */,
> 				7CE6CBFD187F394900D46BF5 /* FormatConverter.cpp in Sources */,
> 				51A4BB0A1954D61600FA5C2E /* Gamepad.cpp in Sources */,
> 				518F4FF6194CA4E60081BAAE /* GamepadButton.cpp in Sources */,
>diff --git a/Source/WebCore/editing/FontAttributeChanges.cpp b/Source/WebCore/editing/FontAttributeChanges.cpp
>index 40b3d62ab60eef5f5a9b5c767df5c06b484fc353..6ea0dce22f40ada50743758baaf9451ffcef1235 100644
>--- a/Source/WebCore/editing/FontAttributeChanges.cpp
>+++ b/Source/WebCore/editing/FontAttributeChanges.cpp
>@@ -23,16 +23,16 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>-#import "config.h"
>-#import "FontAttributeChanges.h"
>-
>-#import "CSSPropertyNames.h"
>-#import "CSSShadowValue.h"
>-#import "CSSValueKeywords.h"
>-#import "CSSValueList.h"
>-#import "CSSValuePool.h"
>-#import "EditingStyle.h"
>-#import "StyleProperties.h"
>+#include "config.h"
>+#include "FontAttributeChanges.h"
>+
>+#include "CSSPropertyNames.h"
>+#include "CSSShadowValue.h"
>+#include "CSSValueKeywords.h"
>+#include "CSSValueList.h"
>+#include "CSSValuePool.h"
>+#include "EditingStyle.h"
>+#include "StyleProperties.h"
> 
> namespace WebCore {
>

Flags:

thorton: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189394: 349109 | 349208