WebKit Bugzilla
Attachment 349088 Details for
Bug 189381
: Cleanup: Remove extraneous "using namespace" and scope WebCore::LogThreading
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-189381-20180906160517.patch (text/plain), 2.08 KB, created by
Daniel Bates
on 2018-09-06 16:05:18 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2018-09-06 16:05:18 PDT
Size:
2.08 KB
patch
obsolete
>Subversion Revision: 235763 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 7dbbe9c501e47bbeb796ccd06b9f50122770c0ed..9c135288fbc38ca7017713db7a1e27fa3b7dadb7 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,14 @@ >+2018-09-06 Daniel Bates <dabates@apple.com> >+ >+ Cleanup: Remove extraneous "using namespace" and scope WebCore::LogThreading >+ https://bugs.webkit.org/show_bug.cgi?id=189381 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * platform/ios/wak/WKGraphics.mm: >+ * platform/ios/wak/WebCoreThread.mm: >+ (WebThreadEnable): >+ > 2018-09-06 Zalan Bujtas <zalan@apple.com> > > [LFC][BFC] Add support for min(max)-height >diff --git a/Source/WebCore/platform/ios/wak/WKGraphics.mm b/Source/WebCore/platform/ios/wak/WKGraphics.mm >index dfc6e0ee35f7f8f49fcd609302b74d31c960beda..8e3b0d5b81c2b38172637d8a41d6031a0df56a73 100644 >--- a/Source/WebCore/platform/ios/wak/WKGraphics.mm >+++ b/Source/WebCore/platform/ios/wak/WKGraphics.mm >@@ -31,8 +31,6 @@ > #import "WebCoreThreadInternal.h" > #import <pal/spi/cg/CoreGraphicsSPI.h> > >-using namespace WebCore; >- > static inline void _FillRectsUsingOperation(CGContextRef context, const CGRect* rects, int count, CGCompositeOperation op) > { > int i; >diff --git a/Source/WebCore/platform/ios/wak/WebCoreThread.mm b/Source/WebCore/platform/ios/wak/WebCoreThread.mm >index 1faf8d5d503e1e18e2459e4424dea96b5530bdb8..dafa3dc4a487e2bec924d16e0eb4563a9113a860 100644 >--- a/Source/WebCore/platform/ios/wak/WebCoreThread.mm >+++ b/Source/WebCore/platform/ios/wak/WebCoreThread.mm >@@ -866,8 +866,10 @@ WebThreadContext* WebThreadCurrentContext(void) > void WebThreadEnable(void) > { > RELEASE_ASSERT_WITH_MESSAGE(!WebCore::IOSApplication::isWebProcess(), "The WebProcess should never run a Web Thread"); >- if (WebCore::IOSApplication::isSpringBoard()) >+ if (WebCore::IOSApplication::isSpringBoard()) { >+ using WebCore::LogThreading; > RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread."); >+ } > > static std::once_flag flag; > std::call_once(flag, StartWebThread);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189381
: 349088