WebKit Bugzilla
Attachment 349076 Details for
Bug 189368
: An EWS run that has leak test failures does not correctly add bugzilla comments showing the failures
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-189368-20180906143300.patch (text/plain), 3.50 KB, created by
Simon Fraser (smfr)
on 2018-09-06 14:33:01 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Simon Fraser (smfr)
Created:
2018-09-06 14:33:01 PDT
Size:
3.50 KB
patch
obsolete
>Subversion Revision: 235741 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 1a1e216449451bb436d1d73300f2df9e1161676a..57f0d95a2663376f5aeb58b9010bdd2ac0f9ffa4 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,18 @@ >+2018-09-06 Simon Fraser <simon.fraser@apple.com> >+ >+ An EWS run that has leak test failures does not correctly add bugzilla comments showing the failures >+ https://bugs.webkit.org/show_bug.cgi?id=189368 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Include FailureDocumentLeak in ALL_FAILURE_CLASSES (with a fairly redundant test), >+ which should fix EWS showing leaks in Bugzilla. >+ >+ * Scripts/webkitpy/layout_tests/models/test_failures.py: >+ (FailureDocumentLeak.__init__): >+ * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: >+ (TestFailuresTest.test_all_failure_classes): >+ > 2018-09-06 Myles C. Maxfield <mmaxfield@apple.com> > > [WHLSL] The parser is too slow >diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py b/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py >index b7476cacd17070c982b85f1340e08ac1d6c6500c..d95da02e5896a4675867262be4b701cff03cd0ce 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py >+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py >@@ -171,7 +171,7 @@ class FailureLeak(TestFailure): > > > class FailureDocumentLeak(FailureLeak): >- def __init__(self, leaked_document_urls): >+ def __init__(self, leaked_document_urls=None): > super(FailureDocumentLeak, self).__init__() > self.leaked_document_urls = leaked_document_urls > >@@ -295,5 +295,5 @@ ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult, Failu > FailureMissingImage, FailureImageHashMismatch, > FailureImageHashIncorrect, FailureReftestMismatch, > FailureReftestMismatchDidNotOccur, FailureReftestNoImagesGenerated, >- FailureMissingAudio, FailureAudioMismatch, >+ FailureMissingAudio, FailureAudioMismatch, FailureDocumentLeak, > FailureEarlyExit) >diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py b/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py >index f5640d16a0a903c0a60c3411b16d6bf887a0016d..30f1dc71ae990c3e3cd8afe944c6523b9c24d151 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py >+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_failures_unittest.py >@@ -59,6 +59,26 @@ class TestFailuresTest(unittest.TestCase): > for c in ALL_FAILURE_CLASSES: > self.assert_loads(c) > >+ def test_all_failure_classes(self): >+ failure_classes = ( >+ FailureTimeout, >+ FailureCrash, >+ FailureMissingResult, >+ FailureNotTested, >+ FailureTextMismatch, >+ FailureMissingImageHash, >+ FailureMissingImage, >+ FailureImageHashMismatch, >+ FailureImageHashIncorrect, >+ FailureReftestMismatch, >+ FailureReftestMismatchDidNotOccur, >+ FailureReftestNoImagesGenerated, >+ FailureMissingAudio, >+ FailureAudioMismatch, >+ FailureDocumentLeak, >+ FailureEarlyExit) >+ self.assertEqual(failure_classes, ALL_FAILURE_CLASSES) >+ > def test_equals(self): > self.assertEqual(FailureCrash(), FailureCrash()) > self.assertNotEqual(FailureCrash(), FailureTimeout())
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189368
: 349076