Attachment 349034 Details for Bug 189354 – Patch

[patch] Patch

bug-189354-20180906094801.patch (text/plain), 1.38 KB, created by Thomas Denney on 2018-09-06 09:48:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Denney

Created: 2018-09-06 09:48:02 PDT

Size: 1.38 KB

patch

obsolete

>Subversion Revision: 235739
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 1a1e216449451bb436d1d73300f2df9e1161676a..42fc2f38c43c96f3bf3dec5a065e752d0f7aaa8d 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-06  Thomas Denney  <tdenney@apple.com>
>+
>+        [WHLSL] The test suite should log the compile time for the standard library
>+        https://bugs.webkit.org/show_bug.cgi?id=189354
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The test suite previously only logged the time for test execution, and
>+        not the compile time for the standard library.
>+
>+        * WebGPUShadingLanguageRI/Test.js:
>+
> 2018-09-06  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WHLSL] The parser is too slow
>diff --git a/Tools/WebGPUShadingLanguageRI/Test.js b/Tools/WebGPUShadingLanguageRI/Test.js
>index 556cb2fb8bb5108790c5b4da8fa67e4c54cac666..5bed3aadeef608bae5aa37bcf1130732f71ed1a3 100644
>--- a/Tools/WebGPUShadingLanguageRI/Test.js
>+++ b/Tools/WebGPUShadingLanguageRI/Test.js
>@@ -7649,9 +7649,11 @@ function* doTest(testFilter)
>     let before = preciseTime();
> 
>     print("Compiling standard library...");
>+    const compileBefore = preciseTime();
>     yield;
>     prepare();
>-    print("    OK!");
>+    const compileAfter = preciseTime();
>+    print(`    OK, took ${Math.round((compileAfter - compileBefore) * 1000)} ms`);
> 
>     let names = [];
>     for (let s in tests)

Actions: View | Formatted Diff | Diff

Attachments on bug 189354: 349034