Attachment 349023 Details for Bug 189347 – Patch

[patch] Patch

bug-189347-20180906163840.patch (text/plain), 2.12 KB, created by Dominik Inführ on 2018-09-06 07:38:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dominik Inführ

Created: 2018-09-06 07:38:42 PDT

Size: 2.12 KB

patch

obsolete

>Subversion Revision: 235732
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 90ac723ae6c679936618d3879b3dbb72ce3e9d1f..cbfa775f14d154c8d87210b1ffce02932441a98a 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-09-06  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        Disable test when WebAssembly not enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=189347
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add function that tests if WebAssembly is enabled.
>+
>+        * Scripts/run-jsc-stress-tests:
>+
> 2018-09-05  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Allow port specific options on gtest
>diff --git a/Tools/Scripts/run-jsc-stress-tests b/Tools/Scripts/run-jsc-stress-tests
>index b791df8fa7af804d284f619e02764154094b3d60..f50c93941ff3e083b34ec7084f2cec73f4e61e69 100755
>--- a/Tools/Scripts/run-jsc-stress-tests
>+++ b/Tools/Scripts/run-jsc-stress-tests
>@@ -437,6 +437,10 @@ def isFTLEnabled
>     $jitTests && $isFTLPlatform
> end
> 
>+def isWebAssemblyEnabled
>+    $jitTests && $isFTLPlatform
>+end
>+
> if !$testRunnerType
>     if $remote and $hostOS == "darwin"
>         $testRunnerType = :shell
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index d26760d673704c5f2a77d0c811f655bcc55aa623..84c4615de5f9e9fb6969d09644894bfb6cb6fea4 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-09-06  Dominik Infuehr  <dinfuehr@igalia.com>
>+
>+        Disable test when WebAssembly not enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=189347
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * stress/regress-189185.js:
>+
> 2018-09-05  Mark Lam  <mark.lam@apple.com>
> 
>         JSPropertyNameEnumerator::visitChildren() needs to visit its m_cachedStructureID.
>diff --git a/JSTests/stress/regress-189185.js b/JSTests/stress/regress-189185.js
>index 14b901e7ca281c9e95ee77d41c87beec89961f9a..4f731821f2aafe5ca102583ba4187266b2ad4881 100644
>--- a/JSTests/stress/regress-189185.js
>+++ b/JSTests/stress/regress-189185.js
>@@ -1,4 +1,4 @@
>-//@ skip if $architecture == "x86"
>+//@ skip if !isWebAssemblyEnabled
> //@ runDefault
> // This passes if it does not crash.
> new WebAssembly.CompileError({

Flags:

mark.lam: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 189347: 349022 | 349023 | 349048