WebKit Bugzilla
Attachment 348997 Details for
Bug 189332
: Enable world leaks by default for Mac WK2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch (with other possibly necessary changes)
bug-189332-20180905201017.patch (text/plain), 64.94 KB, created by
Simon Fraser (smfr)
on 2018-09-05 20:10:18 PDT
(
hide
)
Description:
Patch (with other possibly necessary changes)
Filename:
MIME Type:
Creator:
Simon Fraser (smfr)
Created:
2018-09-05 20:10:18 PDT
Size:
64.94 KB
patch
obsolete
>Subversion Revision: 235680 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 61682d0a7722973fe387794e5303a0aedaffa024..230245d6df35da827a75c2c4c997c69f5dbeb845 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,88 @@ >+2018-09-05 Simon Fraser <simon.fraser@apple.com> >+ >+ Enable world leaks by default for Mac WK2 >+ https://bugs.webkit.org/show_bug.cgi?id=189332 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Allow the port to supply a default value for options.world_leaks, which means not having >+ it default to False in the options parser, and having _set_up_derived_options() >+ get it from the port. Also disable it for DumpRenderTree. >+ >+ Print the status of world_leaks if running with verbose printing. >+ >+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py: >+ (parse_args): >+ (_set_up_derived_options): >+ * Scripts/webkitpy/layout_tests/views/printing.py: >+ (Printer.print_config): >+ * Scripts/webkitpy/port/base.py: >+ (Port.default_world_leaks): >+ * Scripts/webkitpy/port/mac.py: >+ (MacPort.default_world_leaks): >+ >+2018-09-05 Simon Fraser <simon.fraser@apple.com> >+ >+ run-webkit-tests prints confusing messages when test expectations list results that are not compatible with the run options >+ https://bugs.webkit.org/show_bug.cgi?id=189219 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ If you call run-webkit-tests without --pixel-tests, and a non-ref test is marked as ImageOnlyFailure, >+ it will be reported as unexpectedly passing. This is more confusing if you run without --world-leaks, yet >+ tests are marked as [ Leak ] in TestExpectations. >+ >+ Fix by filtering out expectations that don't apply given the run options. So without --pixel-tests, >+ a non-ref ImageOnlyFailure becomes a Pass, and without --world-leaks, a Leak becomes a Pass. >+ >+ Add various unit tests to test the various combinations. >+ >+ * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: >+ (LayoutTestRunner._update_summary_with_result): >+ (LayoutTestRunner._annotate_results_with_additional_failures): >+ * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: >+ (LayoutTestRunnerTests.test_update_summary_with_result): >+ * Scripts/webkitpy/layout_tests/models/test_expectations.py: >+ (TestExpectationsModel.get_expectations_or_pass): >+ (TestExpectationsModel): >+ (TestExpectationsModel.expectations_to_string): >+ (TestExpectationsModel.get_expectations_string): >+ (TestExpectations.filtered_expectations_for_test): >+ (TestExpectations): >+ (TestExpectations.matches_an_expected_result): >+ * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: >+ * Scripts/webkitpy/layout_tests/models/test_run_results.py: >+ (summarize_results): >+ * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: >+ (summarized_results): >+ (SummarizedResultsTest.setUp): >+ (SummarizedResultsTest.test_summarized_results_include_passes): >+ (SummarizedResultsTest): >+ (SummarizedResultsTest.test_summarized_results_world_leaks_disabled): >+ * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: >+ * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: >+ (BuildBotPrinterTests.test_print_unexpected_results): >+ (BuildBotPrinterTests.test_print_unexpected_results_with_options): >+ (BuildBotPrinterTests.test_print_results): >+ * Scripts/webkitpy/port/test.py: >+ (unit_test_list): >+ >+2018-09-05 Simon Fraser <simon.fraser@apple.com> >+ >+ Log when leak detection changes the test result >+ https://bugs.webkit.org/show_bug.cgi?id=189293 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ When you have an "Leak" expectation in TestExpectations, it's confusing to see a test unexpectedly pass, >+ but then show up as an expected fail at the end (because leak detection happens at the end of a shard). >+ So log when leak detection changes a test result. >+ >+ * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: >+ (LayoutTestRunner._annotate_results_with_additional_failures): >+ * Scripts/webkitpy/layout_tests/models/test_expectations.py: >+ (TestExpectations): >+ > 2018-09-05 Ross Kirsling <ross.kirsling@sony.com> > > Add WinCairo to bot watcher's dashboard. >diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py b/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py >index 4b19974d9874dd826d3ab5d6db2b80eed99d1412..b94c3145df3ca08e76a2b0c534bf862e56360140 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py >+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py >@@ -182,8 +182,9 @@ class LayoutTestRunner(object): > exp_str = got_str = 'SKIP' > expected = True > else: >- expected = self._expectations.matches_an_expected_result(result.test_name, result.type, self._options.pixel_tests or result.reftest_type, self._options.world_leaks) >- exp_str = self._expectations.model().get_expectations_string(result.test_name) >+ expectations = self._expectations.filtered_expectations_for_test(result.test_name, self._options.pixel_tests or bool(result.reftest_type), self._options.world_leaks) >+ expected = self._expectations.matches_an_expected_result(result.test_name, result.type, expectations) >+ exp_str = self._expectations.model().expectations_to_string(expectations) > got_str = self._expectations.model().expectation_to_string(result.type) > > run_results.add(result, expected, self._test_is_slow(result.test_name)) >@@ -198,8 +199,13 @@ class LayoutTestRunner(object): > # When running a chunk (--run-chunk), results_by_name contains all the tests, but (confusingly) all_tests only contains those in the chunk that was run, > # and we don't want to modify the results of a test that didn't run. existing_result.test_number is only non-None for tests that ran. > if existing_result and existing_result.test_number is not None: >- was_expected = self._expectations.matches_an_expected_result(new_result.test_name, existing_result.type, self._options.pixel_tests or existing_result.reftest_type, self._options.world_leaks) >- now_expected = self._expectations.matches_an_expected_result(new_result.test_name, new_result.type, self._options.pixel_tests or new_result.reftest_type, self._options.world_leaks) >+ expectations = self._expectations.filtered_expectations_for_test(new_result.test_name, self._options.pixel_tests or bool(new_result.reftest_type), self._options.world_leaks) >+ was_expected = self._expectations.matches_an_expected_result(new_result.test_name, existing_result.type, expectations) >+ now_expected = self._expectations.matches_an_expected_result(new_result.test_name, new_result.type, expectations) >+ if was_expected != now_expected: >+ _log.warning(' %s -> test was a %s (%s) but is now a %s (%s)' % (new_result.test_name, >+ TestExpectations.EXPECTATION_DESCRIPTION[existing_result.type], 'expected' if was_expected else 'unexpected', >+ TestExpectations.EXPECTATION_DESCRIPTION[new_result.type], 'expected' if now_expected else 'unexpected')) > run_results.change_result_to_failure(existing_result, new_result, was_expected, now_expected) > > def start_servers(self): >diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py b/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py >index fff96dfe4de88561123e9691804948ecb0d835c9..b80ca45485a3294d02e2455e5ef3dfc1743d189f 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py >+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py >@@ -122,8 +122,10 @@ class LayoutTestRunnerTests(unittest.TestCase): > # Reftests expected to be image mismatch should be respected when pixel_tests=False. > runner = self._runner() > runner._options.pixel_tests = False >+ runner._options.world_leaks = False > test = 'failures/expected/reftest.html' >- expectations = TestExpectations(runner._port, tests=[test]) >+ leak_test = 'failures/expected/leak.html' >+ expectations = TestExpectations(runner._port, tests=[test, leak_test]) > expectations.parse_all_expectations() > runner._expectations = expectations > >@@ -139,6 +141,12 @@ class LayoutTestRunnerTests(unittest.TestCase): > self.assertEqual(0, run_results.expected) > self.assertEqual(1, run_results.unexpected) > >+ run_results = TestRunResults(expectations, 1) >+ result = TestResult(test_name=leak_test, failures=[]) >+ runner._update_summary_with_result(run_results, result) >+ self.assertEqual(1, run_results.expected) >+ self.assertEqual(0, run_results.unexpected) >+ > def test_servers_started(self): > > def start_http_server(): >diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py >index b3acc6725a74e4a3f8b938a8d0df48f87d699b20..46b14cb014d243a5589e803f6fd4d7a608912b3c 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py >+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py >@@ -598,8 +598,22 @@ class TestExpectationsModel(object): > def get_expectations(self, test): > return self._test_to_expectations[test] > >+ def get_expectations_or_pass(self, test): >+ try: >+ return self.get_expectations(test) >+ except: >+ return set([PASS]) >+ >+ def expectations_to_string(self, expectations): >+ retval = [] >+ >+ for expectation in expectations: >+ retval.append(self.expectation_to_string(expectation)) >+ >+ return " ".join(retval) >+ > def get_expectations_string(self, test): >- """Returns the expectatons for the given test as an uppercase string. >+ """Returns the expectations for the given test as an uppercase string. > If there are no expectations for the test, then "PASS" is returned.""" > try: > expectations = self.get_expectations(test) >@@ -801,6 +815,19 @@ class TestExpectations(object): > 'leak': LEAK, > 'skip': SKIP} > >+ # Singulars >+ EXPECTATION_DESCRIPTION = {SKIP: 'skipped', >+ PASS: 'pass', >+ FAIL: 'failure', >+ IMAGE: 'image-only failure', >+ TEXT: 'text-only failure', >+ IMAGE_PLUS_TEXT: 'image and text failure', >+ AUDIO: 'audio failure', >+ CRASH: 'crash', >+ TIMEOUT: 'timeout', >+ MISSING: 'missing', >+ LEAK: 'leak'} >+ > # (aggregated by category, pass/fail/skip, type) > EXPECTATION_DESCRIPTIONS = {SKIP: 'skipped', > PASS: 'passes', >@@ -965,14 +992,16 @@ class TestExpectations(object): > def get_rebaselining_failures(self): > return self._model.get_test_set(REBASELINE) > >- def matches_an_expected_result(self, test, result, pixel_tests_are_enabled, world_leaks_are_enabled): >- expected_results = self._model.get_expectations(test) >+ def filtered_expectations_for_test(self, test, pixel_tests_are_enabled, world_leaks_are_enabled): >+ expected_results = self._model.get_expectations_or_pass(test) > if not pixel_tests_are_enabled: > expected_results = self.remove_pixel_failures(expected_results) >- > if not world_leaks_are_enabled: > expected_results = self.remove_leak_failures(expected_results) > >+ return expected_results >+ >+ def matches_an_expected_result(self, test, result, expected_results): > return self.result_was_expected(result, > expected_results, > self.is_rebaselining(test), >diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py >index 4d3f0b6676ba30336d2f33dd2c310d8987e4dcee..30adabcc2319747f10681340d4b9edf0b1e7a23b 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py >+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py >@@ -234,7 +234,8 @@ class MiscTests(Base): > > def test_pixel_tests_flag(self): > def match(test, result, pixel_tests_enabled): >- return self._exp.matches_an_expected_result(test, result, pixel_tests_enabled, False) >+ expectations = self._exp.filtered_expectations_for_test(test, pixel_tests_enabled, False) >+ return self._exp.matches_an_expected_result(test, result, expectations) > > self.parse_exp(self.get_basic_expectations()) > pixel_tests_enabled = True >@@ -250,7 +251,8 @@ class MiscTests(Base): > > def test_world_leaks_flag(self): > def match(test, result, pixel_tests_enabled, world_leaks_enabled): >- return self._exp.matches_an_expected_result(test, result, pixel_tests_enabled, world_leaks_enabled) >+ expectations = self._exp.filtered_expectations_for_test(test, pixel_tests_enabled, world_leaks_enabled) >+ return self._exp.matches_an_expected_result(test, result, expectations) > > pixel_tests_enabled = True > pixel_tests_disabled = False >diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py b/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py >index 4370fddc6709c9cf14be97ba18792e6681b1d00e..56830038bc1b22dbf3de035890aa3b0e9d5854c5 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py >+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py >@@ -233,7 +233,10 @@ def summarize_results(port_obj, expectations, initial_results, retry_results, en > # Note that if a test crashed in the original run, we ignore > # whether or not it crashed when we retried it (if we retried it), > # and always consider the result not flaky. >- expected = expectations.model().get_expectations_string(test_name) >+ pixel_tests_enabled = enabled_pixel_tests_in_retry or port_obj._options.pixel_tests or bool(result.reftest_type) >+ test_expectation = expectations.filtered_expectations_for_test(test_name, pixel_tests_enabled, port_obj._options.world_leaks) >+ expected = expectations.model().expectations_to_string(test_expectation) >+ > result_type = result.type > actual = [keywords[result_type]] > >@@ -267,10 +270,6 @@ def summarize_results(port_obj, expectations, initial_results, retry_results, en > if test_name in initial_results.unexpected_results_by_name: > num_missing += 1 > test_dict['report'] = 'MISSING' >- elif result_type == test_expectations.LEAK: >- if test_name in initial_results.unexpected_results_by_name: >- num_regressions += 1 >- test_dict['report'] = 'REGRESSION' > elif test_name in initial_results.unexpected_results_by_name: > if retry_results and test_name not in retry_results.unexpected_results_by_name: > actual.extend(expectations.model().get_expectations_string(test_name).split(" ")) >diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py b/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py >index cbda1998065a3c7b7c976890c033da41e856c2b9..2838e29de5ad328cd4749b5b0263057f116cce95 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py >+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py >@@ -33,6 +33,7 @@ from webkitpy.layout_tests.models import test_expectations > from webkitpy.layout_tests.models import test_failures > from webkitpy.layout_tests.models import test_results > from webkitpy.layout_tests.models import test_run_results >+from webkitpy.tool.mocktool import MockOptions > > > def get_result(test_name, result_type=test_expectations.PASS, run_time=0): >@@ -65,18 +66,38 @@ def summarized_results(port, expected, passing, flaky, include_passes=False): > initial_results.add(get_result('failures/expected/audio.html', test_expectations.AUDIO), expected, test_is_slow) > initial_results.add(get_result('failures/expected/timeout.html', test_expectations.TIMEOUT), expected, test_is_slow) > initial_results.add(get_result('failures/expected/crash.html', test_expectations.CRASH), expected, test_is_slow) >- initial_results.add(get_result('failures/expected/leak.html', test_expectations.LEAK), expected, test_is_slow) >+ >+ if port._options.pixel_tests: >+ initial_results.add(get_result('failures/expected/pixel-fail.html', test_expectations.IMAGE), expected, test_is_slow) >+ else: >+ initial_results.add(get_result('failures/expected/pixel-fail.html', test_expectations.PASS), expected, test_is_slow) >+ >+ if port._options.world_leaks: >+ initial_results.add(get_result('failures/expected/leak.html', test_expectations.LEAK), expected, test_is_slow) >+ else: >+ initial_results.add(get_result('failures/expected/leak.html', test_expectations.PASS), expected, test_is_slow) >+ > elif passing: > initial_results.add(get_result('passes/text.html'), expected, test_is_slow) > initial_results.add(get_result('failures/expected/audio.html'), expected, test_is_slow) > initial_results.add(get_result('failures/expected/timeout.html'), expected, test_is_slow) > initial_results.add(get_result('failures/expected/crash.html'), expected, test_is_slow) >- initial_results.add(get_result('failures/expected/leak.html'), expected, test_is_slow) >+ >+ if port._options.pixel_tests: >+ initial_results.add(get_result('failures/expected/pixel-fail.html'), expected, test_is_slow) >+ else: >+ initial_results.add(get_result('failures/expected/pixel-fail.html', test_expectations.IMAGE), expected, test_is_slow) >+ >+ if port._options.world_leaks: >+ initial_results.add(get_result('failures/expected/leak.html'), expected, test_is_slow) >+ else: >+ initial_results.add(get_result('failures/expected/leak.html', test_expectations.PASS), expected, test_is_slow) > else: > initial_results.add(get_result('passes/text.html', test_expectations.TIMEOUT), expected, test_is_slow) > initial_results.add(get_result('failures/expected/audio.html', test_expectations.AUDIO), expected, test_is_slow) > initial_results.add(get_result('failures/expected/timeout.html', test_expectations.CRASH), expected, test_is_slow) > initial_results.add(get_result('failures/expected/crash.html', test_expectations.TIMEOUT), expected, test_is_slow) >+ initial_results.add(get_result('failures/expected/pixel-fail.html', test_expectations.TIMEOUT), expected, test_is_slow) > initial_results.add(get_result('failures/expected/leak.html', test_expectations.CRASH), expected, test_is_slow) > > # we only list hang.html here, since normally this is WontFix >@@ -87,6 +108,7 @@ def summarized_results(port, expected, passing, flaky, include_passes=False): > retry_results.add(get_result('passes/text.html'), True, test_is_slow) > retry_results.add(get_result('failures/expected/timeout.html'), True, test_is_slow) > retry_results.add(get_result('failures/expected/crash.html'), True, test_is_slow) >+ retry_results.add(get_result('failures/expected/pixel-fail.html'), True, test_is_slow) > retry_results.add(get_result('failures/expected/leak.html'), True, test_is_slow) > else: > retry_results = None >@@ -126,7 +148,7 @@ class InterpretTestFailuresTest(unittest.TestCase): > class SummarizedResultsTest(unittest.TestCase): > def setUp(self): > host = MockHost(initialize_scm_by_default=False) >- self.port = host.port_factory.get(port_name='test') >+ self.port = host.port_factory.get(port_name='test', options=MockOptions(http=True, pixel_tests=False, world_leaks=False)) > > def test_no_svn_revision(self): > summary = summarized_results(self.port, expected=False, passing=False, flaky=False) >@@ -146,3 +168,8 @@ class SummarizedResultsTest(unittest.TestCase): > self.port._options.builder_name = 'dummy builder' > summary = summarized_results(self.port, expected=False, passing=True, flaky=False, include_passes=True) > self.assertEqual(summary['tests']['passes']['text.html']['expected'], 'PASS') >+ >+ def test_summarized_results_world_leaks_disabled(self): >+ self.port._options.builder_name = 'dummy builder' >+ summary = summarized_results(self.port, expected=False, passing=True, flaky=False, include_passes=True) >+ self.assertEqual(summary['tests']['failures']['expected']['leak.html']['expected'], 'PASS') >diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py >index 4e8e315719067952f3fc3eacc00a65f1fade5b3f..05eec5780ef96df93b8adc8d1fe277cf8ff7721f 100755 >--- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py >+++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py >@@ -290,7 +290,7 @@ def parse_args(args): > optparse.make_option('--display-server', choices=['xvfb', 'xorg', 'weston', 'wayland'], default='xvfb', > help='"xvfb": Use a virtualized X11 server. "xorg": Use the current X11 session. ' > '"weston": Use a virtualized Weston server. "wayland": Use the current wayland session.'), >- optparse.make_option("--world-leaks", action="store_true", default=False, help="Check for world leaks (currently, only documents). Differs from --leaks in that this uses internal instrumentation, rather than external tools."), >+ optparse.make_option("--world-leaks", action="store_true", help="Check for world leaks (currently, only documents). Differs from --leaks in that this uses internal instrumentation, rather than external tools."), > ])) > > option_group_definitions.append(("iOS Options", [ >@@ -380,6 +380,9 @@ def _set_up_derived_options(port, options): > if options.pixel_tests is None: > options.pixel_tests = port.default_pixel_tests() > >+ if options.world_leaks is None: >+ options.world_leaks = port.default_world_leaks() >+ > if not options.time_out_ms: > options.time_out_ms = str(port.default_timeout_ms()) > >@@ -430,6 +433,10 @@ def _set_up_derived_options(port, options): > if options.platform in ["gtk", "wpe"]: > options.webkit_test_runner = True > >+ # World leaks is only supported in WebKitTestRunner at present. >+ if options.world_leaks and not options.webkit_test_runner: >+ options.world_leaks = False >+ > if options.leaks: > options.additional_env_var.append("JSC_usePoisoning=0") > options.additional_env_var.append("__XPC_JSC_usePoisoning=0") >diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py >index f04cb58cd680ae13e806fe3ed2b68e4506d4eed5..bb57a56caf136add8b76bf4e87ee595ccda06ea2 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py >+++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py >@@ -54,7 +54,6 @@ from webkitpy.layout_tests.models.test_run_results import INTERRUPTED_EXIT_STATU > from webkitpy.port import Port > from webkitpy.port import test > from webkitpy.test.skip import skip_if >-from webkitpy.tool.mocktool import MockOptions > > > def parse_args(extra_args=None, tests_included=False, new_results=False, print_nothing=True): >diff --git a/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py b/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py >index 8e536a3275de39bc47b18ca65d9044ddbcaa8def..558b0bd007bc530fd587e50a014aba6884079efb 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py >+++ b/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py >@@ -30,6 +30,7 @@ import StringIO > import unittest > > from webkitpy.common.host_mock import MockHost >+from webkitpy.tool.mocktool import MockOptions > > from webkitpy.layout_tests.models import test_expectations > from webkitpy.layout_tests.models import test_failures >@@ -52,7 +53,7 @@ class BuildBotPrinterTests(unittest.TestCase): > return printer, stream > > def test_print_unexpected_results(self): >- port = MockHost().port_factory.get('test') >+ port = MockHost().port_factory.get('test', options=MockOptions(pixel_tests=False, world_leaks=False)) > printer, out = self.get_printer() > > # test everything running as expected >@@ -88,8 +89,34 @@ class BuildBotPrinterTests(unittest.TestCase): > printer.print_unexpected_results(summary) > self.assertNotEmpty(out) > >+ def test_print_unexpected_results_with_options(self): >+ port = MockHost().port_factory.get('test', options=MockOptions(pixel_tests=False, world_leaks=False)) >+ >+ DASHED_LINE = "-" * 78 + "\n" >+ >+ port._options.pixel_tests = True >+ port._options.world_leaks = False >+ printer, out = self.get_printer() >+ summary = test_run_results_unittest.summarized_results(port, expected=True, passing=False, flaky=False) >+ printer.print_unexpected_results(summary) >+ self.assertEqual(out.getvalue(), DASHED_LINE) >+ >+ port._options.pixel_tests = False >+ port._options.world_leaks = True >+ printer, out = self.get_printer() >+ summary = test_run_results_unittest.summarized_results(port, expected=True, passing=False, flaky=False) >+ printer.print_unexpected_results(summary) >+ self.assertEqual(out.getvalue(), DASHED_LINE) >+ >+ port._options.pixel_tests = True >+ port._options.world_leaks = True >+ printer, out = self.get_printer() >+ summary = test_run_results_unittest.summarized_results(port, expected=True, passing=False, flaky=False) >+ printer.print_unexpected_results(summary) >+ self.assertEqual(out.getvalue(), DASHED_LINE) >+ > def test_print_results(self): >- port = MockHost().port_factory.get('test') >+ port = MockHost().port_factory.get('test', options=MockOptions(pixel_tests=False, world_leaks=False)) > printer, out = self.get_printer() > initial_results = test_run_results_unittest.run_results(port) > summary = test_run_results_unittest.summarized_results(port, expected=False, passing=True, flaky=False) >diff --git a/Tools/Scripts/webkitpy/layout_tests/views/printing.py b/Tools/Scripts/webkitpy/layout_tests/views/printing.py >index 0dec9c81ac4d4785d10a767303f7319873a39a2e..367c871a89aabfee3436e6e586364486a748c8f5 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/views/printing.py >+++ b/Tools/Scripts/webkitpy/layout_tests/views/printing.py >@@ -91,6 +91,11 @@ class Printer(object): > else: > self._print_default("Pixel tests disabled") > >+ if self._options.world_leaks: >+ self._print_default("World leaks enabled") >+ else: >+ self._print_default("World leaks disabled") >+ > self._print_default("Regular timeout: %s, slow test timeout: %s" % > (self._options.time_out_ms, self._options.slow_time_out_ms)) > >diff --git a/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py b/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py >index 1888692766020d1e77760c668f7d6dc2ccdb4f8a..e71da9fdeb87d0aee82549341dd6aa66b68a34a2 100644 >--- a/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py >+++ b/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py >@@ -104,6 +104,7 @@ class Testprinter(unittest.TestCase): > printer, err = self.get_printer() > # FIXME: it's lame that i have to set these options directly. > printer._options.pixel_tests = True >+ printer._options.world_leaks = False > printer._options.new_baseline = True > printer._options.time_out_ms = 6000 > printer._options.slow_time_out_ms = 12000 >diff --git a/Tools/Scripts/webkitpy/port/base.py b/Tools/Scripts/webkitpy/port/base.py >index 14761da92f902abc6e17b5613b0b7010feaa040a..cd94d69850cc80d27f2e8abffa53df2f1c40c108 100644 >--- a/Tools/Scripts/webkitpy/port/base.py >+++ b/Tools/Scripts/webkitpy/port/base.py >@@ -164,6 +164,9 @@ class Port(object): > # FIXME: Disable until they are run by default on build.webkit.org. > return False > >+ def default_world_leaks(self): >+ return False >+ > def default_timeout_ms(self): > return 30 * 1000 > >diff --git a/Tools/Scripts/webkitpy/port/mac.py b/Tools/Scripts/webkitpy/port/mac.py >index 40a5eac55a18973aa615ef43184da7b71090a52f..7d2137cf120c142f60fbaa992171f0f11c5caf95 100644 >--- a/Tools/Scripts/webkitpy/port/mac.py >+++ b/Tools/Scripts/webkitpy/port/mac.py >@@ -217,6 +217,12 @@ class MacPort(DarwinPort): > supportable_instances = default_count > return min(supportable_instances, default_count) > >+ def default_world_leaks(self): >+ if self.get_option('webkit_test_runner'): >+ return True >+ >+ return False >+ > def _build_java_test_support(self): > # FIXME: This is unused. Remove. > java_tests_path = self._filesystem.join(self.layout_tests_dir(), "java") >diff --git a/Tools/Scripts/webkitpy/port/test.py b/Tools/Scripts/webkitpy/port/test.py >index 96d72ddf47ccb479f8dd5bde7610621abd954fbc..31f38a9e9dfe18ed34aadac13ae5fee1de2eb723 100644 >--- a/Tools/Scripts/webkitpy/port/test.py >+++ b/Tools/Scripts/webkitpy/port/test.py >@@ -102,7 +102,7 @@ class TestList(object): > # > # These numbers may need to be updated whenever we add or delete tests. > # >-TOTAL_TESTS = 76 >+TOTAL_TESTS = 77 > TOTAL_SKIPS = 9 > TOTAL_RETRIES = 15 > >@@ -125,6 +125,9 @@ def unit_test_list(): > tests.add('failures/expected/image.html', > actual_image='image_fail-pngtEXtchecksum\x00checksum_fail', > expected_image='image-pngtEXtchecksum\x00checksum-png') >+ tests.add('failures/expected/pixel-fail.html', >+ actual_image='image_fail-pngtEXtchecksum\x00checksum_fail', >+ expected_image='image-pngtEXtchecksum\x00checksum-png') > tests.add('failures/expected/image_checksum.html', > actual_checksum='image_checksum_fail-checksum', > actual_image='image_checksum_fail-png') >@@ -293,6 +296,7 @@ Bug(test) failures/expected/leak.html [ Leak ] > Bug(test) failures/expected/flaky-leak.html [ Failure Leak ] > Bug(test) failures/expected/leaky-reftest.html [ ImageOnlyFailure Leak ] > Bug(test) failures/expected/image.html [ ImageOnlyFailure ] >+Bug(test) failures/expected/pixel-fail.html [ ImageOnlyFailure ] > Bug(test) failures/expected/audio.html [ Failure ] > Bug(test) failures/expected/image_checksum.html [ ImageOnlyFailure ] > Bug(test) failures/expected/mismatch.html [ ImageOnlyFailure ] >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 08a953cc228315342cd2911cf5f83aeda79d46b3..6ae2244a9530c70a399c471ce60846487787961d 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,16 @@ >+2018-09-05 Simon Fraser <simon.fraser@apple.com> >+ >+ Enable world leaks by default for Mac WK2 >+ https://bugs.webkit.org/show_bug.cgi?id=189332 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Add lots of leak expectaions. >+ >+ * TestExpectations: >+ * platform/mac-wk2/TestExpectations: >+ * platform/mac/TestExpectations: >+ > 2018-09-05 Truitt Savell <tsavell@apple.com> > > Rebaseline test after changes in https://trac.webkit.org/changeset/235669/webkit deleted the expectation. >diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations >index 860e9016ff7ff29d861153f16c08edb33f6eecb8..fd4963324a885f17086a472fe0e4948d285061ba 100644 >--- a/LayoutTests/TestExpectations >+++ b/LayoutTests/TestExpectations >@@ -410,7 +410,7 @@ fast/misc/valid-primary-screen-displayID.html [ Skip ] > # media/video-seek-after-end.html is flaky > webkit.org/b/116293 media/video-seek-after-end.html [ Pass Failure ] > >-webkit.org/b/116473 editing/selection/user-drag-element-and-user-select-none.html [ Failure ] >+webkit.org/b/116473 editing/selection/user-drag-element-and-user-select-none.html [ Leak Failure ] > > webkit.org/b/139862 editing/spelling/editing-multiple-words-with-markers.html [ Timeout Pass ] > webkit.org/b/139903 editing/spelling/grammar-paste.html [ Timeout Pass ] >@@ -581,7 +581,7 @@ imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioni > imported/w3c/web-platform-tests/css/css-scoping/css-scoping-shadow-host-namespace.html [ ImageOnlyFailure ] > imported/w3c/web-platform-tests/IndexedDB/abort-in-initial-upgradeneeded.html [ Pass Failure ] > imported/w3c/web-platform-tests/IndexedDB/clone-before-keypath-eval.html [ Pass Failure ] >-imported/w3c/web-platform-tests/IndexedDB/bindings-inject-key.html [ Pass Failure ] >+imported/w3c/web-platform-tests/IndexedDB/bindings-inject-key.html [ Pass Failure Leak ] > > # Those WPT tests are flaky when failing. > imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html [ Pass Failure ] >@@ -1380,14 +1380,14 @@ storage/indexeddb/open-db-private-browsing.html [ Failure ] > # Relies on internals.observeGC > storage/indexeddb/connection-leak-private.html [ Skip ] > storage/indexeddb/connection-leak.html [ Skip ] >-storage/indexeddb/cursor-leak-private.html [ Failure ] >+storage/indexeddb/cursor-leak-private.html [ Leak Failure ] > storage/indexeddb/cursor-leak.html [ Skip ] > storage/indexeddb/cursor-request-cycle-private.html [ Failure ] > storage/indexeddb/cursor-request-cycle.html [ Skip ] > storage/indexeddb/delete-closed-database-object-private.html [ Skip ] > storage/indexeddb/delete-closed-database-object.html [ Skip ] >-storage/indexeddb/request-leak-private.html [ Failure ] >-storage/indexeddb/request-leak.html [ Failure ] >+storage/indexeddb/request-leak-private.html [ Leak Failure ] >+storage/indexeddb/request-leak.html [ Leak Failure ] > > webkit.org/b/154619 storage/indexeddb/odd-strings.html [ Skip ] > >@@ -2063,8 +2063,8 @@ webkit.org/b/184802 http/tests/security/contentTypeOptions/nosniff-importScript- > > webkit.org/b/181100 inspector/worker/worker-recover-if-inspector-close.html [ Pass Failure ] > >-[ Debug ] imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html [ Failure ] >-[ Debug ] imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html [ Failure ] >+imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html [ Failure Leak ] >+imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html [ Failure Leak ] > webkit.org/b/186574 media/video-buffering-allowed.html [ Pass Failure ] > > ### WebL Conformance Suite 2.0.0 tests that do not yet have support as of 6/7/2018. Enable as support is implemented. ### >@@ -2215,14 +2215,14 @@ imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.http > > webkit.org/b/175609 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_getAll.html [ Pass Failure ] > webkit.org/b/175609 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_getKey.html [ Pass Failure ] >-webkit.org/b/175609 imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys.html [ Pass Failure ] >+webkit.org/b/175609 imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys.html [ Pass Failure Leak ] > webkit.org/b/175609 imported/w3c/web-platform-tests/IndexedDB/idbcursor-continue.htm [ Pass Failure ] > webkit.org/b/175609 imported/w3c/web-platform-tests/IndexedDB/idbdatabase-deleteObjectStore-exception-order.htm [ Pass Failure ] > webkit.org/b/175609 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_getAllKeys.html [ Pass Failure ] > >-webkit.org/b/189091 imported/w3c/web-platform-tests/intersection-observer/bounding-box.html [ Pass Failure ] >-webkit.org/b/189091 imported/w3c/web-platform-tests/intersection-observer/display-none.html [ Pass Failure ] >-webkit.org/b/189091 imported/w3c/web-platform-tests/intersection-observer/containing-block.html [ Pass Failure ] >+webkit.org/b/189091 imported/w3c/web-platform-tests/intersection-observer/bounding-box.html [ Pass Leak Failure ] >+webkit.org/b/189091 imported/w3c/web-platform-tests/intersection-observer/display-none.html [ Pass Leak Failure ] >+webkit.org/b/189091 imported/w3c/web-platform-tests/intersection-observer/containing-block.html [ Pass Leak Failure ] > > webkit.org/b/186848 imported/w3c/web-platform-tests/FileAPI/blob/Blob-slice.html [ Pass Failure ] > webkit.org/b/179176 svg/wicd/test-rightsizing-a.xhtml [ Pass Failure ] >@@ -2239,3 +2239,314 @@ webkit.org/b/187762 http/tests/websocket/tests/hybi/websocket-cookie-overwrite-b > webkit.org/b/187269 [ Debug ] imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_abort.html [ Skip ] > > webkit.org/b/185308 legacy-animation-engine/animations/combo-transform-translate+scale.html [ Pass Failure ] >+ >+# Leaks >+fast/animation/request-animation-frame-unparented-iframe-crash.html [ Leak Pass ] >+fast/css/user-drag-none.html [ Leak ] >+fast/encoding/mailto-always-utf-8.html [ Leak ] >+fast/events/selectstart-prevent-selection-on-right-click.html [ Leak ] >+fast/events/shift-drag-selection-on-link-triggers-drag-n-drop.html [ Leak ] >+fast/events/tabindex-focus-chain.html [ Leak ] >+fast/forms/append-children-during-form-submission.html [ Leak ] >+fast/forms/empty-textarea-toggle-disabled.html [ Leak ] >+fast/forms/mailto/formenctype-attribute-button-html.html [ Leak ] >+fast/forms/mailto/formenctype-attribute-input-2.html [ Leak ] >+fast/forms/mailto/formenctype-attribute-input-html.html [ Leak ] >+fast/forms/textarea-paste-newline.html [ Leak ] >+fast/forms/textarea-trailing-newline.html [ Leak ] >+fast/forms/textfield-drag-into-disabled.html [ Leak ] >+fast/hidpi/video-controls-in-hidpi.html [ Leak ] >+fast/history/page-cache-geolocation-active-watcher.html [ Leak ] >+fast/images/drag-pdf-as-image.html [ Leak ] >+fast/loader/policy-delegate-action-hit-test-zoomed.html [ Leak ] >+fast/shadow-dom/fullscreen-in-slot-webkitCurrentFullScreenElement.html [ Leak ] >+fast/shadow-dom/pointerlockelement-in-slot.html [ Leak ] >+fast/workers/wrapper-map-gc.html [ Pass Leak ] >+fast/css3-text/css3-text-decoration/repaint/underline-outside-of-layout-rect-altered.html [ Leak Pass ] >+fast/history/page-cache-notification-non-suspendable.html [ Leak Pass ] >+ >+accessibility/notification-listeners.html [ Leak ] >+compositing/no-compositing-when-fulll-screen-is-present.html [ Leak ] >+ >+contentfiltering/block-after-add-data-then-deny-unblock.html [ Leak ] >+contentfiltering/block-after-add-data.html [ Leak ] >+contentfiltering/block-after-finished-adding-data-then-deny-unblock.html [ Leak ] >+contentfiltering/block-after-finished-adding-data.html [ Leak ] >+contentfiltering/block-after-response-then-deny-unblock.html [ Leak ] >+contentfiltering/block-after-response.html [ Leak ] >+contentfiltering/block-after-will-send-request-then-deny-unblock.html [ Leak ] >+contentfiltering/block-after-will-send-request.html [ Leak ] >+ >+dom/html/level2/html/HTMLAnchorElement14.html [ Leak ] >+dom/html/level2/html/HTMLInputElement20.html [ Leak ] >+dom/html/level2/html/HTMLSelectElement14.html [ Leak ] >+dom/html/level2/html/HTMLTextAreaElement14.html [ Leak ] >+dom/html/level2/html/HTMLTextAreaElement15.html [ Leak ] >+editing/inserting/insert-bg-font.html [ Leak ] >+editing/inserting/insert-html-crash-01.html [ Leak ] >+ >+editing/pasteboard/drag-drop-iframe-refresh-crash.html [ Leak ] >+editing/pasteboard/drop-text-events-sideeffect.html [ Leak ] >+editing/selection/blockquote-crash.html [ Leak ] >+editing/selection/deleteFromDocument-after-document-open-crash.html [ Leak ] >+editing/selection/minimal-user-select-crash.html [ Leak ] >+editing/spelling/spellcheck-async-remove-frame.html [ Leak ] >+editing/spelling/spellcheck-input-search-crash.html [ Leak ] >+editing/spelling/spelling-marker-description.html [ Leak ] >+ >+fullscreen/video-specified-size.html [ Leak ] >+fullscreen/video-controls-timeline.html [ Leak Pass ] >+ >+http/tests/preconnect/link-header-rel-preconnect-http.html [ Leak ] >+http/tests/preconnect/link-rel-preconnect-http.html [ Leak ] >+http/tests/preconnect/link-rel-preconnect-https.html [ Leak ] >+ >+http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html [ Leak ] >+http/wpt/beacon/beacon-async-error-logging.html [ Leak ] >+http/tests/contentfiltering/block-after-redirect.html [ Leak ] >+http/tests/fullscreen/fullscreenelement-same-origin.html [ Leak ] >+http/tests/media/hls/video-duration-accessibility.html [ Leak ] >+ >+http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html [ Leak ] >+ >+imported/blink/compositing/drag-opacity-crash.html [ Leak ] >+ >+imported/blink/editing/apply-inline-style-to-element-with-no-renderer-crash.html [ Leak ] >+imported/blink/editing/execCommand/format-block-removes-destination-crash.html [ Leak ] >+imported/blink/editing/text-iterator/read-past-cloned-first-letter.html [ Leak ] >+ >+imported/blink/fast/dom/discard-svg-font-face-crash.svg [ Leak ] >+imported/blink/fast/dom/remove-svg-font-face-element-crash.xhtml [ Leak ] >+imported/blink/fast/events/drag-leak-document.html [ Leak ] >+imported/blink/fast/forms/time-multiple-fields/time-multiple-fields-crash-by-focus-on-unload.html [ Leak ] >+ >+imported/blink/storage/indexeddb/blob-valid-before-commit.html [ Leak ] >+ >+imported/mozilla/css-animations/test_animation-cancel.html [ Leak ] >+imported/mozilla/css-animations/test_animation-ready.html [ Leak ] >+imported/mozilla/css-animations/test_animation-reverse.html [ Leak ] >+imported/mozilla/css-transitions/test_animation-ready.html [ Leak ] >+imported/mozilla/css-transitions/test_element-get-animations.html [ Leak ] >+ >+imported/w3c/IndexedDB-private-browsing/idbcursor_delete_objectstore3.html [ Leak ] >+imported/w3c/IndexedDB-private-browsing/idbcursor_update_index3.html [ Leak ] >+imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore3.html [ Leak ] >+imported/w3c/IndexedDB-private-browsing/value.html [ Leak ] >+imported/w3c/IndexedDB-private-browsing/value_recursive.html [ Leak ] >+ >+imported/w3c/web-platform-tests/IndexedDB/idb-binary-key-roundtrip.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbcursor-continuePrimaryKey-exception-order.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbcursor-continuePrimaryKey.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbcursor_delete_index3.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbcursor_delete_objectstore3.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbcursor_update_index3.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbcursor_update_objectstore3.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbindex-rename-abort.html [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbindex-rename-errors.html [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbindex-rename.html [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbindex_getAll.html [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-abort.html [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/request-abort-ordering.html [ Leak ] >+imported/w3c/web-platform-tests/IndexedDB/request-event-ordering.html [ Leak ] >+ >+imported/w3c/IndexedDB-private-browsing/idbcursor_delete_index3.html [ Pass Leak ] >+imported/w3c/IndexedDB-private-browsing/transaction-requestqueue.html [ Pass Leak ] >+ >+storage/indexeddb/closed-cursor-private.html [ Leak ] >+storage/indexeddb/closed-cursor.html [ Leak ] >+storage/indexeddb/create-object-store-options-private.html [ Leak ] >+storage/indexeddb/create-object-store-options.html [ Leak ] >+storage/indexeddb/cursor-properties-private.html [ Leak ] >+storage/indexeddb/cursor-properties.html [ Leak ] >+storage/indexeddb/cursor-value-private.html [ Leak ] >+storage/indexeddb/cursor-value.html [ Leak ] >+storage/indexeddb/deleted-objects-private.html [ Leak ] >+storage/indexeddb/deleted-objects.html [ Leak ] >+storage/indexeddb/exceptions-private.html [ Leak ] >+storage/indexeddb/exceptions.html [ Leak ] >+storage/indexeddb/key-type-array-private.html [ Leak ] >+storage/indexeddb/key-type-array.html [ Leak ] >+storage/indexeddb/keypath-arrays-private.html [ Leak ] >+storage/indexeddb/keypath-arrays.html [ Leak ] >+storage/indexeddb/keypath-fetch-key-private.html [ Leak ] >+storage/indexeddb/keypath-fetch-key.html [ Leak ] >+storage/indexeddb/modern/blob-svg-image.html [ Leak ] >+storage/indexeddb/modern/idbcursor-continue-primary-key-1-private.html [ Leak ] >+storage/indexeddb/modern/idbcursor-continue-primary-key-1.html [ Leak ] >+storage/indexeddb/modern/idbindex-getall-1-private.html [ Leak ] >+storage/indexeddb/modern/idbindex-getall-1.html [ Leak ] >+storage/indexeddb/modern/idbindex-getallkeys-1-private.html [ Leak ] >+storage/indexeddb/modern/idbindex-getallkeys-1.html [ Leak ] >+storage/indexeddb/modern/idbobjectstore-getall-1-private.html [ Leak ] >+storage/indexeddb/modern/idbobjectstore-getall-1.html [ Leak ] >+storage/indexeddb/modern/idbobjectstore-getallkeys-1-private.html [ Leak ] >+storage/indexeddb/modern/idbobjectstore-getallkeys-1.html [ Leak ] >+storage/indexeddb/mozilla/autoincrement-indexes-private.html [ Leak ] >+storage/indexeddb/mozilla/autoincrement-indexes.html [ Leak ] >+storage/indexeddb/mozilla/cursor-update-updates-indexes-private.html [ Leak ] >+storage/indexeddb/mozilla/cursor-update-updates-indexes.html [ Leak ] >+storage/indexeddb/mozilla/object-cursors-private.html [ Leak ] >+storage/indexeddb/mozilla/object-cursors.html [ Leak ] >+storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-private.html [ Leak ] >+storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html [ Leak ] >+storage/indexeddb/mozilla/readyState-private.html [ Leak ] >+storage/indexeddb/mozilla/readyState.html [ Leak ] >+storage/indexeddb/objectstore-autoincrement-private.html [ Leak ] >+storage/indexeddb/objectstore-autoincrement.html [ Leak ] >+storage/indexeddb/optional-arguments-private.html [ Leak ] >+storage/indexeddb/optional-arguments.html [ Leak ] >+storage/indexeddb/prefetch-bugfix-108071-private.html [ Leak ] >+storage/indexeddb/prefetch-bugfix-108071.html [ Leak ] >+storage/indexeddb/readonly-private.html [ Leak ] >+storage/indexeddb/readonly.html [ Leak ] >+ >+imported/w3c/web-platform-tests/IndexedDB/value.htm [ Pass Leak ] >+imported/w3c/web-platform-tests/IndexedDB/value_recursive.htm [ Pass Leak ] >+ >+imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-content-hierarcy.html [ Leak ] >+ >+imported/w3c/web-platform-tests/intersection-observer/client-rect.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/disconnect.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/edge-inclusive-intersection.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/iframe-no-root.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/inline-client-rect.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/isIntersecting-change-events.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/multiple-targets.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/multiple-thresholds.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/observer-attributes.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/observer-without-js-reference.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/remove-element.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/root-margin.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/same-document-no-root.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/same-document-root.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/same-document-zero-size-target.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/shadow-content.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/text-target.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/timestamp.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/unclipped-root.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/zero-area-element-hidden.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/zero-area-element-visible.html [ Leak ] >+imported/w3c/web-platform-tests/intersection-observer/observer-exceptions.html [ Pass Leak ] >+ >+intersection-observer/root-element-deleted.html [ Leak ] >+intersection-observer/root-element-moved.html [ Leak ] >+ >+imported/w3c/web-platform-tests/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https.html [ Leak ] >+ >+imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html [ Leak ] >+ >+inspector/css/add-rule.html [ Leak ] >+inspector/css/selector-specificity.html [ Leak ] >+inspector/css/shadow-scoped-style.html [ Leak ] >+inspector/css/stylesheet-events-inspector-stylesheet.html [ Leak ] >+inspector/css/stylesheet-with-mutations.html [ Leak ] >+inspector/dom/highlight-shape-outside.html [ Leak ] >+ >+http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html [ Leak ] >+media/controls/elementOrder.html [ Leak ] >+media/controls/inline-elements-dropoff-order.html [ Leak ] >+media/controls/track-menu.html [ Leak ] >+media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Leak ] >+media/modern-media-controls/css/pointer-events-none.html [ Leak ] >+media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html [ Leak ] >+media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html [ Leak ] >+media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Leak ] >+media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Leak ] >+media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Leak ] >+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Leak ] >+media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Leak ] >+media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html [ Leak ] >+media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html [ Leak ] >+media/modern-media-controls/placard-support/placard-support-pip.html [ Leak ] >+media/modern-media-controls/seek-backward-support/seek-backward-support.html [ Leak ] >+media/modern-media-controls/seek-forward-support/seek-forward-support.html [ Leak ] >+media/modern-media-controls/start-support/start-support-click-to-start.html [ Leak ] >+media/modern-media-controls/start-support/start-support-fullscreen.html [ Leak ] >+media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html [ Leak ] >+media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html [ Leak ] >+media/modern-media-controls/volume-down-support/volume-down-support.html [ Leak ] >+media/modern-media-controls/volume-up-support/volume-up-support.html [ Leak ] >+ >+plugins/fullscreen-plugins-dont-reload.html [ Leak ] >+ >+pointer-lock/mouse-event-delivery.html [ Leak Pass ] >+pointer-lock/lock-lost-on-esc-in-fullscreen.html [ Leak ] >+ >+storage/websql/sql-error-codes.html [ Leak ] >+storage/websql/transaction-error-callback-isolated-world.html [ Leak ] >+ >+svg/W3C-SVG-1.1-SE/color-prop-05-t.svg [ Leak ] >+svg/W3C-SVG-1.1/animate-elem-03-t.svg [ Leak ] >+svg/W3C-SVG-1.1/animate-elem-24-t.svg [ Leak ] >+svg/W3C-SVG-1.1/animate-elem-36-t.svg [ Leak ] >+svg/W3C-SVG-1.1/animate-elem-40-t.svg [ Leak ] >+svg/W3C-SVG-1.1/fonts-desc-02-t.svg [ Leak ] >+svg/W3C-SVG-1.1/fonts-elem-01-t.svg [ Leak ] >+svg/W3C-SVG-1.1/fonts-elem-02-t.svg [ Leak ] >+svg/W3C-SVG-1.1/fonts-elem-05-t.svg [ Leak ] >+svg/W3C-SVG-1.1/fonts-elem-06-t.svg [ Leak ] >+svg/W3C-SVG-1.1/fonts-glyph-02-t.svg [ Leak ] >+svg/W3C-SVG-1.1/fonts-glyph-03-t.svg [ Leak ] >+svg/W3C-SVG-1.1/fonts-kern-01-t.svg [ Leak ] >+svg/W3C-SVG-1.1/masking-mask-01-b.svg [ Leak ] >+svg/W3C-SVG-1.1/pservers-grad-08-b.svg [ Leak ] >+svg/W3C-SVG-1.1/render-elems-06-t.svg [ Leak ] >+svg/W3C-SVG-1.1/render-elems-07-t.svg [ Leak ] >+svg/W3C-SVG-1.1/render-elems-08-t.svg [ Leak ] >+svg/W3C-SVG-1.1/render-groups-01-b.svg [ Leak ] >+svg/W3C-SVG-1.1/render-groups-03-t.svg [ Leak ] >+svg/W3C-SVG-1.1/text-align-08-b.svg [ Leak ] >+svg/W3C-SVG-1.1/text-altglyph-01-b.svg [ Leak ] >+svg/W3C-SVG-1.1/text-fonts-03-t.svg [ Leak ] >+svg/W3C-SVG-1.1/text-text-04-t.svg [ Leak ] >+svg/W3C-SVG-1.1/text-text-05-t.svg [ Leak ] >+svg/W3C-SVG-1.1/text-text-06-t.svg [ Leak ] >+svg/animations/animate-elem-03-t-drt.html [ Leak ] >+svg/as-image/drag-svg-as-image.html [ Leak ] >+svg/batik/filters/feTile.svg [ Leak ] >+svg/batik/masking/maskRegions.svg [ Leak ] >+svg/batik/paints/gradientLimit.svg [ Leak ] >+svg/batik/text/textEffect.svg [ Leak ] >+svg/batik/text/textEffect2.svg [ Leak ] >+svg/batik/text/textEffect3.svg [ Leak ] >+svg/batik/text/textPosition2.svg [ Leak ] >+svg/batik/text/xmlSpace.svg [ Leak ] >+svg/custom/altglyph.svg [ Leak ] >+svg/custom/assert-empty-layout-attributes.svg [ Leak ] >+svg/custom/font-platformDestroy-crash.svg [ Leak ] >+svg/custom/glyph-selection-arabic-forms.svg [ Leak ] >+svg/custom/glyph-selection-bidi-mirror.svg [ Leak ] >+svg/custom/glyph-selection-lang-attribute.svg [ Leak ] >+svg/custom/glyph-selection-non-bmp.svg [ Leak ] >+svg/custom/glyph-setting-d-attribute.svg [ Leak ] >+svg/custom/many-glyphs.svg [ Leak ] >+svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html [ Leak ] >+svg/custom/svg-element-destructor-iteration-crash.html [ Leak ] >+svg/custom/svg-fonts-fallback.xhtml [ Leak ] >+svg/custom/svg-fonts-segmented.xhtml [ Leak ] >+svg/custom/svg-fonts-without-missing-glyph.xhtml [ Leak ] >+svg/custom/text-linking.svg [ Leak ] >+svg/custom/use-multiple-on-nested-disallowed-font.html [ Leak ] >+svg/dom/altGlyph-dom.xhtml [ Leak ] >+svg/foreignObject/text-tref-02-b.svg [ Leak ] >+svg/text/alt-glpyh-on-fallback-font-crash.svg [ Leak ] >+svg/text/alt-glyph-for-surrogate-pair.svg [ Leak ] >+svg/text/kerning.svg [ Leak ] >+svg/text/multichar-glyph.svg [ Leak ] >+svg/text/text-altglyph-01-b.svg [ Leak ] >+svg/text/text-assert.svg [ Leak ] >+svg/text/text-font-anonymous-parent.xhtml [ Leak ] >+svg/text/text-hkern-on-vertical-text.svg [ Leak ] >+svg/text/text-hkern.svg [ Leak ] >+svg/text/text-text-04-t.svg [ Leak ] >+svg/text/text-text-05-t.svg [ Leak ] >+svg/text/text-text-06-t.svg [ Leak ] >+svg/text/text-vkern-on-horizontal-text.svg [ Leak ] >+svg/text/text-vkern.svg [ Leak ] >+svg/transforms/text-with-mask-with-svg-transform.svg [ Leak ] >+svg/wicd/test-rightsizing-b.xhtml [ Leak ] >diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations >index 53e4c9de41f2db4d0f017f6d3fb8882e1c702ced..94062f300ab84cd68b8a2bee5e273dd3ce1c1dea 100644 >--- a/LayoutTests/platform/mac-wk2/TestExpectations >+++ b/LayoutTests/platform/mac-wk2/TestExpectations >@@ -287,7 +287,7 @@ webkit.org/b/162999 accessibility/mac/wk1-set-selected-text-marker-range-input-e > # testRunner.setUseDeferredFrameLoading is not implemented. > webkit.org/b/93980 http/tests/appcache/load-from-appcache-defer-resume-crash.html [ Skip ] > >-webkit.org/b/172544 [ Debug ] tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html [ Pass Failure ] >+webkit.org/b/172544 [ Debug ] tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html [ Leak Failure ] > > webkit.org/b/136554 tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html [ Pass Failure ] > webkit.org/b/139901 tiled-drawing/scrolling/frames/frameset-frame-scrollability.html [ Pass Failure ] >@@ -661,7 +661,7 @@ webkit.org/b/171947 [ Sierra Release ] legacy-animation-engine/transitions/extra > > webkit.org/b/170699 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Pass Failure ] > >-webkit.org/b/168937 tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html [ Pass Failure ] >+webkit.org/b/168937 tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html [ Leak Failure ] > > webkit.org/b/172054 [ Sierra Debug ] loader/stateobjects/replacestate-size-iframe.html [ Pass Timeout ] > >@@ -749,7 +749,7 @@ webkit.org/b/185994 [ Debug ] fast/text/user-installed-fonts/shadow-postscript-f > [ HighSierra+ ] http/tests/ssl/applepay/ApplePayError.html [ Pass ] > [ HighSierra+ ] http/tests/ssl/applepay/ApplePaySessionV3.html [ Pass ] > [ Mojave+ ] http/tests/ssl/applepay/ApplePaySessionV4.html [ Pass ] >-[ HighSierra+ ] http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html [ Pass ] >+[ HighSierra+ ] http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html [ Leak Pass ] > # <rdar://problem/31634451> > [ HighSierra+ ] http/tests/resourceLoadStatistics/cookies-with-and-without-user-interaction.html [ Pass ] > [ HighSierra+ ] http/tests/resourceLoadStatistics/cookie-deletion.html [ Pass ] >@@ -869,3 +869,17 @@ imported/w3c/web-platform-tests/payment-request/show-method-postmessage-manual.h > imported/w3c/web-platform-tests/payment-request/updateWith-method-pmi-handling-manual.https.html [ Skip ] > imported/w3c/web-platform-tests/payment-request/user-abort-algorithm-manual.https.html [ Skip ] > imported/w3c/web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html [ Skip ] >+ >+# Leaks >+http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html [ Leak ] >+http/tests/paymentrequest/payment-request-merchant-validation.https.html [ Leak ] >+http/tests/paymentrequest/payment-request-show-method.https.html [ Leak ] >+http/tests/paymentrequest/payment-response-complete-method.https.html [ Leak ] >+http/tests/paymentrequest/payment-response-methodName-attribute.https.html [ Leak ] >+http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html [ Leak ] >+http/tests/paymentrequest/payment-response-payerName-attribute.https.html [ Leak ] >+http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html [ Leak ] >+ >+[ Sierra+ ] http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https.html [ Leak ] >+[ Sierra+ ] http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html [ Leak ] >+ >diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations >index f1c3daca2669cd3b7e5013c6f0b7d68d00575ab5..3a51a8a226e4b3146dc4651440f3294ac87e14e7 100644 >--- a/LayoutTests/platform/mac/TestExpectations >+++ b/LayoutTests/platform/mac/TestExpectations >@@ -488,18 +488,18 @@ webkit.org/b/73766 css3/unicode-bidi-isolate-aharon-failing.html [ ImageOnlyFail > # Failing ref tests > webkit.org/b/85404 fast/loader/javascript-url-in-embed.html [ Failure Pass ] > >-webkit.org/b/85408 svg/batik/text/longTextOnPath.svg [ Failure Pass ] >-webkit.org/b/85408 svg/batik/paints/gradientLimit.svg [ Failure Pass ] >+webkit.org/b/85408 svg/batik/text/longTextOnPath.svg [ Leak Failure ] >+webkit.org/b/85408 svg/batik/paints/gradientLimit.svg [ Leak Failure ] > webkit.org/b/85408 svg/batik/text/textOnPath.svg [ Failure Pass ] > webkit.org/b/85408 svg/batik/text/verticalTextOnPath.svg [ Failure Pass ] > webkit.org/b/85408 svg/batik/text/textPosition.svg [ Failure Pass ] > webkit.org/b/85408 svg/batik/text/verticalText.svg [ Failure Pass ] > webkit.org/b/85408 svg/batik/text/textLength.svg [ Failure Pass ] >-webkit.org/b/85408 svg/batik/text/textEffect.svg [ Pass Failure ] >+webkit.org/b/85408 svg/batik/text/textEffect.svg [ Leak Failure ] > webkit.org/b/85408 svg/batik/paints/patternRegions-positioned-objects.svg [ Pass Failure ] > webkit.org/b/85408 svg/batik/text/textDecoration.svg [ Pass Failure ] >-webkit.org/b/114120 svg/batik/masking/maskRegions.svg [ Pass Failure ] >-webkit.org/b/114375 svg/batik/filters/feTile.svg [ Pass Failure ] >+webkit.org/b/114120 svg/batik/masking/maskRegions.svg [ Leak Failure ] >+webkit.org/b/114375 svg/batik/filters/feTile.svg [ Leak Failure ] > > webkit.org/b/99893 svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg [ ImageOnlyFailure ] > >@@ -1000,16 +1000,16 @@ webkit.org/b/142087 fast/css3-text/css3-text-decoration/no-gap-between-two-round > webkit.org/b/142087 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-inherit.html [ ImageOnlyFailure ] > > # Tests that fail with the SVG -> OTF font converter, but are lower priority than live-on >-webkit.org/b/140588 svg/W3C-SVG-1.1/fonts-desc-02-t.svg [ Failure ] >-webkit.org/b/137096 svg/W3C-SVG-1.1/text-altglyph-01-b.svg [ Failure ] >-webkit.org/b/137096 svg/custom/altglyph.svg [ Failure ] >+webkit.org/b/140588 svg/W3C-SVG-1.1/fonts-desc-02-t.svg [ Leak Failure ] >+webkit.org/b/137096 svg/W3C-SVG-1.1/text-altglyph-01-b.svg [ Leak Failure ] >+webkit.org/b/137096 svg/custom/altglyph.svg [ Leak Failure ] > webkit.org/b/140590 svg/custom/svg-fonts-in-text-controls.html [ Failure ] >-webkit.org/b/137096 svg/text/text-altglyph-01-b.svg [ Failure ] >-webkit.org/b/137096 svg/text/alt-glyph-for-surrogate-pair.svg [ ImageOnlyFailure ] >-webkit.org/b/140589 svg/W3C-SVG-1.1/text-text-06-t.svg [ Failure ] >-webkit.org/b/140589 svg/text/text-text-06-t.svg [ Failure ] >-webkit.org/b/137098 svg/text/text-hkern.svg [ Failure ] >-webkit.org/b/137100 svg/text/text-vkern.svg [ Failure ] >+webkit.org/b/137096 svg/text/text-altglyph-01-b.svg [ Leak Failure ] >+webkit.org/b/137096 svg/text/alt-glyph-for-surrogate-pair.svg [ Leak ImageOnlyFailure ] >+webkit.org/b/140589 svg/W3C-SVG-1.1/text-text-06-t.svg [ Leak Failure ] >+webkit.org/b/140589 svg/text/text-text-06-t.svg [ Leak Failure ] >+webkit.org/b/137098 svg/text/text-hkern.svg [ Leak Failure ] >+webkit.org/b/137100 svg/text/text-vkern.svg [ Leak Failure ] > > # Sometimes has an extra space at the end > fast/forms/focus-selection-textarea.html [ Pass Failure ] >@@ -1237,7 +1237,7 @@ webkit.org/b/151287 [ Sierra+ ] media/controls/inline-elements-dropoff-order.htm > > webkit.org/b/158500 storage/indexeddb/database-close-private.html [ Pass Failure ] > >-webkit.org/b/163122 imported/blink/storage/indexeddb/blob-valid-after-deletion.html [ Pass Timeout ] >+webkit.org/b/163122 imported/blink/storage/indexeddb/blob-valid-after-deletion.html [ Pass Timeout Leak ] > > webkit.org/b/128312 media/video-load-preload-metadata.html [ Pass Failure ] > >@@ -1482,19 +1482,19 @@ webkit.org/b/161491 media/video-main-content-allow-then-scroll.html [ Pass Failu > webkit.org/b/172052 [ Debug ] imported/w3c/web-platform-tests/html/webappapis/timers/type-long-setinterval.html [ Pass Failure ] > > # <rdar://problem/29031509> REGRESSION? (FontParser-195): svg/W3C-SVG-1.1/fonts-elem-* and svg/W3C-SVG-1.1/text-intro-* tests failing >-[ HighSierra+ ] svg/W3C-SVG-1.1/fonts-elem-01-t.svg [ Failure ] >-[ HighSierra+ ] svg/W3C-SVG-1.1/fonts-elem-02-t.svg [ Failure ] >+[ HighSierra+ ] svg/W3C-SVG-1.1/fonts-elem-01-t.svg [ Leak Failure ] >+[ HighSierra+ ] svg/W3C-SVG-1.1/fonts-elem-02-t.svg [ Leak Failure ] > [ HighSierra+ ] svg/W3C-SVG-1.1/fonts-elem-03-b.svg [ Failure ] > [ HighSierra+ ] svg/W3C-SVG-1.1/fonts-elem-07-b.svg [ Failure ] > [ HighSierra+ ] svg/W3C-SVG-1.1/text-intro-01-t.svg [ Failure ] > [ HighSierra+ ] svg/W3C-SVG-1.1/text-intro-02-b.svg [ Failure ] > [ HighSierra+ ] svg/W3C-SVG-1.1/text-intro-03-b.svg [ Failure ] > [ HighSierra+ ] svg/W3C-SVG-1.1/text-intro-04-t.svg [ Failure ] >-[ HighSierra+ ] svg/batik/text/textEffect3.svg [ Failure ] >-[ HighSierra+ ] svg/batik/text/textPosition2.svg [ Failure ] >+[ HighSierra+ ] svg/batik/text/textEffect3.svg [ Leak Failure ] >+[ HighSierra+ ] svg/batik/text/textPosition2.svg [ Leak Failure ] > [ HighSierra+ ] svg/custom/acid3-test-77.html [ Failure ] >-[ HighSierra+ ] svg/custom/svg-fonts-fallback.xhtml [ Failure ] >-[ HighSierra+ ] svg/wicd/test-rightsizing-b.xhtml [ Failure ] >+[ HighSierra+ ] svg/custom/svg-fonts-fallback.xhtml [ Leak Failure ] >+[ HighSierra+ ] svg/wicd/test-rightsizing-b.xhtml [ Leak Failure ] > [ HighSierra+ ] fast/css-generated-content/initial-letter-first-line-wrapping.html [ ImageOnlyFailure ] > > # <rdar://problem/30493910> REGRESSION: LayoutTest fast/writing-mode/broken-ideograph-small-caps.html failing >@@ -1756,3 +1756,7 @@ webkit.org/b/187393 imported/w3c/web-platform-tests/2dcontext/imagebitmap/create > [ Mojave+ ] fast/inline/break-between-nobr.html [ ImageOnlyFailure ] > [ Mojave+ ] imported/blink/fast/text/international/text-shaping-arabic.html [ ImageOnlyFailure ] > [ Mojave+ ] imported/blink/fast/text/international/vertical-positioning-with-combining-marks.html [ ImageOnlyFailure ] >+ >+editing/mac/pasteboard/can-copy-url-without-title.html [ Leak ] >+editing/mac/selection/context-menu-select-editability.html [ Leak ] >+platform/mac/media/video-best-element-for-playback-controls-purpose.html [ Leak ]
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189332
:
348996
|
348997
|
348998
|
349024
|
349099
|
349102
|
349104
|
349112
|
349189
|
349207
|
349231
|
349233
|
349241
|
349250