Attachment 348958 Details for Bug 189315 – Patch

[patch] Patch

bug-189315-20180905133507.patch (text/plain), 1.70 KB, created by Wenson Hsieh on 2018-09-05 13:35:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-09-05 13:35:08 PDT

Size: 1.70 KB

patch

obsolete

>Subversion Revision: 235683
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 9bb48193bc143352d9944ffecf6d83441c6f1f49..fc09e32421224dd9fc8312a7f543e8459d74c4ac 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-05  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS versions prior to Mojave
>+        https://bugs.webkit.org/show_bug.cgi?id=189315
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix the test failure by explicitly enabling custom pasteboard data.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
>+        (TEST):
>+
> 2018-09-05  Woodrow Wang  <woodrow_wang@apple.com>
> 
>         Added runtime feature flag for web API statistics
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm
>index 94b5f708e96704b9003117e54de6c55a0040c8f3..206709efb0443e5115db1549ebc72d3b9908f040 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm
>@@ -27,6 +27,7 @@
> 
> #import "DragAndDropSimulator.h"
> #import "PlatformUtilities.h"
>+#import <WebKit/WKPreferencesPrivate.h>
> 
> #if WK_API_ENABLED && ENABLE(DRAG_SUPPORT)
> 
>@@ -47,6 +48,7 @@ TEST(DragAndDropTests, ExposeMultipleURLsInDataTransfer)
> {
>     auto simulator = adoptNS([[DragAndDropSimulator alloc] initWithWebViewFrame:CGRectMake(0, 0, 320, 500)]);
>     auto webView = [simulator webView];
>+    WKPreferencesSetCustomPasteboardDataEnabled((WKPreferencesRef)[webView configuration].preferences, true);
>     [webView synchronouslyLoadTestPageNamed:@"DataTransfer"];
> 
>     NSString *stringData = @"Hello world";

Actions: View | Formatted Diff | Diff

Attachments on bug 189315: 348958