Attachment 348919 Details for Bug 189305 – Patch

[patch] Patch

bug-189305-20180905164337.patch (text/plain), 10.50 KB, created by Ms2ger (he/him; ⌚ UTC+1/+2) on 2018-09-05 07:43:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ms2ger (he/him; ⌚ UTC+1/+2)

Created: 2018-09-05 07:43:38 PDT

Size: 10.50 KB

patch

obsolete

>Subversion Revision: 235664
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 7a29e036e5f847c77f567880607c39b6e07c46a1..3879ee7cb12346e495da0131fdcac40fc100256f 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-09-05  Ms2ger  <Ms2ger@igalia.com>
>+
>+        GTK-focused gardening
>+        https://bugs.webkit.org/show_bug.cgi?id=189305
>+
>+        Unreviewed test gardening.
>+
>+        * TestExpectations: Remove passing test.
>+        * fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html: Speculative fix for r235484.
>+        * platform/gtk/http/tests/inspector/network/resource-request-headers-expected.txt: Added.
>+        * platform/gtk/http/tests/loading/oauth-expected.txt: Added.
>+        * platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Added.
>+        * platform/gtk/imported/w3c/web-platform-tests/xhr/send-network-error-sync-events.sub-expected.txt: Updated for r235354.
>+        * platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Updated for r235245.
>+
> 2018-09-04  Yacine Bandou  <yacine.bandou_ext@softathome.com>
> 
>         [EME] Add a layoutTest for ClearKey WebM video playback
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index b468d8394b7d65ad05706f6f34e567547e64133e..860e9016ff7ff29d861153f16c08edb33f6eecb8 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -275,7 +275,6 @@ imported/w3c/web-platform-tests/xhr/send-authentication-basic-setrequestheader-e
> imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm [ Failure ]
> imported/w3c/web-platform-tests/xhr/preserve-ua-header-on-redirect.htm [ Failure ]
> imported/w3c/web-platform-tests/xhr/setrequestheader-case-insensitive.htm [ Failure ]
>-imported/w3c/web-platform-tests/xhr/send-network-error-async-events.sub.htm [ Failure ]
> http/tests/security/cross-origin-cached-images-parallel.html [ DumpJSConsoleLogInStdErr ]
> 
> # textarea.animate is not supported
>diff --git a/LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html b/LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html
>index 0c5538926f307b0ea1f8602935bf795a1657f2da..f811604ae56b178c29193d8a536ec764d1ba9e7f 100644
>--- a/LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html
>+++ b/LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html
>@@ -40,7 +40,7 @@
>             .then(function (s) {
>                 stream = s;
> 
>-                startTestWithMedia();
>+                return startTestWithMedia();
>             })
>             .catch(function (error) {
>                 testFailed(`Unable to get user media: ${error}`);
>@@ -52,15 +52,15 @@
>                 pcA.addTrack(stream.getAudioTracks()[0], stream);
> 
>                 debug("A: create offer");
>-                return pcA.createOffer(offer => {
>+                return pcA.createOffer().then(offer => {
>                     debug("A: got offer, set it as local description");
>-                    pcA.setLocalDescription(offer, () => {
>+                    return pcA.setLocalDescription(offer).then(() => {
>                         debug("A: local offer set");
>                         shouldBe("pcA.signalingState", "'have-local-offer'");
> 
>                         debug("A: send offer to B");
>                         debug("A --- offer --> B");
>-                        offerToPcB(pcA.localDescription);
>+                        return offerToPcB(pcA.localDescription);
>                     }, gotError);
> 
>                 }, gotError);
>@@ -68,7 +68,7 @@
> 
>             function offerToPcB(offer) {
>                 debug("B: got offer from A, set it as remote description");
>-                pcB.setRemoteDescription(offer, () => {
>+                return pcB.setRemoteDescription(offer).then(() => {
>                     debug("B: remote offer set");
>                     shouldBe("pcB.signalingState", "'have-remote-offer'");
> 
>@@ -76,15 +76,15 @@
>                     pcB.addTrack(stream.getAudioTracks()[0], stream);
> 
>                     debug("B: create answer");
>-                    return pcB.createAnswer(answer => {
>+                    return pcB.createAnswer().then(answer => {
>                         debug("B: got answer, set it as local description");
>-                        pcB.setLocalDescription(answer, () => {
>+                        return pcB.setLocalDescription(answer).then(() => {
>                             debug("B: local answer set");
>                             shouldBe("pcB.signalingState", "'stable'");
> 
>                             debug("B: send answer to A");
>                             debug("A <-- answer -- B");
>-                            answerToA(pcB.localDescription);
>+                            return answerToA(pcB.localDescription);
>                         }, gotError);
>                     }, gotError);
>                 }, gotError);
>@@ -92,7 +92,7 @@
> 
>             function answerToA(answer) {
>                 debug("A: got answer from B, set it as remote description");
>-                pcA.setRemoteDescription(answer, () => {
>+                return pcA.setRemoteDescription(answer).then(() => {
>                     debug("A: remote answer set");
>                     shouldBe("pcA.signalingState", "'stable'");
> 
>diff --git a/LayoutTests/platform/gtk/http/tests/inspector/network/resource-request-headers-expected.txt b/LayoutTests/platform/gtk/http/tests/inspector/network/resource-request-headers-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..d8dbf235c967bb2ed2e4a11cc30a1d7dfc5e838e
>--- /dev/null
>+++ b/LayoutTests/platform/gtk/http/tests/inspector/network/resource-request-headers-expected.txt
>@@ -0,0 +1,36 @@
>+127.0.0.1:8000 - didReceiveAuthenticationChallenge - ProtectionSpaceAuthenticationSchemeHTTPBasic - Simulating cancelled authentication sheet
>+127.0.0.1:8000 - didReceiveAuthenticationChallenge - ProtectionSpaceAuthenticationSchemeHTTPBasic - Simulating cancelled authentication sheet
>+Test for Resource request headers which may not have been immediately available but eventually are (Cookie, Authorization).
>+
>+
>+== Running test suite: Resource.Metrics.RequestHeaders
>+-- Running test case: Resource.Metrics.RequestHeaders.WithoutCookie
>+PASS: Resource should be created.
>+PASS: Resource should receive a Response.
>+PASS: Request should not have a 'Cookie' header.
>+
>+-- Running test case: Resource.Metrics.RequestHeaders.WithCookie
>+PASS: Resource should be created.
>+PASS: Resource should receive a Response.
>+PASS: 'Cookie' header value should be `InspectorTestCookie=1234`.
>+
>+-- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.None
>+PASS: Resource should be created.
>+PASS: Resource should receive a Response.
>+PASS: Resource should have a 401 status code.
>+PASS: Response should have a 'WWW-Authenticate' response header for the failure.
>+PASS: Request should not have a 'Authorization' header.
>+
>+-- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.Failure
>+PASS: Resource should be created.
>+PASS: Resource should receive a Response.
>+PASS: Resource should have a 401 status code.
>+PASS: Response should have a 'WWW-Authenticate' response header for the failure.
>+PASS: 'Authorization' header value should be for badUsername:badPassword.
>+
>+-- Running test case: Resource.Metrics.RequestHeaders.BasicAuth.Success
>+PASS: Resource should be created.
>+PASS: Resource should receive a Response.
>+PASS: Resource should have a 200 status code.
>+PASS: 'Authorization' header value should be for goodUsername:goodPassword.
>+
>diff --git a/LayoutTests/platform/gtk/http/tests/loading/oauth-expected.txt b/LayoutTests/platform/gtk/http/tests/loading/oauth-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..61f91cbd4c08752002507590910833154977e590
>--- /dev/null
>+++ b/LayoutTests/platform/gtk/http/tests/loading/oauth-expected.txt
>@@ -0,0 +1,6 @@
>+main frame - didStartProvisionalLoadForFrame
>+main frame - didCommitLoadForFrame
>+main frame - didFinishDocumentLoadForFrame
>+main frame - didHandleOnloadEventsForFrame
>+main frame - didFinishLoadForFrame
>+
>diff --git a/LayoutTests/platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt b/LayoutTests/platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..07e57fc6317be73305839b2280fe3479e1ced14f
>--- /dev/null
>+++ b/LayoutTests/platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt
>@@ -0,0 +1,11 @@
>+CONSOLE MESSAGE: WebSocket connection to 'ws://localhost/' failed: Unexpected response code: 200
>+Construct a cross-site WebSocket in a frame with server-side refusal. The test passes if Resource Load Statistics logs it properly.
>+
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>+
>+
>+PASS localhost registered as subresource under 127.0.0.1.
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
>+
>diff --git a/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/xhr/send-network-error-sync-events.sub-expected.txt b/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/xhr/send-network-error-sync-events.sub-expected.txt
>index 2acce45559ec1a6b550ae49ec28e2399591489b0..7b3cea2deff8ee2b2bc7dde3a500b3927468d454 100644
>--- a/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/xhr/send-network-error-sync-events.sub-expected.txt
>+++ b/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/xhr/send-network-error-sync-events.sub-expected.txt
>@@ -1,4 +1,4 @@
>-Blocked access to external URL http://nonexistent-origin.localhost:8800/
>+Blocked access to external URL http://nonexistent.localhost:8800/
> 
> PASS http URL 
> FAIL data URL assert_throws: function "function ()
>diff --git a/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt b/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt
>index e6f05d2adf138f3eda87eeecb02e366eca0b0b0c..1bc912650bee24faef926fdda9e976e7ea2ca3ba 100644
>--- a/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt
>+++ b/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt
>@@ -51,6 +51,7 @@ PASS a["offsetWidth"] is 39
> PASS a["offsetHeight"] is 17
> PASS a["outerText"] is nerget
> PASS a["webkitdropzone"] is 
>+PASS a["inputMode"] is 
> PASS a["style"] is [object CSSStyleDeclaration]
> PASS a["onabort"] is null
> PASS a["onblur"] is null

Actions: View | Formatted Diff | Diff

Attachments on bug 189305: 348919