Attachment 348906 Details for Bug 189215 – Patch

[patch] Patch

bug-189215-20180905123402.patch (text/plain), 1.80 KB, created by Zan Dobersek on 2018-09-05 03:34:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2018-09-05 03:34:03 PDT

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 235657
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b954a5c0e76a71f3d46c791b0c774baf34ed21eb..4ef3043ffbdb4029d6271e69eec55830d0551471 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-04  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [GTK] ASSERT(!m_nicosia.imageBacking) when starting any YouTube video
>+        https://bugs.webkit.org/show_bug.cgi?id=189215
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
>+        (WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
>+        Manually clear out any layer-side state of any image backing that is
>+        associated with this layer, much like we do for backing stores.
>+
> 2018-09-04  Antti Koivisto  <antti@apple.com>
> 
>         Remove pointless RenderSVGResourceMode::ApplyToDefault enum value
>diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>index 7b0b295207a9337a7a7b55d2ae5f4a661263a1e2..09e56f331828c5bc05f4d4b983fb667f67896585 100644
>--- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>+++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>@@ -966,6 +966,15 @@ void CoordinatedGraphicsLayer::purgeBackingStores()
>         m_nicosia.backingStore = nullptr;
>     }
> 
>+    if (m_nicosia.imageBacking) {
>+        auto& layerState = downcast<Nicosia::ImageBackingTextureMapperImpl>(m_nicosia.imageBacking->impl()).layerState();
>+        layerState.imageID = 0;
>+        layerState.nativeImageID = 0;
>+        layerState.update = { };
>+
>+        m_nicosia.imageBacking = nullptr;
>+    }
>+
>     notifyFlushRequired();
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 189215: 348680 | 348906