Attachment 348897 Details for Bug 189298 – Patch

[patch] Patch

bug-189298-20180905153716.patch (text/plain), 1.73 KB, created by Fujii Hironori on 2018-09-04 23:37:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-09-04 23:37:17 PDT

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 235656
>diff --git a/Websites/webkit.org/ChangeLog b/Websites/webkit.org/ChangeLog
>index f9cae2ac3a46cbeedf600648369cd9c06b6d3475..e57a54d992d7900e7764dd823865f18a9c2f16f9 100644
>--- a/Websites/webkit.org/ChangeLog
>+++ b/Websites/webkit.org/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-09-04  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        Update code style guidelines for using namespace inside a namespace definition
>+        https://bugs.webkit.org/show_bug.cgi?id=189298
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        "using namespace" statements should be inside namespace definitions for
>+        unified source builds.
>+
>+        * code-style.md(#using-position): 
>+
> 2018-08-31  Dean Jackson  <dino@apple.com>
> 
>         Add support for USDZ to webkit.org for a sample file
>diff --git a/Websites/webkit.org/code-style.md b/Websites/webkit.org/code-style.md
>index 75940674a90ef9046dd3e735ab17dcfba886ff5f..0b71e8d6666d4cea08ac951983b6c01a8543e5b0 100644
>--- a/Websites/webkit.org/code-style.md
>+++ b/Websites/webkit.org/code-style.md
>@@ -1126,17 +1126,17 @@ namespace WebCore {
> } // namespace WebCore
> ```
> 
>-[](#using-position) In implementation files, put all other "using" statements at the beginning of the file, before any namespace definitions and after any "include" statements.
>+[](#using-position) In implementation files, put all "using namespace" statements inside namespace definitions.
> 
> ###### Right:
> 
> ```cpp
> // HTMLSelectElement.cpp
> 
>-using namespace other;
>-
> namespace WebCore {
> 
>+using namespace other;
>+
> } // namespace WebCore
> ```
> 
>@@ -1145,10 +1145,10 @@ namespace WebCore {
> ```cpp
> // HTMLSelectElement.cpp
> 
>-namespace WebCore {
>-
> using namespace other;
> 
>+namespace WebCore {
>+
> } // namespace WebCore
> ```
>

Actions: View | Formatted Diff | Diff

Attachments on bug 189298: 348897