Attachment 348893 Details for Bug 189297 – proposed patch.

[patch] proposed patch.

bug-189297.patch (text/plain), 1.35 KB, created by Mark Lam on 2018-09-04 21:52:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2018-09-04 21:52:11 PDT

Size: 1.35 KB

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 235657)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-09-04  Mark Lam  <mark.lam@apple.com>
>+
>+        Remove unused bad_optional_access implementation.
>+        https://bugs.webkit.org/show_bug.cgi?id=189297
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is a speculative fix for resolving build errors arising from conflicting
>+        definitions of bad_optional_access when building WebKit with the latest clang.
>+
>+        * wtf/Optional.h:
>+        (std::bad_optional_access::bad_optional_access): Deleted.
>+
> 2018-09-04  Michael Saboff  <msaboff@apple.com>
> 
>         YARR: JIT RegExps with back references
>Index: Source/WTF/wtf/Optional.h
>===================================================================
>--- Source/WTF/wtf/Optional.h	(revision 235657)
>+++ Source/WTF/wtf/Optional.h	(working copy)
>@@ -277,14 +277,6 @@ struct nullopt_t
> constexpr nullopt_t nullopt{nullopt_t::init()};
> 
> 
>-// 20.5.8, class bad_optional_access
>-class bad_optional_access : public std::logic_error {
>-public:
>-  explicit bad_optional_access(const std::string& what_arg) : std::logic_error{what_arg} {}
>-  explicit bad_optional_access(const char* what_arg) : std::logic_error{what_arg} {}
>-};
>-
>-
> template <class T>
> union storage_t
> {

Actions: View | Formatted Diff | Diff

Attachments on bug 189297: 348893