Attachment 348881 Details for Bug 189292 – proposed patch.

[patch] proposed patch.

bug-189292.patch (text/plain), 2.86 KB, created by Mark Lam on 2018-09-04 18:04:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2018-09-04 18:04:01 PDT

Size: 2.86 KB

patch

obsolete

>Index: JSTests/ChangeLog
>===================================================================
>--- JSTests/ChangeLog	(revision 235651)
>+++ JSTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-09-04  Mark Lam  <mark.lam@apple.com>
>+
>+        isAsyncGeneratorMethodParseMode() should check for SourceParseMode::AsyncGeneratorWrapperMethodMode.
>+        https://bugs.webkit.org/show_bug.cgi?id=189292
>+        <rdar://problem/38907433>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * stress/regress-189292.js: Added.
>+
> 2018-09-04  David Fenton  <david_fenton@apple.com>
> 
>         Skip Test on 32-bit platforms.
>Index: JSTests/stress/regress-189292.js
>===================================================================
>--- JSTests/stress/regress-189292.js	(nonexistent)
>+++ JSTests/stress/regress-189292.js	(working copy)
>@@ -0,0 +1,18 @@
>+//@ runDefault
>+
>+function assert(a, b) {
>+    if (a != b)
>+        throw "FAIL";
>+}
>+
>+function test(script) {
>+    try {
>+        eval(script);
>+    } catch (e) {
>+        return e;
>+    }
>+}
>+
>+assert(test("class C1 { async constructor() { } }"), "SyntaxError: Cannot declare an async method named 'constructor'.");
>+assert(test("class C1 { *constructor() { } }"), "SyntaxError: Cannot declare a generator function named 'constructor'.");
>+assert(test("class C1 { async *constructor() { } }"), "SyntaxError: Cannot declare an async generator method named 'constructor'.");
>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 235627)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-09-04  Mark Lam  <mark.lam@apple.com>
>+
>+        isAsyncGeneratorMethodParseMode() should check for SourceParseMode::AsyncGeneratorWrapperMethodMode.
>+        https://bugs.webkit.org/show_bug.cgi?id=189292
>+        <rdar://problem/38907433>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Previously, it's checking for SourceParseMode::AsyncGeneratorWrapperFunctionMode instead.
>+
>+        * parser/ParserModes.h:
>+        (JSC::isAsyncGeneratorMethodParseMode):
>+
> 2018-09-04  Mark Lam  <mark.lam@apple.com>
> 
>         Make the jsc shell print, printErr, and debug functions more robust.
>Index: Source/JavaScriptCore/parser/ParserModes.h
>===================================================================
>--- Source/JavaScriptCore/parser/ParserModes.h	(revision 235627)
>+++ Source/JavaScriptCore/parser/ParserModes.h	(working copy)
>@@ -188,7 +188,8 @@ ALWAYS_INLINE bool isAsyncMethodParseMod
>     
> ALWAYS_INLINE bool isAsyncGeneratorMethodParseMode(SourceParseMode parseMode)
> {
>-    return SourceParseModeSet(SourceParseMode::AsyncGeneratorWrapperFunctionMode).contains(parseMode);
>+    return SourceParseModeSet(
>+        SourceParseMode::AsyncGeneratorWrapperMethodMode).contains(parseMode);
> }
> 
> ALWAYS_INLINE bool isMethodParseMode(SourceParseMode parseMode)

Flags:

saam: review+
saam: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189292: 348881 | 348896