Attachment 348850 Details for Bug 189274 – ppatch

[patch] ppatch

189274.patch (text/plain), 3.21 KB, created by Michael Saboff on 2018-09-04 14:58:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Saboff

Created: 2018-09-04 14:58:32 PDT

Size: 3.21 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 235640)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-09-04  Michael Saboff  <msaboff@apple.com>
>+
>+        JSC Build error when changing CPU type: offlineasm: No magic values found. Skipping assembly file generation
>+        https://bugs.webkit.org/show_bug.cgi?id=189274
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Put the derived file LLIntDesiredOffsets.h in an architecture specific subdirectory to make them unique.
>+
>+        * JavaScriptCore.xcodeproj/project.pbxproj:
>+
> 2018-09-04  Michael Saboff  <msaboff@apple.com>
> 
>         YARR: JIT RegExps with back references
>Index: Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
>===================================================================
>--- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj	(revision 235633)
>+++ Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj	(working copy)
>@@ -9966,7 +9966,7 @@
> 			);
> 			runOnlyForDeploymentPostprocessing = 0;
> 			shellPath = /bin/sh;
>-			shellScript = "set -e\n\nmkdir -p \"${BUILT_PRODUCTS_DIR}/LLIntOffsets/\"\n\n/usr/bin/env ruby \"${SRCROOT}/offlineasm/generate_offset_extractor.rb\" \"-I${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\" \"${SRCROOT}/llint/LowLevelInterpreter.asm\" \"${BUILT_PRODUCTS_DIR}/LLIntOffsets/LLIntDesiredOffsets.h\" \"${ARCHS} C_LOOP\"\n";
>+			shellScript = "set -e\n\nmkdir -p \"${BUILT_PRODUCTS_DIR}/LLIntOffsets/${CURRENT_ARCH}\"\n\n/usr/bin/env ruby \"${SRCROOT}/offlineasm/generate_offset_extractor.rb\" \"-I${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\" \"${SRCROOT}/llint/LowLevelInterpreter.asm\" \"${BUILT_PRODUCTS_DIR}/LLIntOffsets/${CURRENT_ARCH}/LLIntDesiredOffsets.h\" \"${ARCHS} C_LOOP\"\n";
> 		};
> 		1A02D9A81B34A882000D1522 /* Add Symlink in /System/Library/PrivateFrameworks */ = {
> 			isa = PBXShellScriptBuildPhase;
>@@ -10660,6 +10660,7 @@
> 			buildSettings = {
> 				HEADER_SEARCH_PATHS = (
> 					"\"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\"",
>+					"\"${BUILT_PRODUCTS_DIR}/LLIntOffsets/${CURRENT_ARCH}\"",
> 					"\"$(JAVASCRIPTCORE_FRAMEWORKS_DIR)/JavaScriptCore.framework/PrivateHeaders\"",
> 					"$(inherited)",
> 				);
>@@ -10672,6 +10673,7 @@
> 			buildSettings = {
> 				HEADER_SEARCH_PATHS = (
> 					"\"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\"",
>+					"\"${BUILT_PRODUCTS_DIR}/LLIntOffsets/${CURRENT_ARCH}\"",
> 					"\"$(JAVASCRIPTCORE_FRAMEWORKS_DIR)/JavaScriptCore.framework/PrivateHeaders\"",
> 					"$(inherited)",
> 				);
>@@ -10684,6 +10686,7 @@
> 			buildSettings = {
> 				HEADER_SEARCH_PATHS = (
> 					"\"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\"",
>+					"\"${BUILT_PRODUCTS_DIR}/LLIntOffsets/${CURRENT_ARCH}\"",
> 					"\"$(JAVASCRIPTCORE_FRAMEWORKS_DIR)/JavaScriptCore.framework/PrivateHeaders\"",
> 					"$(inherited)",
> 				);
>@@ -10696,6 +10699,7 @@
> 			buildSettings = {
> 				HEADER_SEARCH_PATHS = (
> 					"\"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\"",
>+					"\"${BUILT_PRODUCTS_DIR}/LLIntOffsets/${CURRENT_ARCH}\"",
> 					"\"$(JAVASCRIPTCORE_FRAMEWORKS_DIR)/JavaScriptCore.framework/PrivateHeaders\"",
> 					"$(inherited)",
> 				);

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 189274: 348850 | 348858