WebKit Bugzilla
Attachment 348832 Details for
Bug 189264
: Disable WebRTC unified plan runtime flag by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-189264-20180904111824.patch (text/plain), 2.54 KB, created by
youenn fablet
on 2018-09-04 11:18:26 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
youenn fablet
Created:
2018-09-04 11:18:26 PDT
Size:
2.54 KB
patch
obsolete
>Subversion Revision: 235612 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 6a9debe173f93c7b61b65141890cdcdaf53810c9..32e053c24ecb826dce3e6ce70457a2e36d331253 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-09-04 Youenn Fablet <youenn@apple.com> >+ >+ Disable WebRTC unified plan runtime flag by default >+ https://bugs.webkit.org/show_bug.cgi?id=189264 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Covered by existing tests. >+ >+ * testing/Internals.cpp: >+ (WebCore::Internals::resetToConsistentState): >+ Activate unified plan for testing. >+ > 2018-09-04 Youenn Fablet <youenn@apple.com> > > Introduce LibWebRTC backends for sender and receiver >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index bc9f12ba5b3a9de5e3673a68602226172641a680..9ffb7fd3ce9f93ca3e9e5e8f1346965112d5bf64 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,13 @@ >+2018-09-04 Youenn Fablet <youenn@apple.com> >+ >+ Disable WebRTC unified plan runtime flag by default >+ https://bugs.webkit.org/show_bug.cgi?id=189264 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Shared/WebPreferences.yaml: >+ Disable unified plan flag by default. >+ > 2018-09-04 Zan Dobersek <zdobersek@igalia.com> > > REGRESSION(r235165): [GStreamer] Major video performance regression >diff --git a/Source/WebCore/testing/Internals.cpp b/Source/WebCore/testing/Internals.cpp >index f304a446306e8fddf6e1fae198d19ec18f011e53..17c202bb4b3aa8470f47dcde09a12f410d7539c1 100644 >--- a/Source/WebCore/testing/Internals.cpp >+++ b/Source/WebCore/testing/Internals.cpp >@@ -501,6 +501,7 @@ void Internals::resetToConsistentState(Page& page) > auto& rtcProvider = page.libWebRTCProvider(); > WebCore::useRealRTCPeerConnectionFactory(rtcProvider); > rtcProvider.disableNonLocalhostConnections(); >+ RuntimeEnabledFeatures::sharedFeatures().setWebRTCUnifiedPlanEnabled(true); > #endif > > page.settings().setStorageAccessAPIEnabled(false); >diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml >index 94a01eb260e6fe47118818c6c077d9c1b7bf9efc..cebcc763ff65bdb669478bb74bf3907790163f9b 100644 >--- a/Source/WebKit/Shared/WebPreferences.yaml >+++ b/Source/WebKit/Shared/WebPreferences.yaml >@@ -496,7 +496,7 @@ PeerConnectionEnabled: > > WebRTCUnifiedPlanEnabled: > type: bool >- defaultValue: true >+ defaultValue: false > webcoreBinding: RuntimeEnabledFeatures > condition: ENABLE(WEB_RTC) > humanReadableName: "WebRTC Unified Plan"
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189264
: 348832