Attachment 348829 Details for Bug 189211 – Patch

[patch] Patch

bug-189211-20180904111156.patch (text/plain), 7.36 KB, created by Woodrow Wang on 2018-09-04 11:11:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Woodrow Wang

Created: 2018-09-04 11:11:57 PDT

Size: 7.36 KB

patch

obsolete

>Subversion Revision: 235612
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d63bca0e358f679ecc711030661f56a4aae59940..6d91c21c52bc86aad149d3dcb985d4e37ce0f075 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-04  Woodrow Wang  <woodrow_wang@apple.com>
>+
>+        Added runtime feature flag for web API statistics
>+        https://bugs.webkit.org/show_bug.cgi?id=189211
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added functionality to get and set the runtime flag.
>+
>+        * page/RuntimeEnabledFeatures.h:
>+        (WebCore::RuntimeEnabledFeatures::setWebAPIStatisticsEnabled):
>+        (WebCore::RuntimeEnabledFeatures::webAPIStatisticsEnabled const):
>+
> 2018-09-04  Zan Dobersek  <zdobersek@igalia.com> and Ms2ger  <Ms2ger@igalia.com>
> 
>         Implement support for passing ImageBitmap to texImage2D/texSubImage2D
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index bc9f12ba5b3a9de5e3673a68602226172641a680..6d14330c2bbc2cdb6c250f682ab3a6db8567e66f 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-09-04  Woodrow Wang  <woodrow_wang@apple.com>
>+
>+        Added runtime feature flag for web API statistics
>+        https://bugs.webkit.org/show_bug.cgi?id=189211
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added functionality to set the runtime flag with a JavaScript exposed function
>+        for testing.
>+
>+        * Shared/WebPreferences.yaml:
>+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
>+        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
>+
> 2018-09-04  Zan Dobersek  <zdobersek@igalia.com>
> 
>         REGRESSION(r235165): [GStreamer] Major video performance regression
>diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h
>index bc83f8aab8ab1ede7b68a103c4fd0e1f6f93161f..3b2dcad7f5efe0e4e3b6bb12a26acf52df40d394 100644
>--- a/Source/WebCore/page/RuntimeEnabledFeatures.h
>+++ b/Source/WebCore/page/RuntimeEnabledFeatures.h
>@@ -285,6 +285,9 @@ public:
>     void setAttrStyleEnabled(bool isEnabled) { m_attrStyleEnabled = isEnabled; }
>     bool attrStyleEnabled() const { return m_attrStyleEnabled; }
> 
>+    void setWebAPIStatisticsEnabled(bool isEnabled) { m_webAPIStatisticsEnabled = isEnabled; }
>+    bool webAPIStatisticsEnabled() const { return m_webAPIStatisticsEnabled; }
>+
>     WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures();
> 
> private:
>@@ -429,6 +432,8 @@ private:
> 
>     bool m_attrStyleEnabled { false };
> 
>+    bool m_webAPIStatisticsEnabled { false };
>+
>     friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>;
> };
> 
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 94a01eb260e6fe47118818c6c077d9c1b7bf9efc..8c9aaeeec2237aa3f2497963357c3a443be4fbcb 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1331,3 +1331,11 @@ SourceBufferChangeTypeEnabled:
>   humanReadableDescription: "Enable Media Source Codec Switching through changeType()"
>   category: experimental
>   condition: ENABLE(MEDIA_SOURCE)
>+
>+WebAPIStatisticsEnabled:
>+  type: bool
>+  defaultValue: false
>+  humanReadableName: "Web API Statistics"
>+  humanReadableDescription: "Enable Web API Statistics"
>+  webcoreBinding: RuntimeEnabledFeatures
>+  category: experimental
>diff --git a/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp b/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
>index ff0e185d08aa30e4c12789b7e88a33dc1965cf47..8d681fe478513abef8609d03f27b5736ab4a38e0 100644
>--- a/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
>+++ b/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
>@@ -250,6 +250,9 @@ void InjectedBundle::overrideBoolPreferenceForTestRunner(WebPageGroupProxy* page
>         RuntimeEnabledFeatures::sharedFeatures().setIsSecureContextAttributeEnabled(enabled);
>     }
> 
>+    if (preference == "WebKitWebAPIStatisticsEnabled")
>+        RuntimeEnabledFeatures::sharedFeatures().setWebAPIStatisticsEnabled(enabled);
>+
>     // Map the names used in LayoutTests with the names used in WebCore::Settings and WebPreferencesStore.
> #define FOR_EACH_OVERRIDE_BOOL_PREFERENCE(macro) \
>     macro(WebKitJavaEnabled, JavaEnabled, javaEnabled) \
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a7c767edab5a25851e809c2c8c46d355f30a4672..14c204b4abc7fa2bffe4ee11dabfefa6188837db 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-04  Woodrow Wang  <woodrow_wang@apple.com>
>+
>+        Added runtime feature flag for web API statistics
>+        https://bugs.webkit.org/show_bug.cgi?id=189211
>+
>+        Added functionality to set the runtime flag with a JavaScript exposed function
>+        for testing.
>+
>+        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
>+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
>+        (WTR::TestRunner::setWebAPIStatisticsEnabled):
>+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
>+
> 2018-09-03  Pablo Saavedra  <psaavedra@igalia.com>
> 
>         [WPE] Add more WPE bots to dashboard
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl b/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
>index a46c46e5b0f94533ff4511f298ea93fab32b4d07..2981aba723168e35e2ff4ab6436b96d7dbb96a79 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
>+++ b/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
>@@ -324,6 +324,8 @@ interface TestRunner {
>     void setWebRTCUnifiedPlanEnabled(boolean value);
>     void setCustomUserAgent(DOMString userAgent);
> 
>+    void setWebAPIStatisticsEnabled(boolean value);
>+
>     void terminateNetworkProcess();
>     void terminateServiceWorkerProcess();
>     void terminateStorageProcess();
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp b/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
>index d4bcaaef023ac95122c1ef720c712d19c6ae20ba..344d5af1c57c6877fddf2ec47c92dde353b1ebcd 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
>+++ b/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
>@@ -455,6 +455,13 @@ void TestRunner::setCustomUserAgent(JSStringRef userAgent)
>     WKBundlePostSynchronousMessage(InjectedBundle::singleton().bundle(), messageName.get(), toWK(userAgent).get(), nullptr);
> }
> 
>+void TestRunner::setWebAPIStatisticsEnabled(bool enabled)
>+{
>+    WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitWebAPIStatisticsEnabled"));
>+    auto& injectedBundle = InjectedBundle::singleton();
>+    WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
>+}
>+
> void TestRunner::setModernMediaControlsEnabled(bool enabled)
> {
>     WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitModernMediaControlsEnabled"));
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h b/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
>index bb7a0cfd4e95873cecd2cee69159ad0cd79c1c8c..bfd928ef07c5582f7fd9e395b26a444c9c32e343 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
>+++ b/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
>@@ -133,6 +133,7 @@ public:
>     void setMDNSICECandidatesEnabled(bool);
>     void setWebRTCUnifiedPlanEnabled(bool);
>     void setCustomUserAgent(JSStringRef);
>+    void setWebAPIStatisticsEnabled(bool);
> 
>     // Special DOM functions.
>     void clearBackForwardList();

Flags:

dbates: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189211: 348673 | 348829 | 348931