Attachment 348824 Details for Bug 189261 – Patch

[patch] Patch

bug-189261-20180904101623.patch (text/plain), 1.11 KB, created by Keith Miller on 2018-09-04 10:16:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2018-09-04 10:16:24 PDT

Size: 1.11 KB

patch

obsolete

>Subversion Revision: 235612
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a7c767edab5a25851e809c2c8c46d355f30a4672..ac368ab3af2f6a6dc96e0e5ee8881744cc0da0bf 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-09-04  Keith Miller  <keith_miller@apple.com>
>+
>+        Perl doesn't like calling keys on a reference
>+        https://bugs.webkit.org/show_bug.cgi?id=189261
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262/Runner.pm:
>+        (UpdateResults):
>+
> 2018-09-03  Pablo Saavedra  <psaavedra@igalia.com>
> 
>         [WPE] Add more WPE bots to dashboard
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index f4cd5eecf28b9cd09194653ae9d903a1076c899f..b5a7aabfe5879374f324f200bf5cdff0e9307eb5 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -926,7 +926,7 @@ sub UpdateResults {
>         delete $expect->{$test->{path}};
>     }
> 
>-    foreach my $path (keys($expect)) {
>+    foreach my $path (keys(%{$expect})) {
>         foreach my $mode (keys($expect->{$path})) {
>             my $test = {
>                 path => $path,

Flags:

msaboff: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 189261: 348824 | 348831