Attachment 348774 Details for Bug 189224 – Patch

[patch] Patch

bug-189224-20180903180722.patch (text/plain), 2.22 KB, created by Zan Dobersek on 2018-09-03 09:07:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2018-09-03 09:07:24 PDT

Size: 2.22 KB

patch

obsolete

>Subversion Revision: 235590
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a4397d2fd644ffd11e207a299e4392c493217a05..db07db05495e7738b93c316a8befd1d6edd95cef 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-09-03  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        REGRESSION(r235165): [GStreamer] Major video performance regression
>+        https://bugs.webkit.org/show_bug.cgi?id=189224
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
>+        (WebKit::CoordinatedGraphicsScene::updateSceneState): Drop the early
>+        return used when the scene state wasn't updated through a layer flush,
>+        and instead always run through layer changes and backings. This way we
>+        won't miss proxy objects that need swapping even if none of the layer
>+        states were changed. Reducing the amount of work done here when scene
>+        hasn't been updated might be possible, but it's not a huge bottleneck.
>+
> 2018-09-01  Darin Adler  <darin@apple.com>
> 
>         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
>diff --git a/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp b/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp
>index 2fe66aeb7c277f6afae5e0f625cb213775742120..b5aeadeba4e2ec321fefc34ac77be800d75f0051 100644
>--- a/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp
>+++ b/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp
>@@ -259,9 +259,9 @@ void CoordinatedGraphicsScene::updateSceneState()
>     m_nicosia.scene->accessState(
>         [this, &layersByBacking](Nicosia::Scene::State& state)
>         {
>-            // Bail if the scene didn't change.
>-            if (state.id == m_nicosia.state.id)
>-                return;
>+            // FIXME: try to minimize the amount of work in case the Scene::State object
>+            // didn't change (i.e. no layer flush was done), but don't forget to properly
>+            // gather and update proxy objects for content layers.
> 
>             // Handle the root layer, adding it to the TextureMapperLayer tree
>             // on the first update. No such change is expected later.

Actions: View | Formatted Diff | Diff

Attachments on bug 189224: 348774