Attachment 348767 Details for Bug 189243 – [WPE][GTK] Add more unused result warnings to JSC API

[patch] [WPE][GTK] Add more unused result warnings to JSC API

bug-189243-20180903080441.patch (text/plain), 2.65 KB, created by Michael Catanzaro on 2018-09-03 06:04:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-09-03 06:04:42 PDT

Size: 2.65 KB

patch

obsolete

>Subversion Revision: 235563
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 4d5e2e36ff39eb349b80e45070cd2547f9139fdc..95d282e89cd1508de5e5684d054db23a4ff351eb 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-09-03  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [WPE][GTK] Add more unused result warnings to JSC API
>+        https://bugs.webkit.org/show_bug.cgi?id=189243
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The jsc_context_evaluate() family of functions has a (transfer full) return value, but the
>+        caller may be tempted to not inspect it if uninterested in the return value. This would be
>+        an error, because it must be freed.
>+
>+        * API/glib/JSCContext.h:
>+
> 2018-08-31  Mark Lam  <mark.lam@apple.com>
> 
>         Fix exception check accounting in constructJSWebAssemblyCompileError().
>diff --git a/Source/JavaScriptCore/API/glib/JSCContext.h b/Source/JavaScriptCore/API/glib/JSCContext.h
>index e46494e38495f2dd3d1c77050a15bceffa3e9b59..0673ffa589be565024514206a475b7d645120131 100644
>--- a/Source/JavaScriptCore/API/glib/JSCContext.h
>+++ b/Source/JavaScriptCore/API/glib/JSCContext.h
>@@ -135,14 +135,14 @@ jsc_context_get_current              (void);
> JSC_API JSCValue *
> jsc_context_evaluate                 (JSCContext         *context,
>                                       const char         *code,
>-                                      gssize              length);
>+                                      gssize              length) G_GNUC_WARN_UNUSED_RESULT;
> 
> JSC_API JSCValue *
> jsc_context_evaluate_with_source_uri (JSCContext         *context,
>                                       const char         *code,
>                                       gssize              length,
>                                       const char         *uri,
>-                                      guint               line_number);
>+                                      guint               line_number) G_GNUC_WARN_UNUSED_RESULT;
> 
> JSC_API JSCValue *
> jsc_context_evaluate_in_object       (JSCContext         *context,
>@@ -152,7 +152,7 @@ jsc_context_evaluate_in_object       (JSCContext         *context,
>                                       JSCClass           *object_class,
>                                       const char         *uri,
>                                       guint               line_number,
>-                                      JSCValue          **object);
>+                                      JSCValue          **object) G_GNUC_WARN_UNUSED_RESULT;
> 
> JSC_API JSCCheckSyntaxResult
> jsc_context_check_syntax             (JSCContext         *context,

Actions: View | Formatted Diff | Diff

Attachments on bug 189243: 348767