Attachment 348715 Details for Bug 189221 – Patch

[patch] Patch

bug-189221-20180901114212.patch (text/plain), 4.17 KB, created by Simon Fraser (smfr) on 2018-09-01 11:42:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2018-09-01 11:42:13 PDT

Size: 4.17 KB

patch

obsolete

>Subversion Revision: 235579
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7de7e235a48bda373f93e195782d7c7829e12dbb..c0f255ee662dddf497a1f265765ec3f9388c9f64 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-09-01  Simon Fraser  <simon.fraser@apple.com>
>+
>+        Add some more filter logging
>+        https://bugs.webkit.org/show_bug.cgi?id=189221
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add logging in FilterEffect::apply() that shows all the filter rects, and logging
>+        that brackets the application of a whole filter chain, for both SVG and CSS filters.
>+
>+        * platform/graphics/filters/FilterEffect.cpp:
>+        (WebCore::FilterEffect::apply):
>+        * rendering/FilterEffectRenderer.cpp:
>+        (WebCore::FilterEffectRendererHelper::applyFilterEffect):
>+        * rendering/svg/RenderSVGResourceFilter.cpp:
>+        (WebCore::RenderSVGResourceFilter::postApplyResource):
>+
> 2018-08-31  Youenn Fablet  <youenn@apple.com>
> 
>         Move stats gathering out of LibWebRTCMediaEndpoint
>diff --git a/Source/WebCore/platform/graphics/filters/FilterEffect.cpp b/Source/WebCore/platform/graphics/filters/FilterEffect.cpp
>index dcd98a671a74754dad0f89a7ab642bbc73caa632..7b071fc09161bbe23e620a8fe363f53cbd5c2c3c 100644
>--- a/Source/WebCore/platform/graphics/filters/FilterEffect.cpp
>+++ b/Source/WebCore/platform/graphics/filters/FilterEffect.cpp
>@@ -135,6 +135,8 @@ void FilterEffect::apply()
>     determineAbsolutePaintRect();
>     setResultColorSpace(m_operatingColorSpace);
> 
>+    LOG_WITH_STREAM(Filters, stream << "FilterEffect " << filterName() << " " << this << " apply():\n  filterPrimitiveSubregion " << m_filterPrimitiveSubregion << "\n  effectBoundaries " << m_effectBoundaries << "\n  absoluteUnclippedSubregion " << m_absoluteUnclippedSubregion << "\n  absolutePaintRect " << m_absolutePaintRect << "\n  maxEffectRect " << m_maxEffectRect << "\n  filter scale " << m_filter.filterScale() << "\n  filter resolution " << m_filter.filterResolution());
>+
>     if (m_absolutePaintRect.isEmpty() || ImageBuffer::sizeNeedsClamping(m_absolutePaintRect.size()))
>         return;
> 
>diff --git a/Source/WebCore/rendering/FilterEffectRenderer.cpp b/Source/WebCore/rendering/FilterEffectRenderer.cpp
>index d6fa9957d942d1d9b2559ca04960c82f8cdbd4c8..8bf7ae45265ad697f510dd0b47109e0bd33bdcda 100644
>--- a/Source/WebCore/rendering/FilterEffectRenderer.cpp
>+++ b/Source/WebCore/rendering/FilterEffectRenderer.cpp
>@@ -35,6 +35,7 @@
> #include "FEDropShadow.h"
> #include "FEGaussianBlur.h"
> #include "FEMerge.h"
>+#include "Logging.h"
> #include "RenderLayer.h"
> #include "SVGElement.h"
> #include "SVGFilterBuilder.h"
>@@ -458,6 +459,8 @@ void FilterEffectRendererHelper::applyFilterEffect(GraphicsContext& destinationC
>     ASSERT(m_renderLayer->filterRenderer());
>     ASSERT(m_renderLayer->filterRenderer()->inputContext());
> 
>+    LOG_WITH_STREAM(Filters, stream << "\nFilterEffectRendererHelper " << this << " applyFilterEffect");
>+
>     auto& filter = *m_renderLayer->filterRenderer();
>     filter.inputContext()->restore();
> 
>@@ -471,6 +474,8 @@ void FilterEffectRendererHelper::applyFilterEffect(GraphicsContext& destinationC
>         destinationContext.drawImageBuffer(*outputBuffer, snapRectToDevicePixels(destRect, m_renderLayer->renderer().document().deviceScaleFactor()));
> 
>     filter.clearIntermediateResults();
>+
>+    LOG_WITH_STREAM(Filters, stream << "FilterEffectRendererHelper " << this << " applyFilterEffect done\n");
> }
> 
> } // namespace WebCore
>diff --git a/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp b/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
>index 069a07cdd9ef5b5afec7104eb88009bd7bf4e679..26faf73f2b752334560b2f5e340546a5d1594083 100644
>--- a/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
>+++ b/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
>@@ -297,6 +297,8 @@ void RenderSVGResourceFilter::postApplyResource(RenderElement& renderer, Graphic
>         }
>     }
>     filterData.sourceGraphicBuffer.reset();
>+
>+    LOG_WITH_STREAM(Filters, stream << "RenderSVGResourceFilter " << this << " postApplyResource done\n");
> }
> 
> FloatRect RenderSVGResourceFilter::resourceBoundingBox(const RenderObject& object)

Actions: View | Formatted Diff | Diff

Attachments on bug 189221: 348715