Attachment 348710 Details for Bug 189144 – WIP6

[patch] WIP6

wip189144f.patch (text/plain), 40.51 KB, created by Ryosuke Niwa on 2018-09-01 00:55:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-09-01 00:55:46 PDT

Size: 40.51 KB

patch

obsolete

>Index: LayoutTests/fast/shadow-dom/slotchange-for-slot-mutation-expected.txt
>===================================================================
>--- LayoutTests/fast/shadow-dom/slotchange-for-slot-mutation-expected.txt	(nonexistent)
>+++ LayoutTests/fast/shadow-dom/slotchange-for-slot-mutation-expected.txt	(working copy)
>@@ -0,0 +1,61 @@
>+
>+PASS slotchange event should not fire when inserting a default slot element into a shadow host with no children in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a named slot element into a shadow host with no children in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a default slot element when there is an element assigned to another slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting a default slot element when there is an element assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting a default slot element when there is a Text node assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a named slot element when there is an element assigned to another slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a named slot element when there is an element assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting a named slot element when there is an element assigned to the slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a named slot element when there is a Text node assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a default slot element after an existing default slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting a default slot element before an existing default slot in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a default slot element between two existing default slots in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a named slot element after an existing slot of the same name in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting a named slot element before an existing slot of the same name in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when inserting a named slot element between two existing slots of the same name in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting the ancestor of a default slot element before an existing default slot in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting the ancestor of a named slot element before an existing named slot element in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on the first default slot inserted in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on the first named slot inserted in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on the first named slot of the same name inserted in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting a named slot element before an existing slot of the same name before a default slot in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on all newly inserted slots with assigned nodes and their previously-first counterparts in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on all newly inserted slots with assigned nodes but not on those without in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a default slot element into a shadow host with no children in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a named slot element into a shadow host with no children in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a default slot element when there is an element assigned to another slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when removing a default slot element when there is an element assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when removing a default slot element when there is a Text node assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a named slot element when there is an element assigned to another slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a named slot element when there is an element assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when removing a named slot element when there is an element assigned to the slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a named slot element when there is a Text node assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a default slot element after an existing default slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when removing the first default slot element even if it had duplicates in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a duplicate default slot, which is the first child of a default slot element in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a named slot element after an existing named slot of the same name in a disconnected open mode shadow root 
>+PASS slotchange event should fire when removing the first named slot element even if it had duplicates in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when removing a duplicate named slot, which is the first child of a named slot element of the same name in a disconnected open mode shadow root 
>+PASS slotchange event should fire when removing the ancestor of a default slot element before another default slot in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire when removing the ancestor of a named slot element before another slot of the same name in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on the first default slot removed in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on the first named slot removed in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on the first default slot removed in the tree order when replacing all children in a disconnected open mode shadow root 
>+PASS slotchange event should fire on the first default slot removed in the tree order when replacing all children in a disconnected open mode shadow root 
>+PASS slotchange event should fire on the first named slot of the same name removed in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire when inserting a named slot element before an existing slot of the same name before a default slot in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on all first slots of its kind with assigned nodes and their previously-first counterparts in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should fire on all removed slots with assigned nodes but not on those without in the tree order in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when renaming a default slot element to a named slot when there are no assigned nodes in a disconnected open mode shadow root 
>+PASS slotchange event should fire when renaming a default slot element to a named slot when there is an assigned node to the named slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when renaming a default slot element to a named slot when there is an assigned node to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when renaming a named slot element to a default slot when there are no assigned nodes in a disconnected open mode shadow root 
>+PASS slotchange event should fire when renaming a named slot element to a default slot when there is a node assigned to the default slot in a disconnected open mode shadow root 
>+PASS slotchange event should fire when renaming a named slot element to a default slot when there is a node assigned to the named slot in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when renaming a named slot element when there are no assigned nodes in a disconnected open mode shadow root 
>+PASS slotchange event should fire when renaming a named slot element when there is an assigned node to the slot of the new name in a disconnected open mode shadow root 
>+PASS slotchange event should fire when renaming a named slot element when there is an assigned node to the slot of the old name in a disconnected open mode shadow root 
>+PASS slotchange event should not fire when renaming the second slot element of a given name and there is no assigned node of the new name in a disconnected open mode shadow root 
>+FAIL slotchange event should fire when renaming the slot element of a given name and there is an assigned node and a second slot element in a disconnected open mode shadow root assert_array_equals: property 0, expected "slot1" but got "slot2"
>+
>Index: LayoutTests/fast/shadow-dom/slotchange-for-slot-mutation.html
>===================================================================
>--- LayoutTests/fast/shadow-dom/slotchange-for-slot-mutation.html	(nonexistent)
>+++ LayoutTests/fast/shadow-dom/slotchange-for-slot-mutation.html	(working copy)
>@@ -0,0 +1,295 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<title>Shadow DOM: slotchange event when inserting or removing a slot element</title>
>+<meta name="author" title="Ryosuke Niwa" href="mailto:rniwa@webkit.org">
>+<link rel="help" href="https://dom.spec.whatwg.org/#signaling-slot-change">
>+<link rel="help" href="https://dom.spec.whatwg.org/#concept-node-insert">
>+<script src="../../resources/testharness.js"></script>
>+<script src="../../resources/testharnessreport.js"></script>
>+</head>
>+<body>
>+<div id="log"></div>
>+<script>
>+
>+function generateTests(...args) {
>+/* testMutatingSlot('closed', true, ...args);
>+ testMutatingSlot('closed', false, ...args);
>+ testMutatingSlot('open', true, ...args);*/
>+ testMutatingSlot('open', false, ...args);
>+}
>+
>+let slotchangeEventTargets;
>+function testMutatingSlot(mode, connectedToDocument, hostContent, shadowContent, mutateSlot, expectedTargets, description)
>+{
>+ promise_test(async function () {
>+ const host = document.createElement('div');
>+ if (connectedToDocument)
>+ document.body.appendChild(host);
>+ if (hostContent)
>+ host.innerHTML = hostContent;
>+
>+ const shadowRoot = host.attachShadow({mode});
>+ slotchangeEventTargets = [];
>+ if (shadowContent) {
>+ shadowRoot.innerHTML = shadowContent;
>+ addEventListners(shadowRoot);
>+ }
>+
>+ await Promise.resolve();
>+ slotchangeEventTargets.length = 0;
>+
>+ mutateSlot(shadowRoot);
>+ await Promise.resolve();
>+
>+ assert_array_equals(slotchangeEventTargets, expectedTargets);
>+
>+ host.remove();
>+ }, description + ` in a ${connectedToDocument ? 'connected' : 'disconnected'} ${mode} mode shadow root`);
>+}
>+
>+function addEventListners(container)
>+{
>+ for (const existingSlots of container.querySelectorAll('slot'))
>+ existingSlots.addEventListener('slotchange', (event) => slotchangeEventTargets.push(event.target.id));
>+}
>+
>+function newSlot(slotName)
>+{
>+ const slot = document.createElement('slot');
>+ slot.id = 'newSlot';
>+ if (slotName)
>+ slot.name = slotName;
>+ slot.addEventListener('slotchange', (event) => slotchangeEventTargets.push(event.target.id));
>+ return slot;
>+}
>+
>+// Insertions
>+
>+generateTests(null, null, (shadowRoot) => shadowRoot.append(newSlot()), [],
>+ 'slotchange event should not fire when inserting a default slot element into a shadow host with no children');
>+generateTests(null, null, (shadowRoot) => shadowRoot.append(newSlot('foo')), [],
>+ 'slotchange event should not fire when inserting a named slot element into a shadow host with no children');
>+
>+generateTests('', null, (shadowRoot) => shadowRoot.append(newSlot()), [],
>+ 'slotchange event should not fire when inserting a default slot element when there is an element assigned to another slot');
>+generateTests('', null, (shadowRoot) => shadowRoot.append(newSlot()), ['newSlot'],
>+ 'slotchange event should fire when inserting a default slot element when there is an element assigned to the default slot');
>+generateTests('hello', null, (shadowRoot) => shadowRoot.append(newSlot()), ['newSlot'],
>+ 'slotchange event should fire when inserting a default slot element when there is a Text node assigned to the default slot');
>+
>+generateTests('', null, (shadowRoot) => shadowRoot.append(newSlot('foo')), [],
>+ 'slotchange event should not fire when inserting a named slot element when there is an element assigned to another slot');
>+generateTests('', null, (shadowRoot) => shadowRoot.append(newSlot('foo')), [],
>+ 'slotchange event should not fire when inserting a named slot element when there is an element assigned to the default slot');
>+generateTests('', null, (shadowRoot) => shadowRoot.append(newSlot('foo')), ['newSlot'],
>+ 'slotchange event should fire when inserting a named slot element when there is an element assigned to the slot');
>+generateTests('hello', null, (shadowRoot) => shadowRoot.append(newSlot('foo')), [],
>+ 'slotchange event should not fire when inserting a named slot element when there is a Text node assigned to the default slot');
>+
>+generateTests('', '<slot id="oldSlot"></slot>',
>+ (shadowRoot) => shadowRoot.append(newSlot()), [],
>+ 'slotchange event should not fire when inserting a default slot element after an existing default slot');
>+generateTests('', '<slot id="oldSlot"></slot>',
>+ (shadowRoot) => shadowRoot.prepend(newSlot()), ['newSlot', 'oldSlot'],
>+ 'slotchange event should fire when inserting a default slot element before an existing default slot in the tree order');
>+generateTests('', '<slot id="oldSlot1"></slot><slot id="oldSlot2"></slot>',
>+ (shadowRoot) => shadowRoot.firstChild.after(newSlot()), [],
>+ 'slotchange event should not fire when inserting a default slot element between two existing default slots');
>+
>+generateTests('', '<slot id="oldSlot" name="foo"></slot>',
>+ (shadowRoot) => shadowRoot.append(newSlot('foo')), [],
>+ 'slotchange event should not fire when inserting a named slot element after an existing slot of the same name');
>+generateTests('', '<slot id="oldSlot" name="foo"></slot>',
>+ (shadowRoot) => shadowRoot.prepend(newSlot('foo')), ['newSlot', 'oldSlot'],
>+ 'slotchange event should fire when inserting a named slot element before an existing slot of the same name in the tree order');
>+generateTests('', '<slot id="oldSlot1" name="foo"></slot><slot id="oldSlot2" name="foo"></slot>',
>+ (shadowRoot) => shadowRoot.firstChild.after(newSlot('foo')), [],
>+ 'slotchange event should not fire when inserting a named slot element between two existing slots of the same name');
>+
>+generateTests('', '<div><slot id="oldSlot"></slot></div>',
>+ (shadowRoot) => {
>+ const ancestor = document.createElement('div');
>+ ancestor.innerHTML = '<slot id="newSlot"></slot>';
>+ addEventListners(ancestor);
>+ shadowRoot.prepend(ancestor);
>+ }, ['newSlot', 'oldSlot'],
>+ 'slotchange event should fire when inserting the ancestor of a default slot element before an existing default slot in the tree order');
>+generateTests('', '<div><slot name="foo" id="oldSlot"></slot></div>',
>+ (shadowRoot) => {
>+ const ancestor = document.createElement('div');
>+ ancestor.innerHTML = '<slot id="newSlot" name="foo"></slot>';
>+ addEventListners(ancestor);
>+ shadowRoot.prepend(ancestor);
>+ }, ['newSlot', 'oldSlot'],
>+ 'slotchange event should fire when inserting the ancestor of a named slot element before an existing named slot element in the tree order');
>+
>+generateTests('', null,
>+ (shadowRoot) => {
>+ const ancestor = document.createElement('div');
>+ ancestor.innerHTML = '<slot id="slot1"></slot><slot id="slot2"></slot><slot id="slot3"></slot>';
>+ addEventListners(ancestor);
>+ shadowRoot.append(ancestor);
>+ }, ['slot1'],
>+ 'slotchange event should fire on the first default slot inserted in the tree order');
>+generateTests('', null,
>+ (shadowRoot) => {
>+ const ancestor = document.createElement('div');
>+ ancestor.innerHTML = '<slot id="slot1" name="foo"></slot><slot id="slot2" name="foo"></slot><slot id="slot3" name="foo"></slot>';
>+ addEventListners(ancestor);
>+ shadowRoot.append(ancestor);
>+ }, ['slot1'],
>+ 'slotchange event should fire on the first named slot inserted in the tree order');
>+
>+generateTests('', null,
>+ (shadowRoot) => {
>+ const ancestor = document.createElement('div');
>+ ancestor.innerHTML = '<slot id="slot1" name="a"></slot><slot id="slot2" name="b"></slot><slot id="slot3" name="b"></slot>';
>+ addEventListners(ancestor);
>+ shadowRoot.append(ancestor);
>+ }, ['slot2'],
>+ 'slotchange event should fire on the first named slot of the same name inserted in the tree order');
>+
>+generateTests('', '<slot id="oldSlot" name="a"></slot><slot></slot>',
>+ (shadowRoot) => shadowRoot.prepend(newSlot('a')), ['newSlot', 'oldSlot'],
>+ 'slotchange event should fire when inserting a named slot element before an existing slot of the same name before a default slot in the tree order');
>+
>+generateTests('', '<slot id="oldDefault"></slot><slot id="oldA" name="a"></slot>',
>+ (shadowRoot) => {
>+ const ancestor = document.createElement('div');
>+ ancestor.innerHTML = `<slot id="newDefault1"></slot><slot id="newDefault2"></slot><slot id="newB" name="b"></slot><slot id="newA" name="a"></slot>`;
>+ addEventListners(ancestor);
>+ shadowRoot.prepend(ancestor);
>+ }, ['newDefault1', 'newA', 'oldDefault', 'oldA'],
>+ 'slotchange event should fire on all newly inserted slots with assigned nodes and their previously-first counterparts in the tree order');
>+
>+generateTests('', '<slot id="oldDefault"></slot><slot id="oldA" name="a"></slot><slot id="oldB" name="b"></slot>',
>+ (shadowRoot) => {
>+ const ancestor = document.createElement('div');
>+ ancestor.innerHTML = `<slot id="newDefault1"></slot><slot id="newDefault2"></slot><slot id="newB" name="b"></slot><slot id="newA" name="a"></slot>`;
>+ addEventListners(ancestor);
>+ shadowRoot.prepend(ancestor);
>+ }, ['newDefault1', 'newA', 'oldDefault', 'oldA'],
>+ 'slotchange event should fire on all newly inserted slots with assigned nodes but not on those without in the tree order');
>+
>+
>+// Removals
>+
>+generateTests(null, '<slot id="oldSlot"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), [],
>+ 'slotchange event should not fire when removing a default slot element into a shadow host with no children');
>+generateTests(null, '<slot id="oldSlot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), [],
>+ 'slotchange event should not fire when removing a named slot element into a shadow host with no children');
>+
>+generateTests('', '<slot id="oldSlot"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), [],
>+ 'slotchange event should not fire when removing a default slot element when there is an element assigned to another slot');
>+generateTests('', '<slot id="oldSlot"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), ['oldSlot'],
>+ 'slotchange event should fire when removing a default slot element when there is an element assigned to the default slot');
>+generateTests('hello', '<slot id="oldSlot"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), ['oldSlot'],
>+ 'slotchange event should fire when removing a default slot element when there is a Text node assigned to the default slot');
>+
>+generateTests('', '<slot id="oldSlot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), [],
>+ 'slotchange event should not fire when removing a named slot element when there is an element assigned to another slot');
>+generateTests('', '<slot id="oldSlot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), [],
>+ 'slotchange event should not fire when removing a named slot element when there is an element assigned to the default slot');
>+generateTests('', '<slot id="oldSlot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), ['oldSlot'],
>+ 'slotchange event should fire when removing a named slot element when there is an element assigned to the slot');
>+generateTests('hello', '<slot id="oldSlot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').remove(), [],
>+ 'slotchange event should not fire when removing a named slot element when there is a Text node assigned to the default slot');
>+
>+generateTests('', '<slot id="slot1"></slot><slot id="slot2"></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('slot2').remove(), [],
>+ 'slotchange event should not fire when removing a default slot element after an existing default slot');
>+generateTests('', '<slot id="slot1"></slot><slot id="slot2"></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('slot1').remove(), ['slot2', 'slot1'],
>+ 'slotchange event should fire when removing the first default slot element even if it had duplicates');
>+generateTests('', '<slot id="slot1"><slot id="slot2"></slot></slot><slot id="slot3"></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('slot2').remove(), [],
>+ 'slotchange event should not fire when removing a duplicate default slot, which is the first child of a default slot element');
>+
>+generateTests('', '<slot id="slot1" name="foo"></slot><slot id="slot2" name="foo"></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('slot2').remove(), [],
>+ 'slotchange event should not fire when removing a named slot element after an existing named slot of the same name');
>+generateTests('', '<slot id="slot1" name="foo"></slot><slot id="slot2" name="foo"></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('slot1').remove(), ['slot2', 'slot1'],
>+ 'slotchange event should fire when removing the first named slot element even if it had duplicates');
>+generateTests('', '<slot id="slot1" name="foo"><slot id="slot2" name="foo"></slot></slot><slot id="slot3" name="foo"></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('slot2').remove(), [],
>+ 'slotchange event should not fire when removing a duplicate named slot, which is the first child of a named slot element of the same name');
>+
>+generateTests('', '<div><slot id="slot1"></slot></div><slot id="slot2"></slot>',
>+ (shadowRoot) => shadowRoot.querySelector('div').remove(), ['slot2', 'slot1'],
>+ 'slotchange event should fire when removing the ancestor of a default slot element before another default slot in the tree order');
>+generateTests('', '<div><slot id="slot1"></slot></div><slot id="slot2"></slot>',
>+ (shadowRoot) => shadowRoot.querySelector('div').remove(), ['slot2', 'slot1'],
>+ 'slotchange event should fire when removing the ancestor of a named slot element before another slot of the same name in the tree order');
>+
>+generateTests('', '<div><slot id="slot1"></slot><slot id="slot2"></slot><slot id="slot3"></slot></div>',
>+ (shadowRoot) => shadowRoot.querySelector('p').remove(), ['slot1'],
>+ 'slotchange event should fire on the first default slot removed in the tree order');
>+generateTests('',
>+ '<div><slot id="slot1" name="foo"></slot><slot id="slot2" name="foo"></slot><slot id="slot3" name="foo"></slot></div>',
>+ (shadowRoot) => shadowRoot.querySelector('p').remove(), ['slot1'],
>+ 'slotchange event should fire on the first named slot removed in the tree order');
>+
>+generateTests('', '<div><slot id="slot1"></slot><slot id="slot2"></slot><slot id="slot3"></slot></div>',
>+ (shadowRoot) => shadowRoot.querySelector('p').textContent = '', ['slot1'],
>+ 'slotchange event should fire on the first default slot removed in the tree order when replacing all children');
>+
>+generateTests('', '<div><slot id="slot1"></slot><slot id="slot2"></slot><slot id="slot3"></slot></div>',
>+ (shadowRoot) => shadowRoot.querySelector('p').textContent = '', ['slot1'],
>+ 'slotchange event should fire on the first default slot removed in the tree order when replacing all children');
>+
>+generateTests('',
>+ '<slot id="slot1" name="a"></slot><slot id="slot2" name="b"></slot><slot id="slot3" name="b"></slot>',
>+ (shadowRoot) => shadowRoot.querySelector('p').remove(), ['slot2'],
>+ 'slotchange event should fire on the first named slot of the same name removed in the tree order');
>+
>+generateTests('', '<slot id="a1" name="a"></slot><slot id="a2" name="a"></slot><slot></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('a1').remove(), ['a2', 'a1'],
>+ 'slotchange event should fire when inserting a named slot element before an existing slot of the same name before a default slot in the tree order');
>+
>+generateTests('', '<slot id="default1"></slot><slot id="b1" name="b"></slot>'
>+ + '<slot id="a1" name="a"></slot><slot id="default2"></slot><slot id="a2" name="a"></slot>',
>+ (shadowRoot) => shadowRoot.querySelector('span').remove(), ['default2', 'a2', 'default1', 'a1'],
>+ 'slotchange event should fire on all first slots of its kind with assigned nodes and their previously-first counterparts in the tree order');
>+
>+generateTests('', '<slot id="default1"></slot><slot id="default2"></slot>'
>+ + '<slot id="b1" name="b"></slot><slot id="a1" name="a"></slot>'
>+ + '<slot id="default3"></slot><slot id="a2" name="a"></slot><slot id="b2" name="b"></slot>',
>+ (shadowRoot) => shadowRoot.querySelector('span').remove(), ['default3', 'a2', 'default1', 'a1'],
>+ 'slotchange event should fire on all removed slots with assigned nodes but not on those without in the tree order');
>+
>+
>+// Changing the name
>+
>+generateTests(null, '<slot id="slot"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = 'foo', [],
>+ 'slotchange event should not fire when renaming a default slot element to a named slot when there are no assigned nodes');
>+generateTests('', '<slot id="slot"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = 'foo', ['slot'],
>+ 'slotchange event should fire when renaming a default slot element to a named slot when there is an assigned node to the named slot');
>+generateTests('hello', '<slot id="slot"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = 'foo', ['slot'],
>+ 'slotchange event should fire when renaming a default slot element to a named slot when there is an assigned node to the default slot');
>+
>+generateTests(null, '<slot id="slot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = null, [],
>+ 'slotchange event should not fire when renaming a named slot element to a default slot when there are no assigned nodes');
>+generateTests('', '<slot id="slot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = '', ['slot'],
>+ 'slotchange event should fire when renaming a named slot element to a default slot when there is a node assigned to the default slot');
>+generateTests('', '<slot id="slot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = '', ['slot'],
>+ 'slotchange event should fire when renaming a named slot element to a default slot when there is a node assigned to the named slot');
>+
>+generateTests(null, '<slot id="slot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = 'bar', [],
>+ 'slotchange event should not fire when renaming a named slot element when there are no assigned nodes');
>+generateTests('', '<slot id="slot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = 'bar', ['slot'],
>+ 'slotchange event should fire when renaming a named slot element when there is an assigned node to the slot of the new name');
>+generateTests('', '<slot id="slot" name="foo"></slot>', (shadowRoot) => shadowRoot.querySelector('slot').name = 'bar', ['slot'],
>+ 'slotchange event should fire when renaming a named slot element when there is an assigned node to the slot of the old name');
>+
>+generateTests('', '<slot id="slot1" name="foo"></slot><slot id="slot2" name="foo"></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('slot2').name = 'bar', [],
>+ 'slotchange event should not fire when renaming the second slot element of a given name and there is no assigned node of the new name');
>+generateTests('', '<slot id="slot1" name="foo"></slot><slot id="slot2" name="foo"></slot>',
>+ (shadowRoot) => shadowRoot.getElementById('slot1').name = 'bar', ['slot1', 'slot2'],
>+ 'slotchange event should fire when renaming the slot element of a given name and there is an assigned node and a second slot element');
>+
>+</script>
>+</body>
>+</html>
>Index: LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-customelements-expected.txt
>===================================================================
>--- LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-customelements-expected.txt	(revision 235581)
>+++ LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-customelements-expected.txt	(working copy)
>@@ -1,3 +1,3 @@
> 
>-FAIL slotchange must fire on initialization of custom elements with slotted children assert_true: expected true got false
>+PASS slotchange must fire on initialization of custom elements with slotted children 
> 
>Index: LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-event-expected.txt
>===================================================================
>--- LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-event-expected.txt	(revision 235581)
>+++ LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-event-expected.txt	(working copy)
>@@ -1,10 +1,4 @@
>-CONSOLE MESSAGE: line 2659: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
>-CONSOLE MESSAGE: line 2659: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
>-CONSOLE MESSAGE: line 2659: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
>-CONSOLE MESSAGE: line 2659: Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
> 
>-Harness Error (FAIL), message = Error: assert_equals: slotchange must not be fired on a slot element if the assigned nodes changed after the slot was removed expected 2 but got 0
>-
> PASS slotchange event must fire on a default slot element inside an open shadow root in a document 
> PASS slotchange event must fire on a default slot element inside a closed shadow root in a document 
> PASS slotchange event must fire on a default slot element inside an open shadow root not in a document 
>@@ -17,10 +11,10 @@
> PASS slotchange event must not fire on a slot element inside a closed shadow root in a document when another slot's assigned nodes change 
> PASS slotchange event must not fire on a slot element inside an open shadow root not in a document when another slot's assigned nodes change 
> PASS slotchange event must not fire on a slot element inside a closed shadow root not in a document when another slot's assigned nodes change 
>-FAIL slotchange event must fire on a slot element when a shadow host has a slotable and the slot was inserted and must not fire when the shadow host was mutated after the slot was removed inside an open shadow root in a document assert_equals: slotchange must be fired on a slot element if there is assigned nodes when the slot was inserted expected 1 but got 0
>-FAIL slotchange event must fire on a slot element when a shadow host has a slotable and the slot was inserted and must not fire when the shadow host was mutated after the slot was removed inside a closed shadow root in a document assert_equals: slotchange must be fired on a slot element if there is assigned nodes when the slot was inserted expected 1 but got 0
>-FAIL slotchange event must fire on a slot element when a shadow host has a slotable and the slot was inserted and must not fire when the shadow host was mutated after the slot was removed inside an open shadow root not in a document assert_equals: slotchange must be fired on a slot element if there is assigned nodes when the slot was inserted expected 1 but got 0
>-FAIL slotchange event must fire on a slot element when a shadow host has a slotable and the slot was inserted and must not fire when the shadow host was mutated after the slot was removed inside a closed shadow root not in a document assert_equals: slotchange must be fired on a slot element if there is assigned nodes when the slot was inserted expected 1 but got 0
>+PASS slotchange event must fire on a slot element when a shadow host has a slotable and the slot was inserted and must not fire when the shadow host was mutated after the slot was removed inside an open shadow root in a document 
>+PASS slotchange event must fire on a slot element when a shadow host has a slotable and the slot was inserted and must not fire when the shadow host was mutated after the slot was removed inside a closed shadow root in a document 
>+PASS slotchange event must fire on a slot element when a shadow host has a slotable and the slot was inserted and must not fire when the shadow host was mutated after the slot was removed inside an open shadow root not in a document 
>+PASS slotchange event must fire on a slot element when a shadow host has a slotable and the slot was inserted and must not fire when the shadow host was mutated after the slot was removed inside a closed shadow root not in a document 
> PASS slotchange event must fire on a slot element inside an open shadow root in a document even if the slot was removed immediately after the assigned nodes were mutated 
> PASS slotchange event must fire on a slot element inside a closed shadow root in a document even if the slot was removed immediately after the assigned nodes were mutated 
> PASS slotchange event must fire on a slot element inside an open shadow root not in a document even if the slot was removed immediately after the assigned nodes were mutated 
>@@ -29,10 +23,10 @@
> PASS slotchange event must fire on a slot element inside a closed shadow root in a document when innerHTML modifies the children of the shadow host 
> PASS slotchange event must fire on a slot element inside an open shadow root not in a document when innerHTML modifies the children of the shadow host 
> PASS slotchange event must fire on a slot element inside a closed shadow root not in a document when innerHTML modifies the children of the shadow host 
>-FAIL slotchange event must fire on a slot element inside an open shadow root in a document when nested slots's contents change assert_equals: slotchange event's target must be the inner slot element at 1st slotchange expected Element node <slot></slot> but got Element node <slot></slot>
>-FAIL slotchange event must fire on a slot element inside a closed shadow root in a document when nested slots's contents change assert_equals: slotchange event's target must be the inner slot element at 1st slotchange expected Element node <slot></slot> but got Element node <slot></slot>
>-FAIL slotchange event must fire on a slot element inside an open shadow root not in a document when nested slots's contents change assert_equals: slotchange event's target must be the inner slot element at 1st slotchange expected Element node <slot></slot> but got Element node <slot></slot>
>-FAIL slotchange event must fire on a slot element inside a closed shadow root not in a document when nested slots's contents change assert_equals: slotchange event's target must be the inner slot element at 1st slotchange expected Element node <slot></slot> but got Element node <slot></slot>
>+PASS slotchange event must fire on a slot element inside an open shadow root in a document when nested slots's contents change 
>+PASS slotchange event must fire on a slot element inside a closed shadow root in a document when nested slots's contents change 
>+PASS slotchange event must fire on a slot element inside an open shadow root not in a document when nested slots's contents change 
>+PASS slotchange event must fire on a slot element inside a closed shadow root not in a document when nested slots's contents change 
> PASS slotchange event must fire at the end of current microtask after mutation observers are invoked inside an open shadow root in a document when slots's contents change 
> PASS slotchange event must fire at the end of current microtask after mutation observers are invoked inside a closed shadow root in a document when slots's contents change 
> PASS slotchange event must fire at the end of current microtask after mutation observers are invoked inside an open shadow root not in a document when slots's contents change 
>Index: LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-expected.txt
>===================================================================
>--- LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-expected.txt	(revision 235581)
>+++ LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-expected.txt	(working copy)
>@@ -1,19 +1,17 @@
> 
>-Harness Error (TIMEOUT), message = null
>-
> PASS slotchange event: Append a child to a host. 
> PASS slotchange event: Remove a child from a host. 
> PASS slotchange event: Remove a child before adding an event listener. 
> PASS slotchange event: Change slot= attribute to make it un-assigned. 
>-TIMEOUT slotchange event: Change slot's name= attribute so that none is assigned. Test timed out
>+PASS slotchange event: Change slot's name= attribute so that none is assigned. 
> PASS slotchange event: Change slot= attribute to make it assigned. 
>-TIMEOUT slotchange event: Change slot's name= attribute so that a node is assigned to the slot. Test timed out
>+PASS slotchange event: Change slot's name= attribute so that a node is assigned to the slot. 
> PASS slotchange event: Add a fallback content. 
> PASS slotchange event: Remove a fallback content. 
> PASS slotchange event: Add a fallback content to nested slots. 
> PASS slotchange event: Remove a fallback content from nested slots. 
>-TIMEOUT slotchange event: Insert a slot before an existing slot. Test timed out
>-TIMEOUT slotchange event: Remove a preceding slot. Test timed out
>+PASS slotchange event: Insert a slot before an existing slot. 
>+PASS slotchange event: Remove a preceding slot. 
> PASS slotchange event: A slot is assigned to another slot. 
> PASS slotchange event: Even if distributed nodes do not change, slotchange should be fired if assigned nodes are changed. 
>

Actions: View | Formatted Diff | Diff

Attachments on bug 189144: 348477 | 348486 | 348490 | 348583 | 348594 | 348697 | 348699 | 348709 | 348710 | 348711 | 348839