Attachment 348677 Details for Bug 189212 – ROLLOUT of r235565

[patch] ROLLOUT of r235565

bug-189212-20180831182521.patch (text/plain), 2.17 KB, created by WebKit Commit Bot on 2018-08-31 15:25:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2018-08-31 15:25:22 PDT

Size: 2.17 KB

patch

obsolete

>Subversion Revision: 235571
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 7a499fd5f42edb18d476bbb3b429090750209c11..bd49040f025dbf58c6e4a237f2028f8c1b5fe4d1 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-31  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r235565.
>+        https://bugs.webkit.org/show_bug.cgi?id=189212
>+
>+        Broke the WHLSL build (Requested by litherum on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[WHLSL] Remove useless code in NameResolver"
>+        https://bugs.webkit.org/show_bug.cgi?id=189176
>+        https://trac.webkit.org/changeset/235565
>+
> 2018-08-31  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WHLSL] Remove useless code in NameResolver
>diff --git a/Tools/WebGPUShadingLanguageRI/NameResolver.js b/Tools/WebGPUShadingLanguageRI/NameResolver.js
>index a5da2ca5c1e2b9edee095f1664a2bc4b8f308284..9a099f485e6e927e16437bbf82641f61e4525cf1 100644
>--- a/Tools/WebGPUShadingLanguageRI/NameResolver.js
>+++ b/Tools/WebGPUShadingLanguageRI/NameResolver.js
>@@ -166,6 +166,16 @@ class NameResolver extends Visitor {
>         super.visitReturn(node);
>     }
>     
>+    _handlePropertyAccess(node)
>+    {
>+        node.possibleGetOverloads = this._nameContext.get(Func, node.getFuncName);
>+        node.possibleSetOverloads = this._nameContext.get(Func, node.setFuncName);
>+        node.possibleAndOverloads = this._nameContext.get(Func, node.andFuncName);
>+
>+        if (!node.possibleGetOverloads && !node.possibleAndOverloads)
>+            throw new WTypeError(node.origin.originString, "Cannot find either " + node.getFuncName + " or " + node.andFuncName);
>+    }
>+    
>     visitDotExpression(node)
>     {
>         // This could be a reference to an enum. Let's resolve that now.
>@@ -180,9 +190,16 @@ class NameResolver extends Visitor {
>             }
>         }
>         
>+        this._handlePropertyAccess(node);
>         super.visitDotExpression(node);
>     }
>     
>+    visitIndexExpression(node)
>+    {
>+        this._handlePropertyAccess(node);
>+        super.visitIndexExpression(node);
>+    }
>+    
>     visitCallExpression(node)
>     {
>         let funcs = this._nameContext.get(Func, node.name);

Actions: View | Formatted Diff | Diff

Attachments on bug 189212: 348677