WebKit Bugzilla
Attachment 348673 Details for
Bug 189211
: Added runtime feature flag for web API statistics
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-189211-20180831144513.patch (text/plain), 3.08 KB, created by
Woodrow Wang
on 2018-08-31 14:45:14 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Woodrow Wang
Created:
2018-08-31 14:45:14 PDT
Size:
3.08 KB
patch
obsolete
>Subversion Revision: 235561 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 419ea9c99c654386a88bd8fff3fa07b0c6c2a1f5..b011c14e7223e76a4e19b8bad30fa1e0dda8c566 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-08-31 Woodrow Wang <woodrow_wang@apple.com> >+ >+ Added runtime feature flag for web API statistics >+ https://bugs.webkit.org/show_bug.cgi?id=189211 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Added functionality to get and set the runtime flag. >+ >+ * page/RuntimeEnabledFeatures.h: >+ (WebCore::RuntimeEnabledFeatures::setWebAPIStatisticsEnabled): >+ (WebCore::RuntimeEnabledFeatures::webAPIStatisticsEnabled const): >+ > 2018-08-31 Zalan Bujtas <zalan@apple.com> > > [LFC] Add margin box verification back now that Display::Box has non-computed horizontal margin. >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 118567858bd63fbcfa61080050e1df637327cf43..7712b0dabad8ff9edd2c523a7633f9f5e3b9ffdb 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,12 @@ >+2018-08-31 Woodrow Wang <woodrow_wang@apple.com> >+ >+ Added runtime feature flag for web API statistics >+ https://bugs.webkit.org/show_bug.cgi?id=189211 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Shared/WebPreferences.yaml: >+ > 2018-08-31 Antti Koivisto <antti@apple.com> > > Replace OptionSet |= and -= operators with add() and remove() functions >diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h >index bc83f8aab8ab1ede7b68a103c4fd0e1f6f93161f..3b2dcad7f5efe0e4e3b6bb12a26acf52df40d394 100644 >--- a/Source/WebCore/page/RuntimeEnabledFeatures.h >+++ b/Source/WebCore/page/RuntimeEnabledFeatures.h >@@ -285,6 +285,9 @@ public: > void setAttrStyleEnabled(bool isEnabled) { m_attrStyleEnabled = isEnabled; } > bool attrStyleEnabled() const { return m_attrStyleEnabled; } > >+ void setWebAPIStatisticsEnabled(bool isEnabled) { m_webAPIStatisticsEnabled = isEnabled; } >+ bool webAPIStatisticsEnabled() const { return m_webAPIStatisticsEnabled; } >+ > WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures(); > > private: >@@ -429,6 +432,8 @@ private: > > bool m_attrStyleEnabled { false }; > >+ bool m_webAPIStatisticsEnabled { false }; >+ > friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>; > }; > >diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml >index 94a01eb260e6fe47118818c6c077d9c1b7bf9efc..8c9aaeeec2237aa3f2497963357c3a443be4fbcb 100644 >--- a/Source/WebKit/Shared/WebPreferences.yaml >+++ b/Source/WebKit/Shared/WebPreferences.yaml >@@ -1331,3 +1331,11 @@ SourceBufferChangeTypeEnabled: > humanReadableDescription: "Enable Media Source Codec Switching through changeType()" > category: experimental > condition: ENABLE(MEDIA_SOURCE) >+ >+WebAPIStatisticsEnabled: >+ type: bool >+ defaultValue: false >+ humanReadableName: "Web API Statistics" >+ humanReadableDescription: "Enable Web API Statistics" >+ webcoreBinding: RuntimeEnabledFeatures >+ category: experimental
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 189211
:
348673
|
348829
|
348931