Attachment 348672 Details for Bug 189209 – Patch

[patch] Patch

bug-189209-20180831142151.patch (text/plain), 7.98 KB, created by Jer Noble on 2018-08-31 14:21:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-08-31 14:21:52 PDT

Size: 7.98 KB

patch

obsolete

>Subversion Revision: 235558
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ab01e0ddbd4f73ea623b1fba610c695b058f3a25..ece3f0f644f2ef57a79951d0a239cab012ac96f8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-08-31  Jer Noble  <jer.noble@apple.com>
>+
>+        Add MediaCapabilities as an Experimental Feature
>+        https://bugs.webkit.org/show_bug.cgi?id=189209
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Move mediaCapabilitiesEnabled out of RuntimeEnabledFeatures. It already (also) exists in Settings.
>+
>+        * Modules/mediacapabilities/MediaCapabilities.idl:
>+        * Modules/mediacapabilities/MediaCapabilitiesInfo.idl:
>+        * Modules/mediacapabilities/NavigatorMediaCapabilities.idl:
>+        * Modules/mediacapabilities/ScreenLuminance.idl:
>+        * page/RuntimeEnabledFeatures.h:
>+        (WebCore::RuntimeEnabledFeatures::setMediaCapabilitiesEnabled): Deleted.
>+        (WebCore::RuntimeEnabledFeatures::mediaCapabilitiesEnabled const): Deleted.
>+
> 2018-08-29  Jer Noble  <jer.noble@apple.com>
> 
>         Enable USE_MEDIAREMOTE on iOS
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 28822e23cc4ae5516ccae19b3079944546b1d91d..14a2942c176445213ab5e803413802679a874ef6 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-08-31  Jer Noble  <jer.noble@apple.com>
>+
>+        Add MediaCapabilities as an Experimental Feature
>+        https://bugs.webkit.org/show_bug.cgi?id=189209
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+
> 2018-08-22  Jer Noble  <jer.noble@apple.com>
> 
>         Refactoring: eliminate raw pointer usage in Fullscreen code
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index 8919ddc2ed495a4e876e9ee8d4e5a0bc1fdb59da..35a4149b8c1e49ddfc54a41f98b32df1af58d0de 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-31  Jer Noble  <jer.noble@apple.com>
>+
>+        Add MediaCapabilities as an Experimental Feature
>+        https://bugs.webkit.org/show_bug.cgi?id=189209
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        RuntimeEnabledFeature -> Setting.
>+
>+        * WebView/WebView.mm:
>+        (-[WebView _preferencesChanged:]):
>+
> 2018-08-22  Jer Noble  <jer.noble@apple.com>
> 
>         Refactoring: eliminate raw pointer usage in Fullscreen code
>diff --git a/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl b/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl
>index 60281b5e9fefd3bce4f9ba7b34b4b85364106fdd..cbc0d2dc77493ecfceaa80fa109c4dc6517279a7 100644
>--- a/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl
>+++ b/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl
>@@ -24,7 +24,7 @@
>  */
> 
> [
>-    EnabledAtRuntime=MediaCapabilities,
>+    EnabledBySetting=MediaCapabilities,
>     ImplementationLacksVTable
> ]
> interface MediaCapabilities {
>diff --git a/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesInfo.idl b/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesInfo.idl
>index 0940d7942ed14868fbd4520105d14eb22412cf6d..b2525e576cb38b504b15d61f84c69b7d78ca93a9 100644
>--- a/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesInfo.idl
>+++ b/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesInfo.idl
>@@ -24,7 +24,7 @@
>  */
> 
> [
>-    EnabledAtRuntime=MediaCapabilities,
>+    EnabledBySetting=MediaCapabilities,
>     ImplementationLacksVTable
> ]
> interface MediaCapabilitiesInfo {
>diff --git a/Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.idl b/Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.idl
>index 3d605ba7a8fef6efc35832ed2a8bfec1206a2e0a..a2bf3f71b6d08810d90b741c9b5b0525da97797b 100644
>--- a/Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.idl
>+++ b/Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.idl
>@@ -23,7 +23,7 @@
>  * THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>-[ EnabledAtRuntime=MediaCapabilities ]
>+[ EnabledBySetting=MediaCapabilities ]
> partial interface Navigator {
>     [SameObject] readonly attribute MediaCapabilities mediaCapabilities;
> };
>diff --git a/Source/WebCore/Modules/mediacapabilities/ScreenLuminance.idl b/Source/WebCore/Modules/mediacapabilities/ScreenLuminance.idl
>index 395bae054166c20c15dc11ead7c5cb846d0ad2cd..9e3dcabb08ade5487f375321f4dba1eaca9657ba 100644
>--- a/Source/WebCore/Modules/mediacapabilities/ScreenLuminance.idl
>+++ b/Source/WebCore/Modules/mediacapabilities/ScreenLuminance.idl
>@@ -24,7 +24,7 @@
>  */
> 
> [
>-    EnabledAtRuntime=MediaCapabilities,
>+    EnabledBySetting=MediaCapabilities,
>     ImplementationLacksVTable
> ]
> interface ScreenLuminance {
>diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h
>index bc83f8aab8ab1ede7b68a103c4fd0e1f6f93161f..e8a4b1a22dcea6c8c9e4f9ada2565569afa87d5e 100644
>--- a/Source/WebCore/page/RuntimeEnabledFeatures.h
>+++ b/Source/WebCore/page/RuntimeEnabledFeatures.h
>@@ -250,9 +250,6 @@ public:
>     void setAriaReflectionEnabled(bool isEnabled) { m_ariaReflectionEnabled = isEnabled; }
>     bool ariaReflectionEnabled() const { return m_ariaReflectionEnabled; }
> 
>-    void setMediaCapabilitiesEnabled(bool isEnabled) { m_mediaCapabilitiesEnabled = isEnabled; }
>-    bool mediaCapabilitiesEnabled() const { return m_mediaCapabilitiesEnabled; }
>-
>     void setResourceLoadStatisticsDebugMode(bool isEnabled) { m_resourceLoadStatisticsDebugMode = isEnabled; }
>     bool resourceLoadStatisticsDebugMode() const { return m_resourceLoadStatisticsDebugMode; }
> 
>@@ -413,7 +410,6 @@ private:
>     bool m_webVREnabled { false };
>     bool m_accessibilityObjectModelEnabled { false };
>     bool m_ariaReflectionEnabled { true };
>-    bool m_mediaCapabilitiesEnabled { false };
>     bool m_resourceLoadStatisticsDebugMode { false };
>     bool m_isRestrictedHTTPResponseAccess { true };
>     bool m_crossOriginResourcePolicyEnabled { true };
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 94a01eb260e6fe47118818c6c077d9c1b7bf9efc..cfb0ff86830e38300398b73803c47134b70feb7d 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1047,8 +1047,10 @@ ShouldAllowUserInstalledFonts:
> 
> MediaCapabilitiesEnabled:
>   type: bool
>-  defaultValue: false
>-  webcoreBinding: RuntimeEnabledFeatures
>+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>+  humanReadableName: "Media Capabilities API"
>+  humanReadableDescription: "Media Capabilities API"
>+  category: experimental
> 
> SystemPreviewEnabled:
>   type: bool
>diff --git a/Source/WebKitLegacy/mac/WebView/WebView.mm b/Source/WebKitLegacy/mac/WebView/WebView.mm
>index 8bb1159b1bf57110b81b52ed6842cb823e5f4906..26b78907ab131f4ac146b0853f1c2d31c95a2fde 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebView.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebView.mm
>@@ -3124,7 +3124,6 @@ - (void)_preferencesChanged:(WebPreferences *)preferences
>     RuntimeEnabledFeatures::sharedFeatures().setMenuItemElementEnabled([preferences menuItemElementEnabled]);
>     RuntimeEnabledFeatures::sharedFeatures().setAccessibilityObjectModelEnabled([preferences accessibilityObjectModelEnabled]);
>     RuntimeEnabledFeatures::sharedFeatures().setAriaReflectionEnabled([preferences ariaReflectionEnabled]);
>-    RuntimeEnabledFeatures::sharedFeatures().setMediaCapabilitiesEnabled([preferences mediaCapabilitiesEnabled]);
>     RuntimeEnabledFeatures::sharedFeatures().setFetchAPIKeepAliveEnabled([preferences fetchAPIKeepAliveEnabled]);
> 
> #if ENABLE(LEGACY_ENCRYPTED_MEDIA)
>@@ -3169,6 +3168,7 @@ - (void)_preferencesChanged:(WebPreferences *)preferences
> 
>     settings.setLargeImageAsyncDecodingEnabled([preferences largeImageAsyncDecodingEnabled]);
>     settings.setAnimatedImageAsyncDecodingEnabled([preferences animatedImageAsyncDecodingEnabled]);
>+    settings.setMediaCapabilitiesEnabled([preferences mediaCapabilitiesEnabled]);
> 
>     RuntimeEnabledFeatures::sharedFeatures().setServerTimingEnabled([preferences serverTimingEnabled]);
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 189209: 348672