Attachment 348665 Details for Bug 189203 – Patch

[patch] Patch

bug-189203-20180831125212.patch (text/plain), 1.57 KB, created by Jer Noble on 2018-08-31 12:52:12 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-08-31 12:52:12 PDT

Size: 1.57 KB

patch

obsolete

>Subversion Revision: 235558
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 4f68af4d1c40902995bc8a124907e8b0cf9bf0f6..a7bd37b0e879db60d9da2f3d654953ff062c5f2d 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-31  Jer Noble  <jer.noble@apple.com>
>+
>+        Compile error in RealtimeOutgoingVideoSource.cpp; unused parameter in libwebrtc header
>+        https://bugs.webkit.org/show_bug.cgi?id=189203
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If RealtimeOutgoingVideoSource.cpp is compiled alone (non-unified) or if it is the first file compiled in
>+        a unified build, there is no pragma set to ignore unused parameter warnings in place.
>+
>+        * platform/mediastream/RealtimeOutgoingVideoSource.cpp:
>+
> 2018-08-29  Jer Noble  <jer.noble@apple.com>
> 
>         Enable USE_MEDIAREMOTE on iOS
>diff --git a/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp b/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp
>index 544a4436ce41711b2afc2b4cf520f90badb2ea62..14a8e94bd2b8a8b3e8eaef707c16cdf0c60e7b18 100644
>--- a/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp
>+++ b/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp
>@@ -32,8 +32,15 @@
> #if USE(LIBWEBRTC)
> 
> #include "Logging.h"
>+
>+#pragma GCC diagnostic push
>+#pragma GCC diagnostic ignored "-Wunused-parameter"
>+
> #include <webrtc/api/video/i420_buffer.h>
> #include <webrtc/common_video/libyuv/include/webrtc_libyuv.h>
>+
>+#pragma GCC diagnostic pop
>+
> #include <wtf/MainThread.h>
> 
> namespace WebCore {

Actions: View | Formatted Diff | Diff

Attachments on bug 189203: 348665