Attachment 348636 Details for Bug 189190 – Patch

[patch] Patch

bug-189190-20180831145346.patch (text/plain), 1.98 KB, created by Frédéric Wang (:fredw) on 2018-08-31 05:53:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Wang (:fredw)

Created: 2018-08-31 05:53:48 PDT

Size: 1.98 KB

patch

obsolete

>Subversion Revision: 235540
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f82d9f4ee2f863a2c363f6ea5b9317b85a465f73..6532d96c2091d470a36304640e35d897448f6a70 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-31  Frederic Wang  <fwang@igalia.com>
>+
>+        REGRESSION(r235398) ASSERTION failure in WKPageSetPageLoaderClient with external SDK build
>+        https://bugs.webkit.org/show_bug.cgi?id=189190
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Assertions to prevent use of the deprecated WKPageSetPageLoaderClient class are hit when
>+        running Safari builds with the external SDK. This patch conditionally skips these assertions.
>+
>+        * UIProcess/API/C/WKPage.cpp:
>+        (WKPageSetPageLoaderClient):
>+
> 2018-08-31  Frederic Wang  <fwang@igalia.com>
> 
>         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
>diff --git a/Source/WebKit/UIProcess/API/C/WKPage.cpp b/Source/WebKit/UIProcess/API/C/WKPage.cpp
>index 0399741a2e2e1bd1534ad592fbb300fe10b3fa72..134b46b3d077e85448412cf88242f4592893ac86 100644
>--- a/Source/WebKit/UIProcess/API/C/WKPage.cpp
>+++ b/Source/WebKit/UIProcess/API/C/WKPage.cpp
>@@ -1044,6 +1044,7 @@ void WKPageSetPageLoaderClient(WKPageRef pageRef, const WKPageLoaderClientBase*
>             initialize(client);
>             
>             // WKPageSetPageLoaderClient is deprecated. Use WKPageSetPageNavigationClient instead.
>+#if USE(APPLE_INTERNAL_SDK)
>             RELEASE_ASSERT(!m_client.didFinishDocumentLoadForFrame);
>             RELEASE_ASSERT(!m_client.didSameDocumentNavigationForFrame);
>             RELEASE_ASSERT(!m_client.didReceiveTitleForFrame);
>@@ -1075,6 +1076,7 @@ void WKPageSetPageLoaderClient(WKPageRef pageRef, const WKPageLoaderClientBase*
>             RELEASE_ASSERT(!m_client.navigationGestureDidBegin);
>             RELEASE_ASSERT(!m_client.navigationGestureWillEnd);
>             RELEASE_ASSERT(!m_client.navigationGestureDidEnd);
>+#endif
>         }
> 
>     private:

Actions: View | Formatted Diff | Diff

Attachments on bug 189190: 348636 | 348762 | 348822