Attachment 348629 Details for Bug 189151 – Patch

[patch] Patch

bug-189151-20180831192855.patch (text/plain), 6.61 KB, created by Yusuke Suzuki on 2018-08-31 03:28:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-08-31 03:28:56 PDT

Size: 6.61 KB

patch

obsolete

>Subversion Revision: 235540
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index ee6c6ca88221a82470a2402732f00cd870253484..70d62b3f770a813dcfb64febf9f35d98a85e7818 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,27 @@
>+2018-08-31  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
>+
>+        [DFG] DFG should handle String#toString
>+        https://bugs.webkit.org/show_bug.cgi?id=189151
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        String#toString and String#valueOf can be easily handled in DFG by using Check and ToString nodes.
>+        Since both operations (actually String#toString and String#valueOf are the same function instance)
>+        only accept String and StringObject, we emit Check(StringOrStringObjectUse) to make the other types
>+        OSR exits. And we put ToString node for an argument. This ToString node will be correctly lowered
>+        to Identity or ToString with an appropriate check in the fixup phase.
>+
>+        It improves simple microbenchmarks by 38 - 46%.
>+
>+                                              baseline                  patched
>+
>+            string-object-value-of        21.7000+-3.6626     ^     14.8482+-0.3012        ^ definitely 1.4615x faster
>+            string-object-to-string       20.4092+-0.7659     ^     14.7324+-0.2914        ^ definitely 1.3853x faster
>+
>+
>+        * dfg/DFGByteCodeParser.cpp:
>+        (JSC::DFG::ByteCodeParser::handleIntrinsicCall):
>+
> 2018-08-31  Mark Lam  <mark.lam@apple.com>
> 
>         Add missing exception check in arrayProtoFuncLastIndexOf().
>diff --git a/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp b/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
>index d1e6d1951aad3ab18f86b465051f999fc1cb96d6..0a346aa1bd87cb425270a507900ea0786c612958 100644
>--- a/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
>+++ b/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
>@@ -2691,6 +2691,14 @@ bool ByteCodeParser::handleIntrinsicCall(Node* callee, int resultOperand, Intrin
>         return true;
>     }
> 
>+    case StringPrototypeValueOfIntrinsic: {
>+        insertChecks();
>+        Node* value = get(virtualRegisterForArgument(0, registerOffset));
>+        addToGraph(Check, Edge(value, StringOrStringObjectUse));
>+        set(VirtualRegister(resultOperand), addToGraph(ToString, value));
>+        return true;
>+    }
>+
>     case StringPrototypeReplaceIntrinsic: {
>         if (argumentCountIncludingThis != 3)
>             return false;
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index fa5c6d6e6deae01486dc83986661ee1e5bd0c536..5f10ed6356e35c890f1e2bcb23e25e6ca72e229e 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,25 @@
>+2018-08-31  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
>+
>+        [DFG] DFG should handle String#toString
>+        https://bugs.webkit.org/show_bug.cgi?id=189151
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * microbenchmarks/string-object-to-string.js: Added.
>+        (test):
>+        * microbenchmarks/string-object-value-of.js: Added.
>+        (test):
>+        * stress/string-to-string.js: Added.
>+        (shouldBe):
>+        (test1):
>+        (test2):
>+        (test3):
>+        * stress/string-value-of.js: Added.
>+        (shouldBe):
>+        (test1):
>+        (test2):
>+        (test3):
>+
> 2018-08-31  Mark Lam  <mark.lam@apple.com>
> 
>         Add missing exception check in arrayProtoFuncLastIndexOf().
>diff --git a/JSTests/microbenchmarks/string-object-to-string.js b/JSTests/microbenchmarks/string-object-to-string.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..8d866550df94cd23a38ed2aa4b6d636491da70cd
>--- /dev/null
>+++ b/JSTests/microbenchmarks/string-object-to-string.js
>@@ -0,0 +1,15 @@
>+const chars = 'abcdefghijklmnopqrstuvwxyz';
>+var prim = '';
>+for (var i = 0; i < 32768; i++) {
>+    prim += chars.charAt(~~(Math.random() * 26));
>+}
>+const obj = new String(prim);
>+
>+function test(obj)
>+{
>+    return obj.toString();
>+}
>+noInline(test);
>+
>+for (var i = 0; i < 1e6; ++i)
>+    test(obj);
>diff --git a/JSTests/microbenchmarks/string-object-value-of.js b/JSTests/microbenchmarks/string-object-value-of.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..b71eb9c579836a800445f805c8cf4df1d3ac4f40
>--- /dev/null
>+++ b/JSTests/microbenchmarks/string-object-value-of.js
>@@ -0,0 +1,15 @@
>+const chars = 'abcdefghijklmnopqrstuvwxyz';
>+var prim = '';
>+for (var i = 0; i < 32768; i++) {
>+    prim += chars.charAt(~~(Math.random() * 26));
>+}
>+const obj = new String(prim);
>+
>+function test(obj)
>+{
>+    return obj.valueOf();
>+}
>+noInline(test);
>+
>+for (var i = 0; i < 1e6; ++i)
>+    test(obj);
>diff --git a/JSTests/stress/string-to-string.js b/JSTests/stress/string-to-string.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..ba0e7e3d60ad6575dcaa370cc958f9daa6e476cc
>--- /dev/null
>+++ b/JSTests/stress/string-to-string.js
>@@ -0,0 +1,38 @@
>+function shouldBe(actual, expected) {
>+    if (actual !== expected)
>+        throw new Error('bad value: ' + actual);
>+}
>+
>+function test1(string)
>+{
>+    return string.toString();
>+}
>+noInline(test1);
>+
>+function test2(string)
>+{
>+    return string.toString();
>+}
>+noInline(test2);
>+
>+function test3(string)
>+{
>+    return string.toString();
>+}
>+noInline(test3);
>+
>+var string = "Hello";
>+var stringObject = new String(string);
>+
>+for (var i = 0; i < 1e6; ++i) {
>+    shouldBe(test1(string), string);
>+    shouldBe(test2(stringObject), string);
>+    if (i & 1)
>+        shouldBe(test3(string), string);
>+    else
>+        shouldBe(test3(stringObject), string);
>+}
>+
>+shouldBe(test1({}), `[object Object]`);
>+shouldBe(test2({}), `[object Object]`);
>+shouldBe(test3({}), `[object Object]`);
>diff --git a/JSTests/stress/string-value-of.js b/JSTests/stress/string-value-of.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..f49cbc0aa9940c9c0f0027f3b38d516805e5de5a
>--- /dev/null
>+++ b/JSTests/stress/string-value-of.js
>@@ -0,0 +1,38 @@
>+function shouldBe(actual, expected) {
>+    if (actual !== expected)
>+        throw new Error('bad value: ' + actual);
>+}
>+
>+function test1(string)
>+{
>+    return string.valueOf();
>+}
>+noInline(test1);
>+
>+function test2(string)
>+{
>+    return string.valueOf();
>+}
>+noInline(test2);
>+
>+function test3(string)
>+{
>+    return string.valueOf();
>+}
>+noInline(test3);
>+
>+var string = "Hello";
>+var stringObject = new String(string);
>+
>+for (var i = 0; i < 1e6; ++i) {
>+    shouldBe(test1(string), string);
>+    shouldBe(test2(stringObject), string);
>+    if (i & 1)
>+        shouldBe(test3(string), string);
>+    else
>+        shouldBe(test3(stringObject), string);
>+}
>+
>+shouldBe(test1({}), `[object Object]`);
>+shouldBe(test2({}), `[object Object]`);
>+shouldBe(test3({}), `[object Object]`);

Actions: View | Formatted Diff | Diff

Attachments on bug 189151: 348495 | 348629 | 348706 | 349041