Attachment 348579 Details for Bug 189114 – Patch

[patch] Patch

bug-189114-20180830190524.patch (text/plain), 8.36 KB, created by James Savage on 2018-08-30 19:05:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: James Savage

Created: 2018-08-30 19:05:25 PDT

Size: 8.36 KB

patch

obsolete

>Subversion Revision: 235452
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dc7c6c731c3bf075e5b37877668bf889c99c3e62..82b0d83376e423f1b1542a78c38ac00b473147be 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,35 @@
>+2018-08-30  James Savage  <james.savage@apple.com>
>+
>+        Long press on picture/link show menu obscured by keyboard.
>+        https://bugs.webkit.org/show_bug.cgi?id=189114.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use the visible bounds of the window, not the full bounds, when deciding if
>+        an element's rect takes up too much screen space to present from. This factors
>+        in occlusion of the window by the keyboard, bars, and other overlapping content.
>+
>+        If possible, it would be nice to only account for overlapping geometry which a
>+        popover would avoid, but that information is not available. This approach will
>+        produce some false positives in favor of the "from touch" style, but those are
>+        still better than getting an unusably small action sheet.
>+
>+        * UIProcess/ios/WKActionSheetAssistant.h:
>+        * UIProcess/ios/WKActionSheetAssistant.mm:
>+        (-[WKActionSheetAssistant showImageSheet]): Use new helper method for style.
>+        (-[WKActionSheetAssistant showLinkSheet]): Ditto.
>+        (-[WKActionSheetAssistant _presentationStyleForPositionInfo:elementInfo:]):
>+        Query new delegate method to figure out the unobscured rect of the window. This
>+        information only exists on WKScrollView, so we have to ask for it. If this method
>+        is not implemented, fall back to the current approach of assuming the full window
>+        bounds are available.
>+        (presentationStyleForView): Deleted. Replaced by instance method.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView unoccludedWindowBoundsForActionSheetAssistant:]):
>+        Calculate the unoccluded rect using -[UIScrollView adjustedContentInset], which
>+        factors in client specified insets and system insets (such as the keyboard).
>+
> 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
>diff --git a/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h b/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h
>index 25677e8b1c6a82048f1c37bb60ce599ce16cfc71..78915f6a619e997a8a0e7ea0f6978191d11a1c98 100644
>--- a/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h
>+++ b/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h
>@@ -54,6 +54,7 @@ struct InteractionInformationAtPosition;
> @optional
> - (BOOL)actionSheetAssistant:(WKActionSheetAssistant *)assistant showCustomSheetForElement:(_WKActivatedElementInfo *)element;
> - (void)updatePositionInformationForActionSheetAssistant:(WKActionSheetAssistant *)assistant;
>+- (CGRect)unoccludedWindowBoundsForActionSheetAssistant:(WKActionSheetAssistant *)assistant;
> - (void)actionSheetAssistant:(WKActionSheetAssistant *)assistant willStartInteractionWithElement:(_WKActivatedElementInfo *)element;
> - (void)actionSheetAssistantDidStopInteraction:(WKActionSheetAssistant *)assistant;
> - (NSDictionary *)dataDetectionContextForActionSheetAssistant:(WKActionSheetAssistant *)assistant;
>diff --git a/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm b/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
>index 6f748b4c1401781538f243a8726d810848e0f0fd..2018eae7094d12fa19a100da943999b7a13a1170 100644
>--- a/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
>+++ b/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
>@@ -372,7 +372,7 @@ - (void)showImageSheet
> 
>         _elementInfo = WTFMove(elementInfo);
> 
>-        if (![_interactionSheet presentSheet:presentationStyleForView(_view.getAutoreleased(), _positionInformation.value(), _elementInfo.get())])
>+        if (![_interactionSheet presentSheet:[self _presentationStyleForPositionInfo:_positionInformation.value() elementInfo:_elementInfo.get()]])
>             [self cleanupSheet];
>     };
> 
>@@ -394,24 +394,29 @@ - (void)showImageSheet
>     showImageSheetWithAlternateURLBlock(nil, nil);
> }
> 
>-static WKActionSheetPresentationStyle presentationStyleForView(UIView *view, const WebKit::InteractionInformationAtPosition& positionInfo, _WKActivatedElementInfo *elementInfo)
>+- (WKActionSheetPresentationStyle)_presentationStyleForPositionInfo:(const WebKit::InteractionInformationAtPosition&)positionInfo elementInfo:(_WKActivatedElementInfo *)elementInfo
> {
>-    auto apparentElementRect = [view convertRect:positionInfo.bounds toView:view.window];
>+    auto apparentElementRect = [_view convertRect:positionInfo.bounds toView:[_view window]];
>     if (CGRectIsEmpty(apparentElementRect))
>         return WKActionSheetPresentAtTouchLocation;
> 
>-    auto windowRect = view.window.bounds;
>-    apparentElementRect = CGRectIntersection(apparentElementRect, windowRect);
>+    CGRect visibleRect;
>+    auto delegate = _delegate.get();
>+    if ([delegate respondsToSelector:@selector(unoccludedWindowBoundsForActionSheetAssistant:)])
>+        visibleRect = [delegate unoccludedWindowBoundsForActionSheetAssistant:self];
>+    else
>+        visibleRect = [[_view window] bounds];
> 
>-    auto leftInset = CGRectGetMinX(apparentElementRect) - CGRectGetMinX(windowRect);
>-    auto topInset = CGRectGetMinY(apparentElementRect) - CGRectGetMinY(windowRect);
>-    auto rightInset = CGRectGetMaxX(windowRect) - CGRectGetMaxX(apparentElementRect);
>-    auto bottomInset = CGRectGetMaxY(windowRect) - CGRectGetMaxY(apparentElementRect);
>+    apparentElementRect = CGRectIntersection(apparentElementRect, visibleRect);
>+    auto leftInset = CGRectGetMinX(apparentElementRect) - CGRectGetMinX(visibleRect);
>+    auto topInset = CGRectGetMinY(apparentElementRect) - CGRectGetMinY(visibleRect);
>+    auto rightInset = CGRectGetMaxX(visibleRect) - CGRectGetMaxX(apparentElementRect);
>+    auto bottomInset = CGRectGetMaxY(visibleRect) - CGRectGetMaxY(apparentElementRect);
> 
>     // If at least this much of the window is available for the popover to draw in, then target the element rect when presenting the action menu popover.
>     // Otherwise, there is not enough space to position the popover around the element, so revert to using the touch location instead.
>     static const CGFloat minimumAvailableWidthOrHeightRatio = 0.4;
>-    if (std::max(leftInset, rightInset) <= minimumAvailableWidthOrHeightRatio * CGRectGetWidth(windowRect) && std::max(topInset, bottomInset) <= minimumAvailableWidthOrHeightRatio * CGRectGetHeight(windowRect))
>+    if (std::max(leftInset, rightInset) <= minimumAvailableWidthOrHeightRatio * CGRectGetWidth(visibleRect) && std::max(topInset, bottomInset) <= minimumAvailableWidthOrHeightRatio * CGRectGetHeight(visibleRect))
>         return WKActionSheetPresentAtTouchLocation;
> 
>     if (elementInfo.type == _WKActivatedElementTypeLink && positionInfo.linkIndicator.textRectsInBoundingRectCoordinates.size())
>@@ -539,7 +544,7 @@ - (void)showLinkSheet
> 
>     _elementInfo = WTFMove(elementInfo);
> 
>-    if (![_interactionSheet presentSheet:presentationStyleForView(_view.getAutoreleased(), _positionInformation.value(), _elementInfo.get())])
>+    if (![_interactionSheet presentSheet:[self _presentationStyleForPositionInfo:_positionInformation.value() elementInfo:_elementInfo.get()]])
>         [self cleanupSheet];
> }
> 
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 216e59c22fc0fb92c4141ba9cb7d222cb247ccc0..889e9a57c004d213c52746e8d7042e72483470f7 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -4817,6 +4817,15 @@ - (BOOL)actionSheetAssistant:(WKActionSheetAssistant *)assistant showCustomSheet
>     return NO;
> }
> 
>+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
>+- (CGRect)unoccludedWindowBoundsForActionSheetAssistant:(WKActionSheetAssistant *)assistant
>+{
>+    UIEdgeInsets contentInset = [[_webView scrollView] adjustedContentInset];
>+    CGRect rect = UIEdgeInsetsInsetRect([_webView bounds], contentInset);
>+    return [_webView convertRect:rect toView:[self window]];
>+}
>+#endif
>+
> - (RetainPtr<NSArray>)actionSheetAssistant:(WKActionSheetAssistant *)assistant decideActionsForElement:(_WKActivatedElementInfo *)element defaultActions:(RetainPtr<NSArray>)defaultActions
> {
>     return _page->uiClient().actionsForElement(element, WTFMove(defaultActions));

Actions: View | Formatted Diff | Diff

Attachments on bug 189114: 348447 | 348579